Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2938

Recursive delete of a large directory makes namenode unresponsive

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.23.2
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When deleting a large directory with millions of files, namenode holding FSNamesystem lock will make it unresponsive for other request. In this scenario HDFS-173 added a mechanism to delete blocks in smaller chunks holding the locks. With new read/write lock changes, the mechanism from HDFS-173 is lost. Need to resurrect the mechanism back. Also a good unit test/update to existing unit test is needed to catch future errors with this functionality.

      1. HDFS-2938.patch
        3 kB
        Hari Mankude
      2. HDFS-2938.patch
        3 kB
        Hari Mankude

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          3d 15h 32m 1 Hari Mankude 15/Feb/12 18:22
          Patch Available Patch Available Resolved Resolved
          3h 40m 1 Suresh Srinivas 15/Feb/12 22:03
          Eli Collins made changes -
          Fix Version/s 0.23.2 [ 12319852 ]
          Target Version/s 0.24.0, 0.23.2 [ 12317653, 12319852 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Please ignore my previous comment, i looked at wrong code base.

          Show
          Uma Maheswara Rao G added a comment - Please ignore my previous comment, i looked at wrong code base.
          Hide
          Uma Maheswara Rao G added a comment -

          I have just verified this issue across the versions, looks 22 branch also lost the mechanism of HDFS-173.
          So, we may have to back port this to 22 branch.

          Show
          Uma Maheswara Rao G added a comment - I have just verified this issue across the versions, looks 22 branch also lost the mechanism of HDFS-173 . So, we may have to back port this to 22 branch.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #992 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/992/)
          HDFS-2938. Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #992 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/992/ ) HDFS-2938 . Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #198 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/198/)
          HDFS-2938. Merging change 1244752 from trunk to 0.23 (Revision 1244754)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #198 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/198/ ) HDFS-2938 . Merging change 1244752 from trunk to 0.23 (Revision 1244754) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #957 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/957/)
          HDFS-2938. Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #957 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/957/ ) HDFS-2938 . Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #170 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/170/)
          HDFS-2938. Merging change 1244752 from trunk to 0.23 (Revision 1244754)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #170 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/170/ ) HDFS-2938 . Merging change 1244752 from trunk to 0.23 (Revision 1244754) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #559 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/559/)
          HDFS-2938. Merging change 1244752 from trunk to 0.23 (Revision 1244754)

          Result = ABORTED
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #559 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/559/ ) HDFS-2938 . Merging change 1244752 from trunk to 0.23 (Revision 1244754) Result = ABORTED suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1744 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1744/)
          HDFS-2938. Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1744 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1744/ ) HDFS-2938 . Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #556 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/556/)
          HDFS-2938. Merging change 1244752 from trunk to 0.23 (Revision 1244754)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #556 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/556/ ) HDFS-2938 . Merging change 1244752 from trunk to 0.23 (Revision 1244754) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #543 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/543/)
          HDFS-2938. Merging change 1244752 from trunk to 0.23 (Revision 1244754)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #543 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/543/ ) HDFS-2938 . Merging change 1244752 from trunk to 0.23 (Revision 1244754) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244754 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1732 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1732/)
          HDFS-2938. Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1732 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1732/ ) HDFS-2938 . Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1806 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1806/)
          HDFS-2938. Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1806 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1806/ ) HDFS-2938 . Recursive delete of a large directory make namenode unresponsive. Contributed by Hari Mankude. (Revision 1244752) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244752 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLargeDirectoryDelete.java
          Suresh Srinivas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 0.23.2, 0.24.0 [ 12319852, 12317653 ] 0.24.0, 0.23.2 [ 12317653, 12319852 ]
          Resolution Fixed [ 1 ]
          Hide
          Suresh Srinivas added a comment -

          Committed the patch to trunk and 0.23. Thank you Hari.

          Show
          Suresh Srinivas added a comment - Committed the patch to trunk and 0.23. Thank you Hari.
          Hide
          Suresh Srinivas added a comment -

          Thanks for taking care of the nits - from the original code. +1 for the patch.

          Show
          Suresh Srinivas added a comment - Thanks for taking care of the nits - from the original code. +1 for the patch.
          Hide
          Hari Mankude added a comment -

          Test failure is not related. Looks like same test passed previously.

          Show
          Hari Mankude added a comment - Test failure is not related. Looks like same test passed previously.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12514694/HDFS-2938.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1872//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1872//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514694/HDFS-2938.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1872//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1872//console This message is automatically generated.
          Hide
          Hari Mankude added a comment -

          attaching patch that takes care of nits

          Show
          Hari Mankude added a comment - attaching patch that takes care of nits
          Hari Mankude made changes -
          Attachment HDFS-2938.patch [ 12514694 ]
          Hide
          Aaron T. Myers added a comment -

          Tiny nit: please put spaces around "=" and "<".

          Otherwise looks good to me.

          Show
          Aaron T. Myers added a comment - Tiny nit: please put spaces around "=" and "<". Otherwise looks good to me.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12514671/HDFS-2938.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1871//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1871//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514671/HDFS-2938.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1871//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1871//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          +1, looks good. One nit: missing a '.' in the javadoc at the end of the first sentence.

          Show
          Todd Lipcon added a comment - +1, looks good. One nit: missing a '.' in the javadoc at the end of the first sentence.
          Hide
          Harsh J added a comment -

          (Reasoning here if you missed it: http://search-hadoop.com/m/NARQHPUsiv1)

          Show
          Harsh J added a comment - (Reasoning here if you missed it: http://search-hadoop.com/m/NARQHPUsiv1 )
          Harsh J made changes -
          Fix Version/s 0.24.0 [ 12317653 ]
          Fix Version/s 0.23.1 [ 12318885 ]
          Affects Version/s 0.24.0 [ 12317653 ]
          Affects Version/s 0.23.1 [ 12318885 ]
          Target Version/s 0.23.2 [ 12319852 ] 0.24.0, 0.23.2 [ 12317653, 12319852 ]
          Hide
          Harsh J added a comment -

          As mentioned in the forms, please use Fix Versions only to indicate a version where a fix has already been committed to, and target versions for where you intend it to get committed to.

          Show
          Harsh J added a comment - As mentioned in the forms, please use Fix Versions only to indicate a version where a fix has already been committed to, and target versions for where you intend it to get committed to.
          Hari Mankude made changes -
          Attachment HDFS-2938.patch [ 12514671 ]
          Hari Mankude made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Fix Version/s 0.23.1 [ 12318885 ]
          Hari Mankude made changes -
          Assignee Suresh Srinivas [ sureshms ] Hari Mankude [ harip ]
          Suresh Srinivas made changes -
          Link This issue is related to HDFS-173 [ HDFS-173 ]
          Suresh Srinivas made changes -
          Field Original Value New Value
          Target Version/s 0.23.2 [ 12319852 ]
          Suresh Srinivas created issue -

            People

            • Assignee:
              Hari Mankude
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development