Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2931

Switch the DataNode's BlockVolumeChoosingPolicy to be a private-audience interface

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.2
    • Component/s: datanode
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      From Nicholas, at the tail of HDFS-1120:

      However, if we annotate it as public, all the classes associated with them should also be annotated as public. Also, whenever we change the interface or any of the associated classes, it is an incompatible change.

      In our case, BlockVolumeChoosingPolicy uses FSVolumeInterface, which is a part of FSDatasetInterface. In FSDatasetInterface, there are many classes should not be exposed. One way to solve it is to make FSVolumeInterface independent of FSDatasetInterface. However, FSVolumeInterface is not yet a well-designed interface for the public.

      For these reasons, it is justified to annotate it as private, the same as BlockPlacementPolicy.

      We should switch BlockVolumeChoosingPolicy to for a private audience.

        Activity

        Harsh J created issue -
        Harsh J made changes -
        Field Original Value New Value
        Attachment HDFS-2391.patch [ 12514069 ]
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.23.2, 0.24.0 [ 12319852, 12317653 ] 0.24.0, 0.23.2 [ 12317653, 12319852 ]
        Harsh J made changes -
        Attachment HDFS-2391.patch [ 12514069 ]
        Harsh J made changes -
        Attachment HDFS-2931.patch [ 12514070 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514070/HDFS-2931.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1860//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1860//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514070/HDFS-2931.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1860//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1860//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514069/HDFS-2391.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1859//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1859//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514069/HDFS-2391.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1859//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1859//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good. Thanks a lot, Harsh!

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Thanks a lot, Harsh!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Harsh!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Harsh!
        Tsz Wo Nicholas Sze made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 0.23.2, 0.24.0 [ 12319852, 12317653 ] 0.24.0, 0.23.2 [ 12317653, 12319852 ]
        Fix Version/s 0.24.0 [ 12317653 ]
        Fix Version/s 0.23.2 [ 12319852 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #524 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/524/)
        svn merge -c 1242891 from trunk for HDFS-2931.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #524 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/524/ ) svn merge -c 1242891 from trunk for HDFS-2931 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1710 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1710/)
        HDFS-2931. Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1710 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1710/ ) HDFS-2931 . Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #535 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/535/)
        svn merge -c 1242891 from trunk for HDFS-2931.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #535 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/535/ ) svn merge -c 1242891 from trunk for HDFS-2931 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1721 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1721/)
        HDFS-2931. Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1721 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1721/ ) HDFS-2931 . Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1785/)
        HDFS-2931. Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1785/ ) HDFS-2931 . Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #539 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/539/)
        svn merge -c 1242891 from trunk for HDFS-2931.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #539 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/539/ ) svn merge -c 1242891 from trunk for HDFS-2931 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #188 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/188/)
        svn merge -c 1242891 from trunk for HDFS-2931.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #188 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/188/ ) svn merge -c 1242891 from trunk for HDFS-2931 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #953 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/953/)
        HDFS-2931. Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #953 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/953/ ) HDFS-2931 . Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #166 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/166/)
        svn merge -c 1242891 from trunk for HDFS-2931.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #166 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/166/ ) svn merge -c 1242891 from trunk for HDFS-2931 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #986 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/986/)
        HDFS-2931. Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #986 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/986/ ) HDFS-2931 . Switch DataNode's BlockVolumeChoosingPolicy to private-audience. Contributed by harsh szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242891 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
        Arun C Murthy made changes -
        Fix Version/s 0.24.0 [ 12317653 ]
        Harsh J made changes -
        Target Version/s 0.24.0, 0.23.2 [ 12317653, 12319852 ]

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development