[HDFS-2877] If locking of a storage dir fails, it will remove the other NN's lock file on exit

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.0, 1.0.0, 2.0.0-alpha
• Fix Version/s: 1.1.0, 0.22.1
• Component/s: namenode
• Target Version/s: 0.23.1, 1.1.0, 0.22.1
• Hadoop Flags: Reviewed
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 02/Feb/12 00:20
• Updated: 10/Mar/15 04:36
• Resolved: 02/Feb/12 22:13

Description

In Storage.tryLock(), we call lockF.deleteOnExit() regardless of whether we successfully lock the directory. So, if another NN has the directory locked, then we'll fail to lock it the first time we start another NN. But our failed start attempt will still remove the other NN's lockfile, and a second attempt will erroneously start.

Issue Links

• is duplicated by: HDFS-2632 existing in_use.lock file is removed after failing to lock this file
• is related to: HDFS-2865 Standby namenode gets a "cannot lock storage" exception during startup
• is related to: HDFS-1690 Name Node should not process format command while it is running.