Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: namenode
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      fs.checkpoint.dir values need to be trimmed like dfs.name.dir and dfs.data.dir values so eg the following works. This currently results in the directory "HADOOP_HOME/?/home/eli/hadoop/dirs3/dfs/chkpoint1" being created.

        <property>
          <name>fs.checkpoint.dir</name>
           <value>
      /home/eli/hadoop/dirs3/dfs/chkpoint1,
      /home/eli/hadoop/dirs3/dfs/chkpoint2
           </value>
        </property>
      
      1. HDFS-2799.patch
        3 kB
        amith
      2. HDFS-2799.patch
        4 kB
        amith

        Activity

        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12521981/HDFS-2799.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2230//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2230//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521981/HDFS-2799.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2230//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2230//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        I think a simple fix of porting the Config.get… method to the right one would be much better. Testing it too should be simple enough (run with a config and see what dir it created?)

        Show
        Harsh J added a comment - I think a simple fix of porting the Config.get… method to the right one would be much better. Testing it too should be simple enough (run with a config and see what dir it created?)
        Hide
        amith added a comment -

        Hi Harsh,

        I have given a patch as u expected.
        I have moved the getCheckPointDirs to DFSUtil so this can be used by others in case required

        With this movement it is much easy to write a new test also

        Show
        amith added a comment - Hi Harsh, I have given a patch as u expected. I have moved the getCheckPointDirs to DFSUtil so this can be used by others in case required With this movement it is much easy to write a new test also
        Hide
        amith added a comment -

        @Eli can u review the patch once

        Show
        amith added a comment - @Eli can u review the patch once
        Hide
        Eli Collins added a comment -
        • Both getCheckpointEditsDirs and getCheckpointDirs need to be fixed (these are the last two uses of getStringCollection in hdfs)
        • Agree w Harsh that it should use getTrimmedStringCollection directly to be consistent with the rest of the code
        • Good test for this would be to have a test that adds space or new line to each config value that has a csv list of directories and tries to start a mini cluster (for an example of setting new values for directories checkout TestNameEditsConfigs)
        Show
        Eli Collins added a comment - Both getCheckpointEditsDirs and getCheckpointDirs need to be fixed (these are the last two uses of getStringCollection in hdfs) Agree w Harsh that it should use getTrimmedStringCollection directly to be consistent with the rest of the code Good test for this would be to have a test that adds space or new line to each config value that has a csv list of directories and tries to start a mini cluster (for an example of setting new values for directories checkout TestNameEditsConfigs)
        Hide
        amith added a comment -

        I agree with both of u,

        I will provide a patch as expected soon

        Show
        amith added a comment - I agree with both of u, I will provide a patch as expected soon
        Hide
        amith added a comment -

        Hi Harsh/Eli

        I have provided a patch can u please review the same

        Show
        amith added a comment - Hi Harsh/Eli I have provided a patch can u please review the same
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522584/HDFS-2799.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2271//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2271//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522584/HDFS-2799.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2271//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2271//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1 looks good. Two small nits: the first line of the test javadoc was indented incorrectly and the test name had a spelling mistake ("trimm"), I'll fix those and commit.

        Show
        Eli Collins added a comment - +1 looks good. Two small nits: the first line of the test javadoc was indented incorrectly and the test name had a spelling mistake ("trimm"), I'll fix those and commit.
        Hide
        Eli Collins added a comment -

        I've committed this and merged to branch-2. Thanks Amith!

        Show
        Eli Collins added a comment - I've committed this and merged to branch-2. Thanks Amith!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2071 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2071/)
        HDFS-2799. Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2071 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2071/ ) HDFS-2799 . Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2144 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2144/)
        HDFS-2799. Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2144 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2144/ ) HDFS-2799 . Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2085/)
        HDFS-2799. Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963)

        Result = ABORTED
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2085/ ) HDFS-2799 . Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1014/)
        HDFS-2799. Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1014/ ) HDFS-2799 . Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1049 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1049/)
        HDFS-2799. Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1049 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1049/ ) HDFS-2799 . Trim fs.checkpoint.dir values. Contributed by Amith D K (Revision 1325963) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325963 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        amith added a comment -

        Thanks eli

        Show
        amith added a comment - Thanks eli

          People

          • Assignee:
            amith
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development