[HDFS-2773] HA: reading edit logs from an earlier version leaves blocks in under-construction state

• Type: Sub-task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: HA branch (HDFS-1623)
• Fix Version/s: HA branch (HDFS-1623)
• Component/s: ha, namenode
• Target Version/s: HA branch (HDFS-1623)
• Hadoop Flags: Reviewed
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 10/Jan/12 01:14
• Updated: 16/Jan/12 20:52
• Resolved: 11/Jan/12 06:08

Description

In HDFS-2602, the code for applying OP_ADD and OP_CLOSE was changed a bit, and the new code has the following problem: if an OP_CLOSE includes new blocks (ie not previously seen in an OP_ADD) then those blocks will remain in the "under construction" state rather than being marked "complete". This is because updateBlocks always creates BlockInfoUnderConstruction regardless of the opcode. This bug only affects the upgrade path, since in trunk we always persist blocks with OP_ADDs before we call OP_CLOSE.