Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2765

TestNameEditsConfigs is incorrectly swallowing IOE

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: test
    • Labels:
      None

      Description

      The final portion of this test case is swallowing an IOE and in so doing appearing to succeed, although it should not be succeeding as-written.

      1. HDFS-2765.patch
        15 kB
        Aaron T. Myers

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1049 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1049/)
        Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1049 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1049/ ) Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1014/)
        Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1014/ ) Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2087 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2087/)
        Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2087 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2087/ ) Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2073 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2073/)
        Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2073 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2073/ ) Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2146 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2146/)
        Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2146 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2146/ ) Move CHANGES.txt message for HDFS-2765 to be under 2.0.0 instead of trunk. (Revision 1326013) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326013 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Aaron T. Myers added a comment -

        I've back-ported this fix to branch-2.

        Show
        Aaron T. Myers added a comment - I've back-ported this fix to branch-2.
        Hide
        Aaron T. Myers added a comment -

        Reopening for back-port to branch-2.

        Show
        Aaron T. Myers added a comment - Reopening for back-port to branch-2.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #953 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/953/)
        HDFS-2765. TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #953 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/953/ ) HDFS-2765 . TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #920 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/920/)
        HDFS-2765. TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #920 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/920/ ) HDFS-2765 . TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1532 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1532/)
        HDFS-2765. TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1532 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1532/ ) HDFS-2765 . TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1512 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1512/)
        HDFS-2765. TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1512 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1512/ ) HDFS-2765 . TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1585 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1585/)
        HDFS-2765. TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1585 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1585/ ) HDFS-2765 . TestNameEditsConfigs is incorrectly swallowing IOE. Contributed by Aaron T. Myers atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1229028 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        Hide
        Aaron T. Myers added a comment -

        I've just committed this.

        Show
        Aaron T. Myers added a comment - I've just committed this.
        Hide
        Aaron T. Myers added a comment -

        I took a look at the javdoc, findbugs, and RAT warnings, and am confident that none of them are related to this patch. I'll be committing this shortly.

        Thanks a lot for the review, todd.

        Show
        Aaron T. Myers added a comment - I took a look at the javdoc, findbugs, and RAT warnings, and am confident that none of them are related to this patch. I'll be committing this shortly. Thanks a lot for the review, todd.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12509749/HDFS-2765.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 21 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509749/HDFS-2765.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 21 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1765//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Aaron T. Myers added a comment -

        Here's a patch which addresses the issue. I also took the liberty of cleaning up this whole class a little bit while I was in here.

        Show
        Aaron T. Myers added a comment - Here's a patch which addresses the issue. I also took the liberty of cleaning up this whole class a little bit while I was in here.

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development