Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2703

removedStorageDirs is not updated everywhere we remove a storage dir

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.0.2
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are a number of places (FSEditLog#open, purgeEditLog, and rollEditLog) where we remove a storage directory but don't add it to the removedStorageDirs list. This means a storage dir may have been removed but we don't see it in the log or Web UI. This doesn't affect trunk/23 since the code there is totally different.

      1. hdfs-2703.txt
        4 kB
        Eli Collins

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Tests and test-patch are clean. I've committed this.

          Thanks for the review Todd!

          Show
          Eli Collins added a comment - Tests and test-patch are clean. I've committed this. Thanks for the review Todd!
          Hide
          Todd Lipcon added a comment -

          +1

          Show
          Todd Lipcon added a comment - +1
          Hide
          Todd Lipcon added a comment -

          Looks good, but see the comment about a test plan in my comment on HDFS-2701

          Show
          Todd Lipcon added a comment - Looks good, but see the comment about a test plan in my comment on HDFS-2701
          Hide
          Eli Collins added a comment -

          This applies atop HDFS-2701.

          Show
          Eli Collins added a comment - This applies atop HDFS-2701 .
          Hide
          Eli Collins added a comment -

          Patch attached. Verified that when the 2NN triggers a roll and a storage directory fails a warning now shows up in the log and the Web UI lists this storage directory as failed.

          Show
          Eli Collins added a comment - Patch attached. Verified that when the 2NN triggers a roll and a storage directory fails a warning now shows up in the log and the Web UI lists this storage directory as failed.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development