Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2673

While Namenode processing the blocksBeingWrittenReport, it will log incorrect number blocks count

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.0.0
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:

      Description

      In NameNode#blocksBeingWrittenReport
      we have the following stateChangeLog

      stateChangeLog.info("*BLOCK* NameNode.blocksBeingWrittenReport: "
                 +"from "+nodeReg.getName()+" "+blocks.length +" blocks");
      

      here blocks is long array. Every consecutive 3 elements represents a block ( length, blockid, genstamp).

      So, here in log message, blocks.length should be blocks.length/3.

      1. HDFS-2673.patch
        0.6 kB
        Uma Maheswara Rao G

        Activity

        Uma Maheswara Rao G created issue -
        Hide
        Uma Maheswara Rao G added a comment -

        Updated patch for 1.1.0 version

        Show
        Uma Maheswara Rao G added a comment - Updated patch for 1.1.0 version
        Uma Maheswara Rao G made changes -
        Field Original Value New Value
        Attachment HDFS-2673.patch [ 12507227 ]
        Uma Maheswara Rao G made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12507227/HDFS-2673.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1712//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507227/HDFS-2673.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1712//console This message is automatically generated.
        Hide
        Matt Foley added a comment -

        Agree. +1 for code review. Committed to 1.0.0 and branch-1.
        Thanks, Uma!

        Please check if similar fix is needed in 0.23 and trunk.

        Show
        Matt Foley added a comment - Agree. +1 for code review. Committed to 1.0.0 and branch-1. Thanks, Uma! Please check if similar fix is needed in 0.23 and trunk.
        Matt Foley made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Target Version/s 1.1.0 [ 12317959 ] 1.0.0 [ 12318243 ]
        Fix Version/s 1.0.0 [ 12318243 ]
        Resolution Fixed [ 1 ]
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks a lot, Matt for the reviews,
        In trunk, there wont be separate blockBeingWritten report. There is one place where we are serialining blocks as long array is blockReport. Here we already handled it.

         + "from " + nodeReg.getName() + " " + blist.getNumberOfBlocks()
        

        Thanks
        Uma

        Show
        Uma Maheswara Rao G added a comment - Thanks a lot, Matt for the reviews, In trunk, there wont be separate blockBeingWritten report. There is one place where we are serialining blocks as long array is blockReport. Here we already handled it. + "from " + nodeReg.getName() + " " + blist.getNumberOfBlocks() Thanks Uma
        Hide
        Matt Foley added a comment -

        Closed upon release of version 1.0.0.

        Show
        Matt Foley added a comment - Closed upon release of version 1.0.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development