Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2653

DFSClient should cache whether addrs are non-local when short-circuiting is enabled

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 1.0.0
    • Fix Version/s: 0.23.1, 1.1.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Something Todd mentioned to me off-line.. currently DFSClient doesn't cache the fact that non-local reads are non-local, so if short-circuiting is enabled every time we create a block reader we'll go through the isLocalAddress code path. We should cache the fact that an addr is non-local as well.

      1. hdfs-2653-1.patch
        2 kB
        Eli Collins
      2. hdfs-2653-2.patch
        2 kB
        Eli Collins
      3. hdfs-2653-2.patch
        2 kB
        Eli Collins
      4. hdfs-2653-b1-1.patch
        1 kB
        Eli Collins
      5. hdfs-2653-b1-2.patch
        1 kB
        Eli Collins

        Activity

        Eli Collins created issue -
        Eli Collins made changes -
        Field Original Value New Value
        Attachment hdfs-2653-1.patch [ 12506823 ]
        Eli Collins made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
        Eli Collins made changes -
        Attachment hdfs-2653-b1-1.patch [ 12506827 ]
        Eli Collins made changes -
        Attachment hdfs-2653-2.patch [ 12506830 ]
        Eli Collins made changes -
        Attachment hdfs-2653-b1-2.patch [ 12506833 ]
        Eli Collins made changes -
        Attachment hdfs-2653-2.patch [ 12506873 ]
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
        Eli Collins made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ]
        Fix Version/s 0.23.1 [ 12318885 ]
        Fix Version/s 1.1.0 [ 12317959 ]
        Resolution Fixed [ 1 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development