Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2637

The rpc timeout for block recovery is too low

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The RPC timeout for block recovery does not take into account that it issues multiple RPCs itself. This can cause recovery to fail if the network is congested or DNs are busy.

        Issue Links

          Activity

          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.
          Matt Foley made changes -
          Fix Version/s 1.1.0 [ 12317959 ]
          Hide
          Matt Foley added a comment -

          make FixedVersion consistent with commits.

          Show
          Matt Foley added a comment - make FixedVersion consistent with commits.
          Eli Collins made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Eli Collins added a comment -

          Thanks Todd. I've committed this.

          Show
          Eli Collins added a comment - Thanks Todd. I've committed this.
          Eli Collins made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Uma Maheswara Rao G made changes -
          Link This issue duplicates HDFS-2378 [ HDFS-2378 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Ok Todd, i will take a look on trunk code once and update if it really applies.
          Why i pointed for trunk is because HDFS-2378 filed against to 0.23.0 and 1.1.0.

          Show
          Uma Maheswara Rao G added a comment - Ok Todd, i will take a look on trunk code once and update if it really applies. Why i pointed for trunk is because HDFS-2378 filed against to 0.23.0 and 1.1.0.
          Hide
          Todd Lipcon added a comment -

          doh, yea, this is dup of HDFS-2378. Somehow when Eli and I were discussing it this morning I forgot that I'd already filed a JIRA for it. Since we already have the patch here, we can just commit this one and mark the other as dup, I guess?

          In trunk the block recovery algorithm is quite different so I don't think it applies – the block recovery is triggered as part of the pipeline setup, rather than an RPC. But maybe we have a similar type of bug in trunk with timeouts in the pipeline setup process? Mind taking a look, Uma?

          Show
          Todd Lipcon added a comment - doh, yea, this is dup of HDFS-2378 . Somehow when Eli and I were discussing it this morning I forgot that I'd already filed a JIRA for it. Since we already have the patch here, we can just commit this one and mark the other as dup, I guess? In trunk the block recovery algorithm is quite different so I don't think it applies – the block recovery is triggered as part of the pipeline setup, rather than an RPC. But maybe we have a similar type of bug in trunk with timeouts in the pipeline setup process? Mind taking a look, Uma?
          Hide
          Uma Maheswara Rao G added a comment -

          This may be applicable for trunk as well right?
          I think this issue is same as HDFS-2378. Can it be duplicated?

          Show
          Uma Maheswara Rao G added a comment - This may be applicable for trunk as well right? I think this issue is same as HDFS-2378 . Can it be duplicated?
          Hide
          Todd Lipcon added a comment -

          +1

          Show
          Todd Lipcon added a comment - +1
          Hide
          Eli Collins added a comment -

          Unit tests are running, earlier run was clean. test-patch results follow. 4 findbugs warnings are HADOOP-7847, not this patch.

               [exec] 
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no tests are needed for this patch.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
               [exec] 
          
          Show
          Eli Collins added a comment - Unit tests are running, earlier run was clean. test-patch results follow. 4 findbugs warnings are HADOOP-7847 , not this patch. [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. [exec]
          Eli Collins made changes -
          Field Original Value New Value
          Attachment hdfs-2637-b1-1.patch [ 12506339 ]
          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Eli Collins created issue -

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development