Details
-
Type:
Sub-task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: HA branch (HDFS-1623)
-
Fix Version/s: HA branch (HDFS-1623)
-
Labels:None
-
Hadoop Flags:Reviewed
Description
DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Doesn't HeartbeatResponseWritable need to implement Writable? Otherwise looks good.
Small update.
Still seems like HeartbeatResponseWritable isn't implementing Writable... am I missing something?
I was missing some thing. Thanks for the catch. I am yet to run some tests to see if this really works. The ObjectWritable magic scares me 
Updated patch. Tests were failing previously because transition to translator for DatanodeProtocol is not complete and HeartbeatResponse needs to be Writable.
Empty constructors added to new writable. Thx Todd for catching it.
patch with missing files attached!
+1, looks good.
Committed it to HDFS-1623 branch.
Needed a slight addendum here for the mocking of DatanodeProtocol in TestBPOfferService. It was previously returning null which was treated as "no commands", but now that triggers an NPE in the tests. I'll commit this trivial fix in a few minutes.
Committed hdfs-2616-addendum.txt as r1209315.
running tests on this patch.