Details

    • Hadoop Flags:
      Reviewed

      Description

      DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira proposes changing it to to return HeartbeatResponse that has DatanodeCommand[]. This allows adding other information that can be returned by the namenode to the datanode, instead of having to only return DatanodeCommand[]. For relevant discussion see HDFS-1972.

      1. HDFS-2616.txt
        24 kB
        Suresh Srinivas
      2. HDFS-2616.txt
        19 kB
        Suresh Srinivas
      3. HDFS-2616.txt
        25 kB
        Suresh Srinivas
      4. HDFS-2616.txt
        24 kB
        Suresh Srinivas
      5. HDFS-2616.txt
        12 kB
        Suresh Srinivas
      6. HDFS-2616.txt
        11 kB
        Suresh Srinivas
      7. hdfs-2616-addendum.txt
        2 kB
        Todd Lipcon

        Activity

        Hide
        sureshms Suresh Srinivas added a comment -

        running tests on this patch.

        Show
        sureshms Suresh Srinivas added a comment - running tests on this patch.
        Hide
        tlipcon Todd Lipcon added a comment -

        Doesn't HeartbeatResponseWritable need to implement Writable? Otherwise looks good.

        Show
        tlipcon Todd Lipcon added a comment - Doesn't HeartbeatResponseWritable need to implement Writable? Otherwise looks good.
        Hide
        sureshms Suresh Srinivas added a comment -

        Small update.

        Show
        sureshms Suresh Srinivas added a comment - Small update.
        Hide
        tlipcon Todd Lipcon added a comment -

        Still seems like HeartbeatResponseWritable isn't implementing Writable... am I missing something?

        Show
        tlipcon Todd Lipcon added a comment - Still seems like HeartbeatResponseWritable isn't implementing Writable... am I missing something?
        Hide
        sureshms Suresh Srinivas added a comment -

        I was missing some thing. Thanks for the catch. I am yet to run some tests to see if this really works. The ObjectWritable magic scares me

        Show
        sureshms Suresh Srinivas added a comment - I was missing some thing. Thanks for the catch. I am yet to run some tests to see if this really works. The ObjectWritable magic scares me
        Hide
        sureshms Suresh Srinivas added a comment -

        Updated patch. Tests were failing previously because transition to translator for DatanodeProtocol is not complete and HeartbeatResponse needs to be Writable.

        Show
        sureshms Suresh Srinivas added a comment - Updated patch. Tests were failing previously because transition to translator for DatanodeProtocol is not complete and HeartbeatResponse needs to be Writable.
        Hide
        sureshms Suresh Srinivas added a comment -

        Empty constructors added to new writable. Thx Todd for catching it.

        Show
        sureshms Suresh Srinivas added a comment - Empty constructors added to new writable. Thx Todd for catching it.
        Hide
        sureshms Suresh Srinivas added a comment -

        patch with missing files attached!

        Show
        sureshms Suresh Srinivas added a comment - patch with missing files attached!
        Hide
        tlipcon Todd Lipcon added a comment -

        +1, looks good.

        Show
        tlipcon Todd Lipcon added a comment - +1, looks good.
        Hide
        sureshms Suresh Srinivas added a comment -

        Committed it to HDFS-1623 branch.

        Show
        sureshms Suresh Srinivas added a comment - Committed it to HDFS-1623 branch.
        Hide
        tlipcon Todd Lipcon added a comment -

        Needed a slight addendum here for the mocking of DatanodeProtocol in TestBPOfferService. It was previously returning null which was treated as "no commands", but now that triggers an NPE in the tests. I'll commit this trivial fix in a few minutes.

        Show
        tlipcon Todd Lipcon added a comment - Needed a slight addendum here for the mocking of DatanodeProtocol in TestBPOfferService. It was previously returning null which was treated as "no commands", but now that triggers an NPE in the tests. I'll commit this trivial fix in a few minutes.
        Hide
        tlipcon Todd Lipcon added a comment -

        Committed hdfs-2616-addendum.txt as r1209315.

        Show
        tlipcon Todd Lipcon added a comment - Committed hdfs-2616-addendum.txt as r1209315.

          People

          • Assignee:
            sureshms Suresh Srinivas
            Reporter:
            sureshms Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development