Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. protoClientNN3.patch
      1.93 MB
      Sanjay Radia
    2. protoClientNN2.patch
      1.93 MB
      Sanjay Radia
    3. protoClientNN1.patch
      1.88 MB
      Sanjay Radia
    4. protoClientNN1.patch
      1.88 MB
      Sanjay Radia
    5. ClientNamenodeProtocol.proto
      11 kB
      Sanjay Radia
    6. ClientNamenodeProtocol.proto
      12 kB
      Sanjay Radia

      Activity

      Hide
      Sanjay Radia added a comment -

      Attached is the proto for ClientNamenodeProtocol.

      Show
      Sanjay Radia added a comment - Attached is the proto for ClientNamenodeProtocol.
      Hide
      Todd Lipcon added a comment -
      • How do exceptions factor in with the protobuf protocols? (sorry if this is addressed elsewhere and I missed it?)
      • the attached .proto file has lots of hard tabs causing strange formatting
      Show
      Todd Lipcon added a comment - How do exceptions factor in with the protobuf protocols? (sorry if this is addressed elsewhere and I missed it?) the attached .proto file has lots of hard tabs causing strange formatting
      Hide
      Sanjay Radia added a comment -

      Updated client NN Protocol in PB. (Tabs converted spaces).

      Exceptions: as noted in Javadoc the exceptions and spec are as in the corresponding java class.

      The PtotoBufRpcEngine describes the wrapping of impl exceptions and also what happens to RPC layer exceptions.

      Show
      Sanjay Radia added a comment - Updated client NN Protocol in PB. (Tabs converted spaces). Exceptions: as noted in Javadoc the exceptions and spec are as in the corresponding java class. The PtotoBufRpcEngine describes the wrapping of impl exceptions and also what happens to RPC layer exceptions.
      Hide
      Sanjay Radia added a comment -

      Just the proto and for clientNN

      Show
      Sanjay Radia added a comment - Just the proto and for clientNN
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12506494/protoClientNN1.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1655//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1655//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506494/protoClientNN1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1655//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1655//console This message is automatically generated.
      Hide
      Sanjay Radia added a comment -

      Updated protfile to name request and responses a XXRequestProto and XXXResponseProto

      Show
      Sanjay Radia added a comment - Updated protfile to name request and responses a XXRequestProto and XXXResponseProto
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12506502/protoClientNN2.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hdfs.security.TestDelegationToken
      org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
      org.apache.hadoop.hdfs.TestFileAppend4

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1656//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1656//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506502/protoClientNN2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.security.TestDelegationToken org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer org.apache.hadoop.hdfs.TestFileAppend4 +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1656//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1656//console This message is automatically generated.
      Hide
      Suresh Srinivas added a comment -

      Looks good. Some comments:

      1. It would be good to use two space indentation
      2. There are several places the line exceeds 80 columns
      Show
      Suresh Srinivas added a comment - Looks good. Some comments: It would be good to use two space indentation There are several places the line exceeds 80 columns
      Hide
      Suresh Srinivas added a comment -

      BTW +1 for the patch with the above changes.

      Show
      Suresh Srinivas added a comment - BTW +1 for the patch with the above changes.
      Hide
      Sanjay Radia added a comment -

      Addressed Suresh's feedback

      Show
      Sanjay Radia added a comment - Addressed Suresh's feedback
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #1403 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1403/)
      HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay)

      sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1403 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1403/ ) HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #1379 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1379/)
      HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay)

      sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1379 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1379/ ) HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #1453 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1453/)
      HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay)

      sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1453 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1453/ ) HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12506579/protoClientNN3.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
      org.apache.hadoop.hdfs.security.TestDelegationToken
      org.apache.hadoop.hdfs.TestLeaseRenewer

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1661//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1661//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506579/protoClientNN3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer org.apache.hadoop.hdfs.security.TestDelegationToken org.apache.hadoop.hdfs.TestLeaseRenewer +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1661//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1661//console This message is automatically generated.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #921 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/921/)
      HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay)

      sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #921 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/921/ ) HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #888 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/888/)
      HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay)

      sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #888 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/888/ ) HDFS-2597 ClientNameNodeProtocol in Protocol Buffers (sanjay) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1211769 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/ClientNamenodeProtocol.proto
      Hide
      Tsz Wo Nicholas Sze added a comment -

      I have merged this to 0.23.

      Show
      Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.

        People

        • Assignee:
          Sanjay Radia
          Reporter:
          Sanjay Radia
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development