Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This jira adds a protobuf service definition for NamenodeProtocol.

      1. HDFS-2518.txt
        7 kB
        Suresh Srinivas
      2. HDFS-2518.txt
        7 kB
        Suresh Srinivas
      3. HDFS-2518.txt
        397 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have merged this to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #905 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/905/)
          HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #905 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/905/ ) HDFS-2518 . Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #871 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/871/)
          HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #871 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/871/ ) HDFS-2518 . Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1330 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1330/)
          HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1330 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1330/ ) HDFS-2518 . Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1307 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1307/)
          HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1307 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1307/ ) HDFS-2518 . Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1380 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1380/)
          HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1380 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1380/ ) HDFS-2518 . Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto
          Hide
          Suresh Srinivas added a comment -

          Owen, HDFS-2578 is created to address your comment.

          Show
          Suresh Srinivas added a comment - Owen, HDFS-2578 is created to address your comment.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch.

          Show
          Suresh Srinivas added a comment - I committed the patch.
          Hide
          Suresh Srinivas added a comment -

          Test failure TestViewFsHdfs is unrelated to this patch. Also this patch introduces protobuf definitions. It will be tested when protobuf mechanism is used for RPCs, using the existing tests.

          Show
          Suresh Srinivas added a comment - Test failure TestViewFsHdfs is unrelated to this patch. Also this patch introduces protobuf definitions. It will be tested when protobuf mechanism is used for RPCs, using the existing tests.
          Hide
          Suresh Srinivas added a comment -

          Owen, we have done this for several other patches. I will create another jira to get rid of them.

          Show
          Suresh Srinivas added a comment - Owen, we have done this for several other patches. I will create another jira to get rid of them.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501858/HDFS-2518.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.fs.viewfs.TestViewFsHdfs

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1594//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1594//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501858/HDFS-2518.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsHdfs +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1594//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1594//console This message is automatically generated.
          Hide
          Owen O'Malley added a comment -

          Please don't include the generated code in subversion. We already require protoc in order to compile Hadoop, so there isn't any need to avoid it here.

          Show
          Owen O'Malley added a comment - Please don't include the generated code in subversion. We already require protoc in order to compile Hadoop, so there isn't any need to avoid it here.
          Hide
          Jitendra Nath Pandey added a comment -

          +1

          Show
          Jitendra Nath Pandey added a comment - +1
          Hide
          Suresh Srinivas added a comment -

          Patch with generated artifacts and service name changed to NamenodeProtocolService.

          Show
          Suresh Srinivas added a comment - Patch with generated artifacts and service name changed to NamenodeProtocolService.
          Hide
          Suresh Srinivas added a comment -

          Change DatanodeIDProto to DatanodeInfoProto as pointed by Jitendra. Thanks for catching it.

          Show
          Suresh Srinivas added a comment - Change DatanodeIDProto to DatanodeInfoProto as pointed by Jitendra. Thanks for catching it.
          Hide
          Suresh Srinivas added a comment -

          GetBlockKeysRequestProto, GetTransactionIdRequestProto, EndCheckpointResponseProto are empty, can we replace them with a single empty proto?

          Instead of StartCheckpointResponseProto, can we just use NamenodeCommandProto which is already defined? That applies to many response protos e.g. RegisterResponseProto could be replaced with NamenodeRegistrationProto.

          The reason is, the request and response could in the future change to include additional optional fields.

          Show
          Suresh Srinivas added a comment - GetBlockKeysRequestProto, GetTransactionIdRequestProto, EndCheckpointResponseProto are empty, can we replace them with a single empty proto? Instead of StartCheckpointResponseProto, can we just use NamenodeCommandProto which is already defined? That applies to many response protos e.g. RegisterResponseProto could be replaced with NamenodeRegistrationProto. The reason is, the request and response could in the future change to include additional optional fields.
          Hide
          Jitendra Nath Pandey added a comment -
          1. GetBlocksRequestProto should have DatanodeInfoProto.
          2. GetBlockKeysRequestProto, GetTransactionIdRequestProto, EndCheckpointResponseProto are empty, can we replace them with a single empty proto?
          3. Instead of StartCheckpointResponseProto, can we just use NamenodeCommandProto which is already defined? That applies to many response protos e.g. RegisterResponseProto could be replaced with NamenodeRegistrationProto.
          Show
          Jitendra Nath Pandey added a comment - GetBlocksRequestProto should have DatanodeInfoProto. GetBlockKeysRequestProto, GetTransactionIdRequestProto, EndCheckpointResponseProto are empty, can we replace them with a single empty proto? Instead of StartCheckpointResponseProto, can we just use NamenodeCommandProto which is already defined? That applies to many response protos e.g. RegisterResponseProto could be replaced with NamenodeRegistrationProto.

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development