Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2485

Improve code layout and constants in UnderReplicatedBlocks

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 2.0.0-alpha
    • Fix Version/s: 0.23.0
    • Component/s: datanode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Before starting HDFS-2472 I want to clean up the code in UnderReplicatedBlocks slightly

      1. use constants for all the string levels
      2. change the getUnderReplicatedBlockCount() method so that it works even if the corrupted block list is not the last queue
      3. improve the javadocs
      4. add some more curly braces and spaces to follow the style guidelines better

      This is a trivial change as behaviour will not change at all. If committed it will go into trunk and 0.23 so that patches between the two versions are easy to apply

        Issue Links

          Activity

          Allen Wittenauer made changes -
          Fix Version/s 2.0.0-alpha [ 12320353 ]
          Allen Wittenauer made changes -
          Affects Version/s 2.0.0-alpha [ 12320353 ]
          Affects Version/s 0.24.0 [ 12317653 ]
          Fix Version/s 2.0.0-alpha [ 12320353 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-2472 [ HDFS-2472 ]
          Gavin made changes -
          Link This issue blocks HDFS-2472 [ HDFS-2472 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Steve Loughran made changes -
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317653, 12315571 ] 0.23.0, 0.24.0 [ 12315571, 12317653 ]
          Fix Version/s 0.23.0 [ 12315571 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317653, 12315571 ] 0.23.0, 0.24.0 [ 12315571, 12317653 ]
          Steve Loughran made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317653, 12315571 ] 0.23.0, 0.24.0 [ 12315571, 12317653 ]
          Steve Loughran made changes -
          Attachment HDFS-2485-improve-underreplicated.patch [ 12500325 ]
          Steve Loughran made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Steve Loughran made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317653, 12315571 ] 0.23.0, 0.24.0 [ 12315571, 12317653 ]
          Steve Loughran made changes -
          Link This issue blocks HDFS-2472 [ HDFS-2472 ]
          Steve Loughran made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Target Version/s 0.24.0, 0.23.0 [ 12317653, 12315571 ] 0.23.0, 0.24.0 [ 12315571, 12317653 ]
          Steve Loughran made changes -
          Attachment HDFS-2485-improve-underreplicated.patch [ 12500201 ]
          Steve Loughran made changes -
          Remaining Estimate 0.5h [ 1800 ] 0h [ 0 ]
          Time Spent 1h [ 3600 ]
          Worklog Id 12334 [ 12334 ]
          Steve Loughran made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Steve Loughran created issue -

            People

            • Assignee:
              Steve Loughran
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.5h Original Estimate - 0.5h
                0.5h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h

                  Development