Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2485

Improve code layout and constants in UnderReplicatedBlocks

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.0, 0.24.0
    • Component/s: datanode
    • Labels:
      None

      Description

      Before starting HDFS-2472 I want to clean up the code in UnderReplicatedBlocks slightly

      1. use constants for all the string levels
      2. change the getUnderReplicatedBlockCount() method so that it works even if the corrupted block list is not the last queue
      3. improve the javadocs
      4. add some more curly braces and spaces to follow the style guidelines better

      This is a trivial change as behaviour will not change at all. If committed it will go into trunk and 0.23 so that patches between the two versions are easy to apply

        Issue Links

          Activity

          Steve Loughran logged work - 21/Oct/11 17:27
          • Time Spent:
            1h
             
            code plus tests

            People

            • Assignee:
              Steve Loughran
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.5h Original Estimate - 0.5h
                0.5h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h

                  Development