[HDFS-2485] Improve code layout and constants in UnderReplicatedBlocks

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.23.0, 2.0.0-alpha
• Fix Version/s: 0.23.0
• Component/s: datanode
• Target Version/s: 0.23.0
• Hadoop Flags: Reviewed
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 21/Oct/11 13:59
• Updated: 16/Mar/15 18:07
• Resolved: 23/Oct/11 14:13

Description

Before starting HDFS-2472 I want to clean up the code in UnderReplicatedBlocks slightly

1. use constants for all the string levels
2. change the getUnderReplicatedBlockCount() method so that it works even if the corrupted block list is not the last queue
3. improve the javadocs
4. add some more curly braces and spaces to follow the style guidelines better

This is a trivial change as behaviour will not change at all. If committed it will go into trunk and 0.23 so that patches between the two versions are easy to apply

Issue Links

• is depended upon by: HDFS-2472 Extend UnderReplicatedBlocks queue to give blocks whose existing copies are all on a single rack priority over multi-rack blocks