Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2484

checkLease should throw FileNotFoundException when file does not exist

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0, 2.0.0-alpha
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When file is deleted during its creation FSNamesystem.checkLease(String src, String holder) throws LeaseExpiredException. It would be more informative if it thrown FileNotFoundException.

      1. HDFS-2484.00.patch
        3 kB
        Rakesh R
      2. HDFS-2484.01.patch
        5 kB
        Rakesh R
      3. HDFS-2484.02.patch
        4 kB
        Rakesh R

        Activity

        Hide
        shv Konstantin Shvachko added a comment -

        The exception is like this:

        2011-10-21 00:17:52,610 WARN org.apache.hadoop.fs.slive.CreateOp: Error with creating
        org.apache.hadoop.hdfs.server.namenode.LeaseExpiredException: No lease on /test/slive/slive/data/sl_dir_26/sl_file_5 File does not exist. Holder DFSClient_attempt_201110141824_0140_m_000164_0 does not have any open files.
        	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:1729)
        	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:1720)
        	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.completeFileInternal(FSNamesystem.java:1775)
        	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.completeFile(FSNamesystem.java:1758)
        	at org.apache.hadoop.hdfs.server.namenode.NameNode.completeInternal(NameNode.java:953)
        	at org.apache.hadoop.hdfs.server.namenode.NameNode.complete(NameNode.java:942)
        	at sun.reflect.GeneratedMethodAccessor20.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        	at java.lang.reflect.Method.invoke(Method.java:597)
        	at org.apache.hadoop.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:349)
        	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1482)
        	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1478)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at javax.security.auth.Subject.doAs(Subject.java:396)
        	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1153)
        	at org.apache.hadoop.ipc.Server$Handler.run(Server.java:1476)
        
        	at org.apache.hadoop.ipc.Client.call(Client.java:1028)
        	at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:198)
        	at $Proxy1.complete(Unknown Source)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        	at java.lang.reflect.Method.invoke(Method.java:597)
        	at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:84)
        	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:59)
        	at $Proxy1.complete(Unknown Source)
        	at org.apache.hadoop.hdfs.DFSOutputStream.completeFile(DFSOutputStream.java:1518)
        	at org.apache.hadoop.hdfs.DFSOutputStream.close(DFSOutputStream.java:1505)
        	at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:66)
        	at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:91)
        	at org.apache.hadoop.fs.slive.CreateOp.run(CreateOp.java:152)
        	at org.apache.hadoop.fs.slive.ObserveableOp.run(ObserveableOp.java:63)
        	at org.apache.hadoop.fs.slive.SliveMapper.runOperation(SliveMapper.java:136)
        	at org.apache.hadoop.fs.slive.SliveMapper.map(SliveMapper.java:179)
        	at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54)
        	at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:389)
        	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:322)
        	at org.apache.hadoop.mapred.Child$4.run(Child.java:223)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at javax.security.auth.Subject.doAs(Subject.java:396)
        	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1153)
        	at org.apache.hadoop.mapred.Child.main(Child.java:217)
        
        Show
        shv Konstantin Shvachko added a comment - The exception is like this: 2011-10-21 00:17:52,610 WARN org.apache.hadoop.fs.slive.CreateOp: Error with creating org.apache.hadoop.hdfs.server.namenode.LeaseExpiredException: No lease on /test/slive/slive/data/sl_dir_26/sl_file_5 File does not exist. Holder DFSClient_attempt_201110141824_0140_m_000164_0 does not have any open files. at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:1729) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:1720) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.completeFileInternal(FSNamesystem.java:1775) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.completeFile(FSNamesystem.java:1758) at org.apache.hadoop.hdfs.server.namenode.NameNode.completeInternal(NameNode.java:953) at org.apache.hadoop.hdfs.server.namenode.NameNode.complete(NameNode.java:942) at sun.reflect.GeneratedMethodAccessor20.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:349) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1482) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1478) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1153) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:1476) at org.apache.hadoop.ipc.Client.call(Client.java:1028) at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:198) at $Proxy1.complete(Unknown Source) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:84) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:59) at $Proxy1.complete(Unknown Source) at org.apache.hadoop.hdfs.DFSOutputStream.completeFile(DFSOutputStream.java:1518) at org.apache.hadoop.hdfs.DFSOutputStream.close(DFSOutputStream.java:1505) at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:66) at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:91) at org.apache.hadoop.fs.slive.CreateOp.run(CreateOp.java:152) at org.apache.hadoop.fs.slive.ObserveableOp.run(ObserveableOp.java:63) at org.apache.hadoop.fs.slive.SliveMapper.runOperation(SliveMapper.java:136) at org.apache.hadoop.fs.slive.SliveMapper.map(SliveMapper.java:179) at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54) at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:389) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:322) at org.apache.hadoop.mapred.Child$4.run(Child.java:223) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1153) at org.apache.hadoop.mapred.Child.main(Child.java:217)
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Konstantin Shvachko for reporting this. I could see FSNamesystem#checkLease has the following checks in branch-2 and trunk, does this validation satisfy your case?
        .
        FSNamesystem#checkLease logic

            if (inode == null) {
              Lease lease = leaseManager.getLease(holder);
              throw new LeaseExpiredException(
                  "No lease on " + ident + ": File does not exist. "
                  + (lease != null ? lease.toString()
                      : "Holder " + holder + " does not have any open files."));
            }
        
        Show
        rakeshr Rakesh R added a comment - Thanks Konstantin Shvachko for reporting this. I could see FSNamesystem#checkLease has the following checks in branch-2 and trunk, does this validation satisfy your case? . FSNamesystem#checkLease logic if (inode == null ) { Lease lease = leaseManager.getLease(holder); throw new LeaseExpiredException( "No lease on " + ident + ": File does not exist. " + (lease != null ? lease.toString() : "Holder " + holder + " does not have any open files." )); }
        Hide
        shv Konstantin Shvachko added a comment -

        Rakesh, if you look further down in checkLease() you see

        if (isFileDeleted(file)) {
          throw new FileNotFoundException(src);
        }
        

        I don't think this code path is ever triggered except probably when src is deleted while in a snapshot, which will be inconsistent with the regular case (deletion without a snapshot), as the latter will throw LeaseExpiredException.
        I am just saying FileNotFoundException is a more appropriate message for the client, since lease expiration is a consequence of file being deleted, so why not report just that.

        Show
        shv Konstantin Shvachko added a comment - Rakesh, if you look further down in checkLease() you see if (isFileDeleted(file)) { throw new FileNotFoundException(src); } I don't think this code path is ever triggered except probably when src is deleted while in a snapshot, which will be inconsistent with the regular case (deletion without a snapshot), as the latter will throw LeaseExpiredException. I am just saying FileNotFoundException is a more appropriate message for the client, since lease expiration is a consequence of file being deleted, so why not report just that.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Konstantin Shvachko for the details and that makes sense to me. I've attached patch with unit test, please have a look at it when you get a chance.

        if (isFileDeleted(file)) {
        I don't think this code path is ever triggered except probably when src is deleted while in a snapshot, which will be inconsistent with the regular case (deletion without a snapshot)

        Yes, I also feel the same. In my patch I haven't touch this validation part as I'm thinking this may be written to handle any special case which is unknown to me right now.

        Show
        rakeshr Rakesh R added a comment - Thanks Konstantin Shvachko for the details and that makes sense to me. I've attached patch with unit test, please have a look at it when you get a chance. if (isFileDeleted(file)) { I don't think this code path is ever triggered except probably when src is deleted while in a snapshot, which will be inconsistent with the regular case (deletion without a snapshot) Yes, I also feel the same. In my patch I haven't touch this validation part as I'm thinking this may be written to handle any special case which is unknown to me right now.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 40s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 11s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 166m 34s Tests failed in hadoop-hdfs.
            209m 24s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestFileCreation



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730023/HDFS-2484.00.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a319771
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10774/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10774/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10774/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10774/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 40s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 11s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 166m 34s Tests failed in hadoop-hdfs.     209m 24s   Reason Tests Failed unit tests hadoop.hdfs.TestFileCreation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730023/HDFS-2484.00.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a319771 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10774/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10774/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10774/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10774/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 55s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 47s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 14s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 23s Pre-build of native portion
        -1 hdfs tests 165m 18s Tests failed in hadoop-hdfs.
            208m 58s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730153/HDFS-2484.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / bb9ddef
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10778/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10778/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10778/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 55s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 14s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 23s Pre-build of native portion -1 hdfs tests 165m 18s Tests failed in hadoop-hdfs.     208m 58s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730153/HDFS-2484.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / bb9ddef hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10778/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10778/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10778/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        It seems the test case failure hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate is not related to my patch.

        Show
        rakeshr Rakesh R added a comment - It seems the test case failure hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate is not related to my patch.
        Hide
        shv Konstantin Shvachko added a comment -

        Hey Rakesh, your change looks good to me.

        • One improvement would be to move your test case under one of the existing tests rather than adding a new testLeaseWhenFileDoesntExists(). E.g., add the hflush() check at the end of testLease() after the directory is deleted. This will avoid re-spinning mini-cluster yet another time.
        Show
        shv Konstantin Shvachko added a comment - Hey Rakesh, your change looks good to me. One improvement would be to move your test case under one of the existing tests rather than adding a new testLeaseWhenFileDoesntExists() . E.g., add the hflush() check at the end of testLease() after the directory is deleted. This will avoid re-spinning mini-cluster yet another time.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Konstantin Shvachko for the comments. Attached another patch addressing the same. In unit tests, I've created another fileA to check the lease after its deletion.

        Show
        rakeshr Rakesh R added a comment - Thanks Konstantin Shvachko for the comments. Attached another patch addressing the same. In unit tests, I've created another fileA to check the lease after its deletion.
        Hide
        shv Konstantin Shvachko added a comment -

        +1 pending Jenkins.

        Show
        shv Konstantin Shvachko added a comment - +1 pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 26s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 14s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 15s Pre-build of native portion
        -1 hdfs tests 171m 5s Tests failed in hadoop-hdfs.
            213m 44s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFsck



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730561/HDFS-2484.02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ffce9a3
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10816/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10816/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10816/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 26s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 14s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 15s Pre-build of native portion -1 hdfs tests 171m 5s Tests failed in hadoop-hdfs.     213m 44s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFsck Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730561/HDFS-2484.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ffce9a3 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10816/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10816/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10816/console This message was automatically generated.
        Hide
        shv Konstantin Shvachko added a comment -

        What is "BB2015-05-TBR" any way - some serial number, of what?

        Show
        shv Konstantin Shvachko added a comment - What is "BB2015-05-TBR" any way - some serial number, of what?
        Hide
        shv Konstantin Shvachko added a comment -

        I just committed this. Thank you Rakesh.

        Show
        shv Konstantin Shvachko added a comment - I just committed this. Thank you Rakesh.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7751 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7751/)
        HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7751 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7751/ ) HDFS-2484 . checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/187/)
        HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/187/ ) HDFS-2484 . checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #920 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/920/)
        HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #920 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/920/ ) HDFS-2484 . checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -
        Show
        brahmareddy Brahma Reddy Battula added a comment - Konstantin Shvachko Please have look at following link.. https://wiki.apache.org/hadoop/2015MayBugBash
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2118/)
        HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2118/ ) HDFS-2484 . checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/177/)
        HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/177/ ) HDFS-2484 . checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/187/)
        HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/187/ ) HDFS-2484 . checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2136 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2136/)
        HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2136 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2136/ ) HDFS-2484 . checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            shv Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development