Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2467

HftpFileSystem uses incorrect compare for finding delegation tokens

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      When looking for hdfs delegation tokens, Hftp converts the service to a string and compares it to a text.

      1. h-2467.patch
        5 kB
        Owen O'Malley
      2. h-2467.patch
        4 kB
        Owen O'Malley

        Activity

        Hide
        Uma Maheswara Rao G added a comment -

        Looks duplicate of HDFS-2449 ( findbugs caught this)

        Show
        Uma Maheswara Rao G added a comment - Looks duplicate of HDFS-2449 ( findbugs caught this)
        Hide
        Owen O'Malley added a comment -

        This fixes the equality and adds a test.

        Show
        Owen O'Malley added a comment - This fixes the equality and adds a test.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499565/h-2467.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1386//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499565/h-2467.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1386//console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        Changes to .gitignore and TestHftpFileSystem.java look unintentional.

        The patch looks ok otherwise, +1.

        Show
        Jitendra Nath Pandey added a comment - Changes to .gitignore and TestHftpFileSystem.java look unintentional. The patch looks ok otherwise, +1.
        Hide
        Owen O'Malley added a comment -

        Removed the extra changes, although we should fix the .gitignore.

        Show
        Owen O'Malley added a comment - Removed the extra changes, although we should fix the .gitignore.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499577/h-2467.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.TestFileAppend2
        org.apache.hadoop.hdfs.TestBalancerBandwidth
        org.apache.hadoop.hdfs.TestRestartDFS
        org.apache.hadoop.hdfs.TestDistributedFileSystem
        org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
        org.apache.hadoop.hdfs.TestPipelines
        org.apache.hadoop.hdfs.TestBlocksScheduledCounter

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1387//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1387//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499577/h-2467.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestFileAppend2 org.apache.hadoop.hdfs.TestBalancerBandwidth org.apache.hadoop.hdfs.TestRestartDFS org.apache.hadoop.hdfs.TestDistributedFileSystem org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool org.apache.hadoop.hdfs.TestPipelines org.apache.hadoop.hdfs.TestBlocksScheduledCounter +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1387//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1387//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1180/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1180/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1101 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1101/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1101 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1101/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1120 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1120/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1120 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1120/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Owen O'Malley added a comment -

        I just committed this to trunk and 0.23.

        Show
        Owen O'Malley added a comment - I just committed this to trunk and 0.23.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #19 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/19/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #19 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/19/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #18 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/18/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #18 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/18/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #19 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/19/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #19 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/19/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #44 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/44/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #44 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/44/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #865 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/865/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #865 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/865/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #56 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/56/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #56 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/56/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185897 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #835 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/835/)
        HDFS-2467. HftpFileSystem uses incorrect compare for finding delegation
        tokens. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #835 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/835/ ) HDFS-2467 . HftpFileSystem uses incorrect compare for finding delegation tokens. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185842 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpDelegationToken.java

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development