Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: HA branch (HDFS-1623)
    • Fix Version/s: HA branch (HDFS-1623)
    • Component/s: ha, hdfs-client
    • Labels:
      None

      Description

      The ConfiguredFailoverProxyProvider will need to be amended to take advantage of the improvements to HA configuration introduced by HDFS-2231, once it's committed.

      1. HDFS-2418.patch
        9 kB
        Aaron T. Myers
      2. HDFS-2418.patch
        9 kB
        Aaron T. Myers

        Issue Links

          Activity

          Hide
          atm Aaron T. Myers added a comment -

          Here's a patch which addresses the issue. Note that this patch also fixes a bug in DFSUtil.getAddresses(...) wherein addresses would only be successfully retrieved if both HA and federation were enabled, but not if only one of these features was enabled.

          Show
          atm Aaron T. Myers added a comment - Here's a patch which addresses the issue. Note that this patch also fixes a bug in DFSUtil.getAddresses(...) wherein addresses would only be successfully retrieved if both HA and federation were enabled, but not if only one of these features was enabled.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501165/HDFS-2418.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1476//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501165/HDFS-2418.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1476//console This message is automatically generated.
          Hide
          eli Eli Collins added a comment -

          +1 lgtm

          Nit: I'd include "RPC" in the method name of getHaNameNodeAddresses

          Show
          eli Eli Collins added a comment - +1 lgtm Nit: I'd include "RPC" in the method name of getHaNameNodeAddresses
          Hide
          atm Aaron T. Myers added a comment -

          Thanks a lot for the quick review, Eli. In this patch I've changed the name to getHaNnRpcAddresses.

          I'll commit this to the HA branch momentarily.

          Show
          atm Aaron T. Myers added a comment - Thanks a lot for the quick review, Eli. In this patch I've changed the name to getHaNnRpcAddresses . I'll commit this to the HA branch momentarily.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501188/HDFS-2418.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1479//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501188/HDFS-2418.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1479//console This message is automatically generated.
          Hide
          atm Aaron T. Myers added a comment -

          I've just committed this.

          Show
          atm Aaron T. Myers added a comment - I've just committed this.

            People

            • Assignee:
              atm Aaron T. Myers
              Reporter:
              atm Aaron T. Myers
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development