Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2412

Add backwards-compatibility layer for FSConstants

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-1620 renamed FSConstants which we believed to be a private class. But currently the public APIs for safe-mode and datanode reports depend on constants in FSConstants. This is breaking HBase builds against 0.23. This JIRA is to provide a backward-compatibility route.

      1. hdfs-2412.txt
        3 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          With this patch, I'm able to get past the related errors compiling HBase against 23-SNAPSHOT

          Show
          Todd Lipcon added a comment - With this patch, I'm able to get past the related errors compiling HBase against 23-SNAPSHOT
          Hide
          Arun C Murthy added a comment -

          HDFS-1620 has caused a fair bit of strife - was it really worth it?

          Show
          Arun C Murthy added a comment - HDFS-1620 has caused a fair bit of strife - was it really worth it?
          Hide
          Arun C Murthy added a comment -

          The other option is to fix HBase if we really think HDFS-1620 is worth it - of course it'll imply a new HBase release.

          Show
          Arun C Murthy added a comment - The other option is to fix HBase if we really think HDFS-1620 is worth it - of course it'll imply a new HBase release.
          Hide
          Todd Lipcon added a comment -

          The problem is that HBase wants to build against both trunk and 20. We could introduce shims into HBase... but I think the deprecation approach is good to have anyway, in case others have similar reliances.

          I could also just be convinced to revert HDFS-1620.

          Show
          Todd Lipcon added a comment - The problem is that HBase wants to build against both trunk and 20. We could introduce shims into HBase... but I think the deprecation approach is good to have anyway, in case others have similar reliances. I could also just be convinced to revert HDFS-1620 .
          Hide
          Aaron T. Myers added a comment -

          I personally do think HDFS-1620 is worth it, and shouldn't be reverted. The patch Todd's provided is very straight-forward, and should fix things up for all down-stream projects that might be affected.

          My apologies for not realizing that these private constants are referenced in public APIs when I originally reviewed HDFS-1620. I should have checked for that.

          Show
          Aaron T. Myers added a comment - I personally do think HDFS-1620 is worth it, and shouldn't be reverted. The patch Todd's provided is very straight-forward, and should fix things up for all down-stream projects that might be affected. My apologies for not realizing that these private constants are referenced in public APIs when I originally reviewed HDFS-1620 . I should have checked for that.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12498114/hdfs-2412.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1351//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1351//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12498114/hdfs-2412.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1351//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1351//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          Can I get a +1 on this small patch in the meantime, so we can get the HBase-on-23 build back to compiling? Then we can consider whether we should just revert the whole thing.

          Show
          Todd Lipcon added a comment - Can I get a +1 on this small patch in the meantime, so we can get the HBase-on-23 build back to compiling? Then we can consider whether we should just revert the whole thing.
          Hide
          Aaron T. Myers added a comment -

          +1

          Show
          Aaron T. Myers added a comment - +1
          Hide
          Todd Lipcon added a comment -

          Resolved this in 23 and trunk. If we have more issues related to 1620, let's just revert both this and 1620.

          Show
          Todd Lipcon added a comment - Resolved this in 23 and trunk. If we have more issues related to 1620, let's just revert both this and 1620.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1117/)
          HDFS-2412. Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1117/ ) HDFS-2412 . Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1039 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1039/)
          HDFS-2412. Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1039 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1039/ ) HDFS-2412 . Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1059/)
          HDFS-2412. Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1059/ ) HDFS-2412 . Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #824 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/824/)
          HDFS-2412. Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #824 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/824/ ) HDFS-2412 . Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #33 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/33/)
          HDFS-2412. Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180203
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #33 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/33/ ) HDFS-2412 . Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180203 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #40 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/40/)
          HDFS-2412. Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180203
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #40 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/40/ ) HDFS-2412 . Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180203 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #854 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/854/)
          HDFS-2412. Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #854 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/854/ ) HDFS-2412 . Add backwards-compatibility layer for renamed FSConstants class. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180202 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/FSConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development