[HDFS-2390] dfsadmin -setBalancerBandwidth doesnot validate -ve value

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.1
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: balancer & mover
• Hadoop Flags: Reviewed
• Assignee: Gautam Gopalakrishnan
• Reporter: Rajit Saha
• Created: 30/Sep/11 18:23
• Updated: 30/Aug/16 01:42
• Resolved: 27/Aug/15 10:54

Description

$ hadoop dfsadmin -setBalancerBandwidth -10000

does not throw any message that it is invalid although in DN log we are not getting
"DNA_BALANCERBANDWIDTHUPDATE".

I think it should throw some message that -ve numbers are not valid , as it does
for decimal numbers or non-numbers like -

$ hadoop dfsadmin -setBalancerBandwidth 12.34
NumberFormatException: For input string: "12.34"
Usage: java DFSAdmin [-setBalancerBandwidth <bandwidth in bytes per second>]