[HDFS-2330] In NNStorage.java, IOExceptions of stream closures can mask root exceptions.

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.2-alpha
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Uma Maheswara Rao G
• Reporter: Uma Maheswara Rao G
• Created: 14/Sep/11 01:48
• Updated: 10/Mar/15 04:36
• Resolved: 18/Sep/11 08:31

Description

In NNStorage.java:
There are many stream closures in finally block.
There is a chance that they can mask the root exceptions.

So, better to follow the pattern like below:

  try{
     ............
     ............
     stream.close();
     stream =null;
   }
   finally{
     IOUtils.cleanup(LOG, stream);
   }