Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2312

FSNamesystem header comment says it's for the DN

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      One of the less accurate class comments I've ever seen:

       * FSNamesystem does the actual bookkeeping work for the
       * DataNode.
      
      1. HDFS-2312.r1.diff
        0.7 kB
        Harsh J
      2. HDFS-2312.r2.diff
        2 kB
        Harsh J

        Activity

        Hide
        qwertymaniac Harsh J added a comment -

        Trivial docfix patch.

        Show
        qwertymaniac Harsh J added a comment - Trivial docfix patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12493102/HDFS-2312.r1.diff
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        org.apache.hadoop.hdfs.TestDfsOverAvroRpc
        org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
        org.apache.hadoop.hdfs.server.datanode.TestReplicasMap

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493102/HDFS-2312.r1.diff against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//console This message is automatically generated.
        Hide
        atm Aaron T. Myers added a comment -

        This patch looks fine to me, Harsh. Perhaps you could even expand a little bit in the comment on what bookkeeping is done by FSNamesystem vs. FSDirectory? You can find some good info about the differences in this comment.

        Show
        atm Aaron T. Myers added a comment - This patch looks fine to me, Harsh. Perhaps you could even expand a little bit in the comment on what bookkeeping is done by FSNamesystem vs. FSDirectory? You can find some good info about the differences in this comment .
        Hide
        qwertymaniac Harsh J added a comment -

        Aaron T. Myers - Done. Please review this new patch, hope it is a bit more clearer (although still doesn't cover it all though).

        Show
        qwertymaniac Harsh J added a comment - Aaron T. Myers - Done. Please review this new patch, hope it is a bit more clearer (although still doesn't cover it all though).
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526629/HDFS-2312.r2.diff
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2429//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2429//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526629/HDFS-2312.r2.diff against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2429//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2429//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        Failed org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy

        -1 tests included. The patch doesn't appear to include any new or modified tests.

        All my patch proposes to change is FSNamesystem's class javadoc. Tests are not required, hence, and the single test failure seems to be due to something else as my patch touches zero code.

        Show
        qwertymaniac Harsh J added a comment - Failed org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy -1 tests included. The patch doesn't appear to include any new or modified tests. All my patch proposes to change is FSNamesystem's class javadoc. Tests are not required, hence, and the single test failure seems to be due to something else as my patch touches zero code.
        Hide
        atm Aaron T. Myers added a comment -

        +1, the patch looks good to me.

        Thanks a lot for taking care of this, Harsh.

        Show
        atm Aaron T. Myers added a comment - +1, the patch looks good to me. Thanks a lot for taking care of this, Harsh.
        Hide
        qwertymaniac Harsh J added a comment -

        Committed to trunk. Thanks for reviewing atm!

        Show
        qwertymaniac Harsh J added a comment - Committed to trunk. Thanks for reviewing atm!
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2313 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2313/)
        HDFS-2312. FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2313 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2313/ ) HDFS-2312 . FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2239 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2239/)
        HDFS-2312. FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2239 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2239/ ) HDFS-2312 . FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2256 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2256/)
        HDFS-2312. FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761)

        Result = ABORTED
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2256 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2256/ ) HDFS-2312 . FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761) Result = ABORTED harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1042 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1042/)
        HDFS-2312. FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1042 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1042/ ) HDFS-2312 . FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1078 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1078/)
        HDFS-2312. FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1078 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1078/ ) HDFS-2312 . FSNamesystem javadoc incorrectly says its for DNs. (harsh) (Revision 1337761) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337761 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

          People

          • Assignee:
            qwertymaniac Harsh J
            Reporter:
            atm Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development