Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2294

Download of commons-daemon TAR should not be under target

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.0, 0.24.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Committed HDFS-2289 downloads commons-daemon TAR in the hadoop-hdfs/target/, earlier patches for HDFS-2289 were using hadoop-hdfs/download/ as the location for the download.

      The motivation not to use the 'target/' directory is that on every clean build the TAR will be downloaded from Apache archives. Using a 'download' directory this happens once per workspace.

      The patch was also adding the 'download/' directory to the .gitignore file (it should also be svn ignored).

      Besides downloading it only once, it allows to do a clean build in disconnected mode.

      IMO, the later is a nice developer capability.

      1. HDFS-2289.patch
        2 kB
        Alejandro Abdelnur

        Issue Links

          Activity

          Alejandro Abdelnur created issue -
          Alejandro Abdelnur made changes -
          Field Original Value New Value
          Link This issue is related to HDFS-2289 [ HDFS-2289 ]
          Hide
          Alejandro Abdelnur added a comment -

          When SVN committing the directory 'hadoop-hdfs-project/hadoop-hdfs/downloads' should be svn:ignored

          Show
          Alejandro Abdelnur added a comment - When SVN committing the directory 'hadoop-hdfs-project/hadoop-hdfs/downloads' should be svn:ignored
          Alejandro Abdelnur made changes -
          Attachment HDFS-2289.patch [ 12494820 ]
          Alejandro Abdelnur made changes -
          Assignee Alejandro Abdelnur [ tucu00 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Affects Version/s 0.24.0 [ 12317653 ]
          Alejandro Abdelnur made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12494820/HDFS-2289.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1262//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494820/HDFS-2289.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1262//console This message is automatically generated.
          Hide
          Alejandro Abdelnur added a comment -

          patch still applies cleanly.

          Show
          Alejandro Abdelnur added a comment - patch still applies cleanly.
          Hide
          Aaron T. Myers added a comment -

          +1, the patch looks good to me. I applied the patch, ran `mvn clean package -DskipTests', and confirmed that commons-daemon is now downloaded to a directory outside of the target/ directory.

          Show
          Aaron T. Myers added a comment - +1, the patch looks good to me. I applied the patch, ran `mvn clean package -DskipTests' , and confirmed that commons-daemon is now downloaded to a directory outside of the target/ directory.
          Hide
          Alejandro Abdelnur added a comment -

          committed to trunk, in a few days it will be committed to 0.23 in a combo with other maven related patches.

          Show
          Alejandro Abdelnur added a comment - committed to trunk, in a few days it will be committed to 0.23 in a combo with other maven related patches.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1045/)
          HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894
          Files :

          • /hadoop/common/trunk/.gitignore
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1045/ ) HDFS-2294 . Download of commons-daemon TAR should not be under target (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894 Files : /hadoop/common/trunk/.gitignore /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1027 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1027/)
          HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894
          Files :

          • /hadoop/common/trunk/.gitignore
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1027 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1027/ ) HDFS-2294 . Download of commons-daemon TAR should not be under target (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894 Files : /hadoop/common/trunk/.gitignore /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1105/)
          HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894
          Files :

          • /hadoop/common/trunk/.gitignore
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1105/ ) HDFS-2294 . Download of commons-daemon TAR should not be under target (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894 Files : /hadoop/common/trunk/.gitignore /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #823 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/823/)
          HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894
          Files :

          • /hadoop/common/trunk/.gitignore
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #823 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/823/ ) HDFS-2294 . Download of commons-daemon TAR should not be under target (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894 Files : /hadoop/common/trunk/.gitignore /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #853 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/853/)
          HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894
          Files :

          • /hadoop/common/trunk/.gitignore
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #853 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/853/ ) HDFS-2294 . Download of commons-daemon TAR should not be under target (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179894 Files : /hadoop/common/trunk/.gitignore /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Alejandro Abdelnur made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #99 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/99/)
          Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573
          Files :

          • /hadoop/common/branches/branch-0.23/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #99 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/99/ ) Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573 Files : /hadoop/common/branches/branch-0.23/.gitignore /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #99 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/99/)
          Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573
          Files :

          • /hadoop/common/branches/branch-0.23/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #99 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/99/ ) Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573 Files : /hadoop/common/branches/branch-0.23/.gitignore /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #103 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/103/)
          Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573
          Files :

          • /hadoop/common/branches/branch-0.23/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #103 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/103/ ) Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573 Files : /hadoop/common/branches/branch-0.23/.gitignore /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #54 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/54/)
          Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573
          Files :

          • /hadoop/common/branches/branch-0.23/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #54 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/54/ ) Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573 Files : /hadoop/common/branches/branch-0.23/.gitignore /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #72 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/72/)
          Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294

          tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573
          Files :

          • /hadoop/common/branches/branch-0.23/.gitignore
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #72 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/72/ ) Merge -r 1179893:1179894 from trunk to branch-0.23. Fixes: HDFS-2294 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190573 Files : /hadoop/common/branches/branch-0.23/.gitignore /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Alejandro Abdelnur
              Reporter:
              Alejandro Abdelnur
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development