Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2267

DataXceiver thread name incorrect while waiting on op during keepalive

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since HDFS-941, the DataXceiver can spend time waiting for a second op to come from the client. Currently, its thread name indicates whatever the previous operation was, rather than something like "Waiting in keepalive for a new request" or something.

      1. hdfs-2267.txt
        1 kB
        Todd Lipcon

        Activity

        Hide
        Todd Lipcon added a comment -

        Trivial patch

        Show
        Todd Lipcon added a comment - Trivial patch
        Hide
        Eli Collins added a comment -

        +1

        Show
        Eli Collins added a comment - +1
        Hide
        Todd Lipcon added a comment -

        Committed to trunk after manually running some tests that cover the changed code path.

        Show
        Todd Lipcon added a comment - Committed to trunk after manually running some tests that cover the changed code path.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #849 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/849/)
        HDFS-2267. DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873
        Files :

        • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #849 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/849/ ) HDFS-2267 . DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873 Files : /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #772 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/772/)
        HDFS-2267. DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873
        Files :

        • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #772 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/772/ ) HDFS-2267 . DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873 Files : /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12491022/hdfs-2267.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1147//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1147//artifact/trunk/target/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1147//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491022/hdfs-2267.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1147//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1147//artifact/trunk/target/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1147//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #780 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/780/)
        HDFS-2267. DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873
        Files :

        • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #780 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/780/ ) HDFS-2267 . DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873 Files : /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #764 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/764/)
        HDFS-2267. DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873
        Files :

        • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #764 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/764/ ) HDFS-2267 . DataXceiver thread name incorrect while waiting on op during keepalive. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160873 Files : /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development