Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. h2266_20110817.patch
      27 kB
      Tsz Wo Nicholas Sze
    2. h2266_20110817b.patch
      28 kB
      Tsz Wo Nicholas Sze
    3. h2266_20110820.patch
      25 kB
      Tsz Wo Nicholas Sze

      Activity

      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/779/)
      HDFS-2266. Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager.

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493
      Files :

      • /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/779/ ) HDFS-2266 . Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493 Files : /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #763 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/763/)
      HDFS-2266. Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager.

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493
      Files :

      • /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #763 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/763/ ) HDFS-2266 . Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493 Files : /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Hide
      Tsz Wo Nicholas Sze added a comment -

      Thanks Suresh for the review.

      I have committed this.

      Show
      Tsz Wo Nicholas Sze added a comment - Thanks Suresh for the review. I have committed this.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #770 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/770/)
      HDFS-2266. Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager.

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493
      Files :

      • /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #770 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/770/ ) HDFS-2266 . Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493 Files : /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #847 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/847/)
      HDFS-2266. Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager.

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493
      Files :

      • /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java
      • /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #847 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/847/ ) HDFS-2266 . Add Namesystem and SafeMode interfaces to avoid directly referring to FSNamesystem in BlockManager. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160493 Files : /hadoop/common/trunk/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SafeMode.java /hadoop/common/trunk/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Hide
      Tsz Wo Nicholas Sze added a comment -

      The failed tests are not related.

      Show
      Tsz Wo Nicholas Sze added a comment - The failed tests are not related.
      Hide
      Suresh Srinivas added a comment -

      +1 for the change.

      Show
      Suresh Srinivas added a comment - +1 for the change.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12491075/h2266_20110820.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these core unit tests:

      +1 contrib tests. The patch passed contrib unit tests.

      +1 system test framework. The patch passed system test framework compile.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1144//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1144//artifact/trunk/target/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1144//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491075/h2266_20110820.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1144//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1144//artifact/trunk/target/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1144//console This message is automatically generated.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      h2266_20110820.patch: incorporated Suresh's comments.

      Show
      Tsz Wo Nicholas Sze added a comment - h2266_20110820.patch: incorporated Suresh's comments.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      > 1. SafeMode.java
      > ...

      Done.

      > 2. Why not just use import DFSConfigKeys.* instead of expanding it to individual imports? Keeps it brief.

      I used ctrl-shift-o in eclipse to fix the imports. Keeping it brief is great but we lose we have to manually fix the imports. So it may not be doable.

      I have reverted the import change manually.

      Show
      Tsz Wo Nicholas Sze added a comment - > 1. SafeMode.java > ... Done. > 2. Why not just use import DFSConfigKeys.* instead of expanding it to individual imports? Keeps it brief. I used ctrl-shift-o in eclipse to fix the imports. Keeping it brief is great but we lose we have to manually fix the imports. So it may not be doable. I have reverted the import change manually.
      Hide
      Suresh Srinivas added a comment -

      Good change.

      Comments:

      1. SafeMode.java
        • Add InterfaceAudience.PRIVATE annotation. Same for Namesystem.java
        • "Check whether replication queues are populated." to "Check whether replication queues are being populated." - Added being
        • I am not sure javadoc "Check and trigger safe mode" is clear enough
        • isInStartupSafeMode - javadoc could describe what startup safemode is
      2. Why not just use import DFSConfigKeys.* instead of expanding it to individual imports? Keeps it brief.
      Show
      Suresh Srinivas added a comment - Good change. Comments: SafeMode.java Add InterfaceAudience.PRIVATE annotation. Same for Namesystem.java "Check whether replication queues are populated." to "Check whether replication queues are being populated." - Added being I am not sure javadoc "Check and trigger safe mode" is clear enough isInStartupSafeMode - javadoc could describe what startup safemode is Why not just use import DFSConfigKeys.* instead of expanding it to individual imports? Keeps it brief.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      The failed tests are not related.

      Show
      Tsz Wo Nicholas Sze added a comment - The failed tests are not related.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12490707/h2266_20110817b.patch
      against trunk revision 1158933.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these core unit tests:
      org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
      org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
      org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
      org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
      org.apache.hadoop.hdfs.TestDFSRollback
      org.apache.hadoop.hdfs.TestHDFSServerPorts

      +1 contrib tests. The patch passed contrib unit tests.

      -1 system test framework. The patch failed system test framework compile.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1113//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1113//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1113//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490707/h2266_20110817b.patch against trunk revision 1158933. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy org.apache.hadoop.hdfs.server.namenode.TestCheckpoint org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings org.apache.hadoop.hdfs.TestDFSRollback org.apache.hadoop.hdfs.TestHDFSServerPorts +1 contrib tests. The patch passed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1113//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1113//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1113//console This message is automatically generated.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      h2266_20110817b.patch: fixed a NullPointerException.

      Show
      Tsz Wo Nicholas Sze added a comment - h2266_20110817b.patch: fixed a NullPointerException.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12490657/h2266_20110817.patch
      against trunk revision 1158743.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these core unit tests:
      org.apache.hadoop.cli.TestHDFSCLI
      org.apache.hadoop.fs.loadGenerator.TestLoadGenerator
      org.apache.hadoop.fs.permission.TestStickyBit
      org.apache.hadoop.fs.TestFcHdfsCreateMkdir
      org.apache.hadoop.fs.TestFcHdfsPermission
      org.apache.hadoop.fs.TestFcHdfsSymlink
      org.apache.hadoop.fs.TestHDFSFileContextMainOperations
      org.apache.hadoop.fs.TestUrlStreamHandler
      org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
      org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs
      org.apache.hadoop.fs.viewfs.TestViewFsHdfs
      org.apache.hadoop.hdfs.security.token.block.TestBlockToken
      org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
      org.apache.hadoop.hdfs.server.balancer.TestBalancer
      org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
      org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
      org.apache.hadoop.hdfs.server.blockmanagement.TestNodeCount
      org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
      org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
      org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
      org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade
      org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
      org.apache.hadoop.hdfs.server.datanode.TestBlockReport
      org.apache.hadoop.hdfs.server.datanode.TestDatanodeJsp
      org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
      org.apache.hadoop.hdfs.server.datanode.TestDatanodeRestart
      org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
      org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
      org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
      org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
      org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
      org.apache.hadoop.hdfs.server.datanode.TestDiskError
      org.apache.hadoop.hdfs.server.datanode.TestInterDatanodeProtocol
      org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner
      org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
      org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
      org.apache.hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
      org.apache.hadoop.hdfs.server.namenode.TestBlockUnderConstruction
      org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
      org.apache.hadoop.hdfs.server.namenode.TestCorruptFilesJsp
      org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus
      org.apache.hadoop.hdfs.server.namenode.TestFileLimit
      org.apache.hadoop.hdfs.server.namenode.TestFsck
      org.apache.hadoop.hdfs.server.namenode.TestFSEditLogLoader
      org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
      org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
      org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
      org.apache.hadoop.hdfs.server.namenode.TestMetaSave
      org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs
      org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
      org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
      org.apache.hadoop.hdfs.server.namenode.TestStartup
      org.apache.hadoop.hdfs.server.namenode.TestStreamFile
      org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
      org.apache.hadoop.hdfs.TestAbandonBlock
      org.apache.hadoop.hdfs.TestBlockMissingException
      org.apache.hadoop.hdfs.TestBlocksScheduledCounter
      org.apache.hadoop.hdfs.TestClientBlockVerification
      org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
      org.apache.hadoop.hdfs.TestClientReportBadBlock
      org.apache.hadoop.hdfs.TestConnCache
      org.apache.hadoop.hdfs.TestCrcCorruption
      org.apache.hadoop.hdfs.TestDatanodeBlockScanner
      org.apache.hadoop.hdfs.TestDatanodeDeath
      org.apache.hadoop.hdfs.TestDataTransferProtocol
      org.apache.hadoop.hdfs.TestDecommission
      org.apache.hadoop.hdfs.TestDFSClientExcludedNodes
      org.apache.hadoop.hdfs.TestDFSClientRetries
      org.apache.hadoop.hdfs.TestDFSFinalize
      org.apache.hadoop.hdfs.TestDFSMkdirs
      org.apache.hadoop.hdfs.TestDfsOverAvroRpc
      org.apache.hadoop.hdfs.TestDFSPermission
      org.apache.hadoop.hdfs.TestDFSRemove
      org.apache.hadoop.hdfs.TestDFSRename
      org.apache.hadoop.hdfs.TestDFSRollback
      org.apache.hadoop.hdfs.TestDFSShell
      org.apache.hadoop.hdfs.TestDFSStartupVersions
      org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
      org.apache.hadoop.hdfs.TestDFSUpgrade
      org.apache.hadoop.hdfs.TestDistributedFileSystem
      org.apache.hadoop.hdfs.TestFileAppend2
      org.apache.hadoop.hdfs.TestFileAppend3
      org.apache.hadoop.hdfs.TestFileAppend4
      org.apache.hadoop.hdfs.TestFileAppend
      org.apache.hadoop.hdfs.TestFileConcurrentReader
      org.apache.hadoop.hdfs.TestFileCorruption
      org.apache.hadoop.hdfs.TestFileCreationDelete
      org.apache.hadoop.hdfs.TestFileCreationNamenodeRestart
      org.apache.hadoop.hdfs.TestFileCreation
      org.apache.hadoop.hdfs.TestFileStatus
      org.apache.hadoop.hdfs.TestFSInputChecker
      org.apache.hadoop.hdfs.TestFSOutputSummer
      org.apache.hadoop.hdfs.TestGetBlocks
      org.apache.hadoop.hdfs.TestHDFSFileSystemContract
      org.apache.hadoop.hdfs.TestHDFSServerPorts
      org.apache.hadoop.hdfs.TestHDFSTrash
      org.apache.hadoop.hdfs.TestHFlush
      org.apache.hadoop.hdfs.TestHftpFileSystem
      org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
      org.apache.hadoop.hdfs.TestLargeBlock
      org.apache.hadoop.hdfs.TestLeaseRecovery2
      org.apache.hadoop.hdfs.TestLeaseRecovery
      org.apache.hadoop.hdfs.TestLease
      org.apache.hadoop.hdfs.TestListFilesInDFS
      org.apache.hadoop.hdfs.TestListFilesInFileContext
      org.apache.hadoop.hdfs.TestListPathServlet
      org.apache.hadoop.hdfs.TestLocalDFS
      org.apache.hadoop.hdfs.TestMissingBlocksAlert
      org.apache.hadoop.hdfs.TestModTime
      org.apache.hadoop.hdfs.TestMultiThreadedHflush
      org.apache.hadoop.hdfs.TestParallelRead
      org.apache.hadoop.hdfs.TestPipelines
      org.apache.hadoop.hdfs.TestPread
      org.apache.hadoop.hdfs.TestQuota
      org.apache.hadoop.hdfs.TestReadWhileWriting
      org.apache.hadoop.hdfs.TestRenameWhileOpen
      org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure
      org.apache.hadoop.hdfs.TestReplication
      org.apache.hadoop.hdfs.TestRestartDFS
      org.apache.hadoop.hdfs.TestSafeMode
      org.apache.hadoop.hdfs.TestSeekBug
      org.apache.hadoop.hdfs.TestSetrepDecreasing
      org.apache.hadoop.hdfs.TestSetrepIncreasing
      org.apache.hadoop.hdfs.TestSetTimes
      org.apache.hadoop.hdfs.TestSmallBlock
      org.apache.hadoop.hdfs.TestWriteConfigurationToDFS
      org.apache.hadoop.hdfs.TestWriteRead
      org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
      org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
      org.apache.hadoop.security.TestPermission
      org.apache.hadoop.tools.TestJMXGet

      +1 contrib tests. The patch passed contrib unit tests.

      -1 system test framework. The patch failed system test framework compile.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1110//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1110//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1110//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490657/h2266_20110817.patch against trunk revision 1158743. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.fs.loadGenerator.TestLoadGenerator org.apache.hadoop.fs.permission.TestStickyBit org.apache.hadoop.fs.TestFcHdfsCreateMkdir org.apache.hadoop.fs.TestFcHdfsPermission org.apache.hadoop.fs.TestFcHdfsSymlink org.apache.hadoop.fs.TestHDFSFileContextMainOperations org.apache.hadoop.fs.TestUrlStreamHandler org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs org.apache.hadoop.fs.viewfs.TestViewFsHdfs org.apache.hadoop.hdfs.security.token.block.TestBlockToken org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS org.apache.hadoop.hdfs.server.blockmanagement.TestNodeCount org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.server.datanode.TestDatanodeJsp org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics org.apache.hadoop.hdfs.server.datanode.TestDatanodeRestart org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner org.apache.hadoop.hdfs.server.datanode.TestDiskError org.apache.hadoop.hdfs.server.datanode.TestInterDatanodeProtocol org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner org.apache.hadoop.hdfs.server.datanode.TestTransferRbw org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics org.apache.hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps org.apache.hadoop.hdfs.server.namenode.TestBlockUnderConstruction org.apache.hadoop.hdfs.server.namenode.TestCheckpoint org.apache.hadoop.hdfs.server.namenode.TestCorruptFilesJsp org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus org.apache.hadoop.hdfs.server.namenode.TestFileLimit org.apache.hadoop.hdfs.server.namenode.TestFsck org.apache.hadoop.hdfs.server.namenode.TestFSEditLogLoader org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks org.apache.hadoop.hdfs.server.namenode.TestMetaSave org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite org.apache.hadoop.hdfs.server.namenode.TestStartup org.apache.hadoop.hdfs.server.namenode.TestStreamFile org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings org.apache.hadoop.hdfs.TestAbandonBlock org.apache.hadoop.hdfs.TestBlockMissingException org.apache.hadoop.hdfs.TestBlocksScheduledCounter org.apache.hadoop.hdfs.TestClientBlockVerification org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery org.apache.hadoop.hdfs.TestClientReportBadBlock org.apache.hadoop.hdfs.TestConnCache org.apache.hadoop.hdfs.TestCrcCorruption org.apache.hadoop.hdfs.TestDatanodeBlockScanner org.apache.hadoop.hdfs.TestDatanodeDeath org.apache.hadoop.hdfs.TestDataTransferProtocol org.apache.hadoop.hdfs.TestDecommission org.apache.hadoop.hdfs.TestDFSClientExcludedNodes org.apache.hadoop.hdfs.TestDFSClientRetries org.apache.hadoop.hdfs.TestDFSFinalize org.apache.hadoop.hdfs.TestDFSMkdirs org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.TestDFSPermission org.apache.hadoop.hdfs.TestDFSRemove org.apache.hadoop.hdfs.TestDFSRename org.apache.hadoop.hdfs.TestDFSRollback org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestDFSStartupVersions org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestDFSUpgrade org.apache.hadoop.hdfs.TestDistributedFileSystem org.apache.hadoop.hdfs.TestFileAppend2 org.apache.hadoop.hdfs.TestFileAppend3 org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestFileAppend org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestFileCorruption org.apache.hadoop.hdfs.TestFileCreationDelete org.apache.hadoop.hdfs.TestFileCreationNamenodeRestart org.apache.hadoop.hdfs.TestFileCreation org.apache.hadoop.hdfs.TestFileStatus org.apache.hadoop.hdfs.TestFSInputChecker org.apache.hadoop.hdfs.TestFSOutputSummer org.apache.hadoop.hdfs.TestGetBlocks org.apache.hadoop.hdfs.TestHDFSFileSystemContract org.apache.hadoop.hdfs.TestHDFSServerPorts org.apache.hadoop.hdfs.TestHDFSTrash org.apache.hadoop.hdfs.TestHFlush org.apache.hadoop.hdfs.TestHftpFileSystem org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestLeaseRecovery2 org.apache.hadoop.hdfs.TestLeaseRecovery org.apache.hadoop.hdfs.TestLease org.apache.hadoop.hdfs.TestListFilesInDFS org.apache.hadoop.hdfs.TestListFilesInFileContext org.apache.hadoop.hdfs.TestListPathServlet org.apache.hadoop.hdfs.TestLocalDFS org.apache.hadoop.hdfs.TestMissingBlocksAlert org.apache.hadoop.hdfs.TestModTime org.apache.hadoop.hdfs.TestMultiThreadedHflush org.apache.hadoop.hdfs.TestParallelRead org.apache.hadoop.hdfs.TestPipelines org.apache.hadoop.hdfs.TestPread org.apache.hadoop.hdfs.TestQuota org.apache.hadoop.hdfs.TestReadWhileWriting org.apache.hadoop.hdfs.TestRenameWhileOpen org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure org.apache.hadoop.hdfs.TestReplication org.apache.hadoop.hdfs.TestRestartDFS org.apache.hadoop.hdfs.TestSafeMode org.apache.hadoop.hdfs.TestSeekBug org.apache.hadoop.hdfs.TestSetrepDecreasing org.apache.hadoop.hdfs.TestSetrepIncreasing org.apache.hadoop.hdfs.TestSetTimes org.apache.hadoop.hdfs.TestSmallBlock org.apache.hadoop.hdfs.TestWriteConfigurationToDFS org.apache.hadoop.hdfs.TestWriteRead org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer org.apache.hadoop.security.TestPermission org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1110//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1110//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1110//console This message is automatically generated.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      h2266_20110817.patch: added Namesystem and SafeMode interfaces.

      Show
      Tsz Wo Nicholas Sze added a comment - h2266_20110817.patch: added Namesystem and SafeMode interfaces.

        People

        • Assignee:
          Tsz Wo Nicholas Sze
          Reporter:
          Tsz Wo Nicholas Sze
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development