Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2259

DN web-UI doesn't work with paths that contain html

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.205.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The 20-based DN web UI doesn't work with paths that contain html. The paths need to be unescaped when used to access the file and escaped when printed for navigation.

        Activity

        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0
        Hide
        Eli Collins added a comment -

        I've committed this.

        Show
        Eli Collins added a comment - I've committed this.
        Hide
        Eli Collins added a comment -

        Thanks Todd. If no one objects I'll merge this to branch-0.20-security.

        Show
        Eli Collins added a comment - Thanks Todd. If no one objects I'll merge this to branch-0.20-security.
        Hide
        Todd Lipcon added a comment -

        +1, looks good to me.

        Show
        Todd Lipcon added a comment - +1, looks good to me.
        Hide
        Eli Collins added a comment -

        Patch attached.

        Testing: created and accessed the following set of paths with the web UI (browse, goto, tail, download, etc).

        /user/eli/dir0/foo bar/dir/foo bar
        /user/eli/dir0/foo">bar/dir/foo">bar
        /user/eli/dir0/foo+bar/dir/foo+bar
        /user/eli/dir0/foo;bar/dir/foo;bar
        /user/eli/dir0/foo?bar/dir/foo?bar
        
        Show
        Eli Collins added a comment - Patch attached. Testing: created and accessed the following set of paths with the web UI (browse, goto, tail, download, etc). /user/eli/dir0/foo bar/dir/foo bar /user/eli/dir0/foo">bar/dir/foo">bar /user/eli/dir0/foo+bar/dir/foo+bar /user/eli/dir0/foo;bar/dir/foo;bar /user/eli/dir0/foo?bar/dir/foo?bar

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development