Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2233

Add WebUI tests with URI reserved chars in the path and filename

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.

      1. hdfs-2233-2.patch
        2 kB
        Eli Collins
      2. hdfs-2233-1.patch
        1 kB
        Eli Collins

        Issue Links

          Activity

          Eli Collins created issue -
          Hide
          Eli Collins added a comment -

          Patch attached adds tests to TestDatanodeJsp that illustrate this. The two tests commented out fail.

          Show
          Eli Collins added a comment - Patch attached adds tests to TestDatanodeJsp that illustrate this. The two tests commented out fail.
          Eli Collins made changes -
          Field Original Value New Value
          Attachment hdfs-2233-1.patch [ 12489652 ]
          Eli Collins made changes -
          Link This issue relates to HDFS-1109 [ HDFS-1109 ]
          Eli Collins made changes -
          Assignee Eli Collins [ eli ]
          Hide
          Eli Collins added a comment -

          HDFS-2235 fixed this issue, we just need to add more tests.

          Show
          Eli Collins added a comment - HDFS-2235 fixed this issue, we just need to add more tests.
          Eli Collins made changes -
          Summary WebUI doesn't handle file names with ";" and "+" characters Add WebUI tests with URI reserved chars in the path and filename
          Description The web UI can't handle paths like "/foo;bar" and "/foo+bar", ie that contain reserved URI characters. The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Eli Collins made changes -
          Attachment hdfs-2233-2.patch [ 12490356 ]
          Hide
          Aaron T. Myers added a comment -

          +1, patch looks good to me.

          Show
          Aaron T. Myers added a comment - +1, patch looks good to me.
          Hide
          Eli Collins added a comment -
          +1 overall.  
          
              +1 @author.  The patch does not contain any @author tags.
          
              +1 tests included.  The patch appears to include 14 new or modified tests.
          
              +1 javadoc.  The javadoc tool did not generate any warning messages.
          
              +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
          
              +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          
              +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
              +1 system test framework.  The patch passed system test framework compile.
          

          And TestDatanodeJsp passes.

          Show
          Eli Collins added a comment - +1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 system test framework. The patch passed system test framework compile. And TestDatanodeJsp passes.
          Eli Collins made changes -
          Issue Type Bug [ 1 ] Test [ 6 ]
          Hide
          Eli Collins added a comment -

          Thanks atm! I've committed this.

          Show
          Eli Collins added a comment - Thanks atm! I've committed this.
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Reviewed]
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #835 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/835/)
          HDFS-2233. Add WebUI tests with URI reserved chars. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025
          Files :

          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #835 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/835/ ) HDFS-2233 . Add WebUI tests with URI reserved chars. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #744 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/744/)
          HDFS-2233. Add WebUI tests with URI reserved chars. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025
          Files :

          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #744 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/744/ ) HDFS-2233 . Add WebUI tests with URI reserved chars. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #752 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/752/)
          HDFS-2233. Add WebUI tests with URI reserved chars. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025
          Files :

          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #752 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/752/ ) HDFS-2233 . Add WebUI tests with URI reserved chars. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development