Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0, 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Several HDFS CLI tests fail on 0.22 branch. I can see 2 reasons:

      1. Not generic enough regular expression for host names and paths. Similar to MAPREDUCE-2304.
      2. Some command outputs have new-line in the end.
      3. And some seem to produce [much] more output than expected.
      1. HDFS-2232-TRUNK.patch
        105 kB
        Plamen Jeliazkov
      2. HDFS-2232-TRUNK.patch
        105 kB
        Plamen Jeliazkov
      3. HDFS-2232-TRUNK.patch
        105 kB
        Plamen Jeliazkov
      4. TestHDFSCLI-output.txt
        9 kB
        Konstantin Shvachko
      5. HDFS-2232-TRUNK.patch
        105 kB
        Plamen Jeliazkov
      6. HDFS-2232.patch
        102 kB
        Konstantin Shvachko
      7. HDFS-2232.patch
        132 kB
        Plamen Jeliazkov
      8. TEST-org.apache.hadoop.cli.TestHDFSCLI.txt
        189 kB
        Konstantin Shvachko
      9. HDFS-2232.patch
        128 kB
        Plamen Jeliazkov
      10. HDFS-2232.patch
        130 kB
        Plamen Jeliazkov
      11. TEST-org.apache.hadoop.cli.TestHDFSCLI.txt
        826 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          4d 11h 20m 2 Plamen Jeliazkov 07/Sep/11 20:49
          Open Open Patch Available Patch Available
          28d 7h 18m 3 Plamen Jeliazkov 07/Sep/11 20:50
          Patch Available Patch Available Resolved Resolved
          3h 52m 1 Konstantin Shvachko 08/Sep/11 00:43
          Resolved Resolved Closed Closed
          68d 1h 9m 1 Arun C Murthy 15/Nov/11 00:52
          Allen Wittenauer made changes -
          Fix Version/s 2.0.0-alpha [ 12320353 ]
          Allen Wittenauer made changes -
          Fix Version/s 2.0.0-alpha [ 12320353 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #810 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/810/)
          HDFS-2232. Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #810 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/810/ ) HDFS-2232 . Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #787 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/787/)
          HDFS-2232. Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #787 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/787/ ) HDFS-2232 . Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12493528/HDFS-2232-TRUNK.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 134 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
          org.apache.hadoop.hdfs.TestDfsOverAvroRpc

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1223//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1223//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1223//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493528/HDFS-2232-TRUNK.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 134 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.datanode.TestReplicasMap org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.TestDfsOverAvroRpc +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1223//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1223//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1223//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #847 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/847/)
          HDFS-2232. Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #847 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/847/ ) HDFS-2232 . Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #858 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/858/)
          HDFS-2232. Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #858 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/858/ ) HDFS-2232 . Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #924 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/924/)
          HDFS-2232. Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #924 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/924/ ) HDFS-2232 . Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166470 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Konstantin Shvachko made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.23.0 [ 12315571 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Resolution Fixed [ 1 ]
          Hide
          Konstantin Shvachko added a comment -

          I just committed this. Thank you Plamen.

          Show
          Konstantin Shvachko added a comment - I just committed this. Thank you Plamen.
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232-TRUNK.patch [ 12493528 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12493368/HDFS-2232-TRUNK.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 134 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.TestDfsOverAvroRpc
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
          org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
          org.apache.hadoop.cli.TestHDFSCLI

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1221//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1221//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1221//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493368/HDFS-2232-TRUNK.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 134 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1221//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1221//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1221//console This message is automatically generated.
          Plamen Jeliazkov made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232-TRUNK.patch [ 12493368 ]
          Hide
          Plamen Jeliazkov added a comment -

          This should be it.

          Show
          Plamen Jeliazkov added a comment - This should be it.
          Plamen Jeliazkov made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12493340/HDFS-2232-TRUNK.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 134 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
          org.apache.hadoop.cli.TestHDFSCLI
          org.apache.hadoop.hdfs.TestDfsOverAvroRpc

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1218//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1218//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1218//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493340/HDFS-2232-TRUNK.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 134 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.datanode.TestReplicasMap org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.TestDfsOverAvroRpc +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1218//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1218//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1218//console This message is automatically generated.
          Hide
          Konstantin Shvachko added a comment -

          Test ID: [587]
          Hopefully the last one.

          Show
          Konstantin Shvachko added a comment - Test ID: [587] Hopefully the last one.
          Plamen Jeliazkov made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232-TRUNK.patch [ 12493340 ]
          Hide
          Plamen Jeliazkov added a comment -

          Fixed up patch. Was missing a [0-9] in a regex and the localhost hardcode replacement was expecting a ':' character which was causing it to fail.

          Show
          Plamen Jeliazkov added a comment - Fixed up patch. Was missing a [0-9] in a regex and the localhost hardcode replacement was expecting a ':' character which was causing it to fail.
          Konstantin Shvachko made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12493261/TestHDFSCLI-output.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1212//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493261/TestHDFSCLI-output.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1212//console This message is automatically generated.
          Konstantin Shvachko made changes -
          Attachment TestHDFSCLI-output.txt [ 12493261 ]
          Hide
          Konstantin Shvachko added a comment -

          Two more failures on trunk for me.

          Show
          Konstantin Shvachko added a comment - Two more failures on trunk for me.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12493252/HDFS-2232-TRUNK.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 134 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.TestDfsOverAvroRpc
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
          org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
          org.apache.hadoop.cli.TestHDFSCLI

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1211//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1211//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1211//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493252/HDFS-2232-TRUNK.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 134 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1211//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1211//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1211//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12493245/HDFS-2232.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 131 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.TestDfsOverAvroRpc
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1210//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1210//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1210//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493245/HDFS-2232.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 131 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1210//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1210//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1210//console This message is automatically generated.
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232-TRUNK.patch [ 12493252 ]
          Hide
          Plamen Jeliazkov added a comment -

          Should catch any remaining failures for trunk.

          Show
          Plamen Jeliazkov added a comment - Should catch any remaining failures for trunk.
          Konstantin Shvachko made changes -
          Attachment HDFS-2232.patch [ 12493245 ]
          Konstantin Shvachko made changes -
          Attachment HDFS-2232.patch [ 12492779 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12492779/HDFS-2232.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 131 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.TestDfsOverAvroRpc
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
          org.apache.hadoop.hdfs.server.datanode.TestReplicasMap

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492779/HDFS-2232.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 131 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1189//console This message is automatically generated.
          Plamen Jeliazkov made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232.patch [ 12492779 ]
          Hide
          Plamen Jeliazkov added a comment -

          Patch for trunk.

          Show
          Plamen Jeliazkov added a comment - Patch for trunk.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #80 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/80/)
          HDFS-2232. Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163859
          Files :

          • /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #80 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/80/ ) HDFS-2232 . Generalize regular expressions in TestHDFSCLI. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163859 Files : /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt /hadoop/common/branches/branch-0.22/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml
          Hide
          Konstantin Shvachko added a comment -

          Committed to 0.22 branch. Thanks Plamen. Need a patch for trunk as well.

          Show
          Konstantin Shvachko added a comment - Committed to 0.22 branch. Thanks Plamen. Need a patch for trunk as well.
          Konstantin Shvachko made changes -
          Assignee Plamen Jeliazkov [ zero45 ]
          Hide
          Konstantin Shvachko added a comment -
          [exec] +1 overall.  
          [exec]     +1 @author.  The patch does not contain any @author tags.
          [exec]     +1 tests included.  The patch appears to include 184 new or modified tests.
          [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
          [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
          [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
          [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          [exec]     +1 system test framework.  The patch passed system test framework compile.
          
          Show
          Konstantin Shvachko added a comment - [exec] +1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] +1 tests included. The patch appears to include 184 new or modified tests. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] +1 system test framework. The patch passed system test framework compile.
          Hide
          Konstantin Shvachko added a comment -

          +1 works for me

          Show
          Konstantin Shvachko added a comment - +1 works for me
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232.patch [ 12491572 ]
          Hide
          Plamen Jeliazkov added a comment -

          4 tests remained unfixed. Until now...

          Show
          Plamen Jeliazkov added a comment - 4 tests remained unfixed. Until now...
          Konstantin Shvachko made changes -
          Hide
          Konstantin Shvachko added a comment -

          Pretty good! Out of 183 previously failing tests there is only 4 remaining. Attaching the new log.

          Show
          Konstantin Shvachko added a comment - Pretty good! Out of 183 previously failing tests there is only 4 remaining. Attaching the new log.
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232.patch [ 12491562 ]
          Hide
          Plamen Jeliazkov added a comment -

          Changed patch to work from root rather than specifically the testHDFSConf.xml file.

          Show
          Plamen Jeliazkov added a comment - Changed patch to work from root rather than specifically the testHDFSConf.xml file.
          Plamen Jeliazkov made changes -
          Attachment HDFS-2232.patch [ 12491430 ]
          Hide
          Plamen Jeliazkov added a comment -

          Changed the regex based on Konstantin's log of failed tests. Changed to accept a hyphen in the host name.

          Show
          Plamen Jeliazkov added a comment - Changed the regex based on Konstantin's log of failed tests. Changed to accept a hyphen in the host name.
          Konstantin Shvachko made changes -
          Link This issue blocks HDFS-1852 [ HDFS-1852 ]
          Konstantin Shvachko made changes -
          Summary TtestHDFSCLI fails on 0.22 branch TestHDFSCLI fails on 0.22 branch
          Konstantin Shvachko made changes -
          Link This issue is related to MAPREDUCE-2304 [ MAPREDUCE-2304 ]
          Konstantin Shvachko made changes -
          Description Several HDFS CLI tests fail on 0.22 branch. I can see 2 reasons:
          # Not generic enough regular expression for host names and paths. Similar to MAPREDUCE-2304.
          # Some command outputs have new-line in the end.
          Several HDFS CLI tests fail on 0.22 branch. I can see 2 reasons:
          # Not generic enough regular expression for host names and paths. Similar to MAPREDUCE-2304.
          # Some command outputs have new-line in the end.
          # And some seem to produce [much] more output than expected.
          Konstantin Shvachko made changes -
          Field Original Value New Value
          Attachment TEST-org.apache.hadoop.cli.TestHDFSCLI.txt [ 12489558 ]
          Hide
          Konstantin Shvachko added a comment -

          Attaching the log of failed test.

          Show
          Konstantin Shvachko added a comment - Attaching the log of failed test.
          Konstantin Shvachko created issue -

            People

            • Assignee:
              Plamen Jeliazkov
              Reporter:
              Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development