Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2226

Clean up counting of operations in FSEditLogLoader

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is simple cleanup in FSEditLogLoader - rather than having a variable per operation type, we can just use an EnumMap to count how many instances of each opcode we've hit.

      1. hdfs-2226.txt
        10 kB
        Todd Lipcon
      2. hdfs-2226.txt
        11 kB
        Todd Lipcon

        Activity

        Todd Lipcon created issue -
        Hide
        Todd Lipcon added a comment -

        Simple patch attached.

        It doesn't include new tests since it's just a change to how the debug log output is generated. I manually verified that the output looks reasonable.

        Show
        Todd Lipcon added a comment - Simple patch attached. It doesn't include new tests since it's just a change to how the debug log output is generated. I manually verified that the output looks reasonable.
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hdfs-2226.txt [ 12489412 ]
        Hide
        Todd Lipcon added a comment -

        Sorry, missed a file in previous upload

        Show
        Todd Lipcon added a comment - Sorry, missed a file in previous upload
        Todd Lipcon made changes -
        Attachment hdfs-2226.txt [ 12489415 ]
        Hide
        Aaron T. Myers added a comment -

        +1, patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, patch looks good to me.
        Hide
        Todd Lipcon added a comment -

        Ran test-patch and it checked out aside from lack of tests (justified above). Committed to trunk. Thanks for reviewing, Aaron.

        Show
        Todd Lipcon added a comment - Ran test-patch and it checked out aside from lack of tests (justified above). Committed to trunk. Thanks for reviewing, Aaron.
        Todd Lipcon made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #738 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/738/)
        HDFS-2226. Clean up counting of operations in FSEditLogLoader. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154098
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/util/Holder.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #738 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/738/ ) HDFS-2226 . Clean up counting of operations in FSEditLogLoader. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154098 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/util/Holder.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #812 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/812/)
        HDFS-2226. Clean up counting of operations in FSEditLogLoader. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154098
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/util/Holder.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #812 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/812/ ) HDFS-2226 . Clean up counting of operations in FSEditLogLoader. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154098 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/util/Holder.java
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        7h 47m 1 Todd Lipcon 05/Aug/11 07:03
        Resolved Resolved Closed Closed
        101d 18h 49m 1 Arun C Murthy 15/Nov/11 00:52

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development