Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. h2167_20110719.patch
      48 kB
      Tsz Wo Nicholas Sze
    2. h2167_20110720.patch
      64 kB
      Tsz Wo Nicholas Sze
    3. h2167_20110720b.patch
      64 kB
      Tsz Wo Nicholas Sze
    4. h2167_20110720c.patch
      64 kB
      Tsz Wo Nicholas Sze
    5. h2167_20110721.patch
      62 kB
      Tsz Wo Nicholas Sze

      Issue Links

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2167_20110719.patch: 1st patch.

        Show
        Tsz Wo Nicholas Sze added a comment - h2167_20110719.patch: 1st patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12487020/h2167_20110719.patch
        against trunk revision 1148348.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/976//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/976//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/976//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487020/h2167_20110719.patch against trunk revision 1148348. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/976//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/976//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/976//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2167_20110720.patch: reduced access of some method (e.g. changed public to private)

        Show
        Tsz Wo Nicholas Sze added a comment - h2167_20110720.patch: reduced access of some method (e.g. changed public to private)
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12487139/h2167_20110720.patch
        against trunk revision 1148348.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.fs.loadGenerator.TestLoadGenerator
        org.apache.hadoop.fs.permission.TestStickyBit
        org.apache.hadoop.fs.TestFcHdfsCreateMkdir
        org.apache.hadoop.fs.TestFcHdfsPermission
        org.apache.hadoop.fs.TestFcHdfsSymlink
        org.apache.hadoop.fs.TestGlobPaths
        org.apache.hadoop.fs.TestHDFSFileContextMainOperations
        org.apache.hadoop.fs.TestResolveHdfsSymlink
        org.apache.hadoop.fs.TestUrlStreamHandler
        org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
        org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs
        org.apache.hadoop.fs.viewfs.TestViewFsHdfs
        org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
        org.apache.hadoop.hdfs.security.TestDelegationToken
        org.apache.hadoop.hdfs.security.token.block.TestBlockToken
        org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
        org.apache.hadoop.hdfs.server.balancer.TestBalancer
        org.apache.hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling
        org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
        org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade
        org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
        org.apache.hadoop.hdfs.server.datanode.TestBlockReport
        org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit
        org.apache.hadoop.hdfs.server.datanode.TestDatanodeJsp
        org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
        org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
        org.apache.hadoop.hdfs.server.datanode.TestDataNodeMXBean
        org.apache.hadoop.hdfs.server.datanode.TestDatanodeRestart
        org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
        org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
        org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
        org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
        org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
        org.apache.hadoop.hdfs.server.datanode.TestDiskError
        org.apache.hadoop.hdfs.server.datanode.TestInterDatanodeProtocol
        org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner
        org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes
        org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
        org.apache.hadoop.hdfs.server.datanode.TestWriteToReplica
        org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
        org.apache.hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
        org.apache.hadoop.hdfs.server.namenode.TestAllowFormat
        org.apache.hadoop.hdfs.server.namenode.TestBackupNode
        org.apache.hadoop.hdfs.server.namenode.TestBlocksWithNotEnoughRacks
        org.apache.hadoop.hdfs.server.namenode.TestBlockTokenWithDFS
        org.apache.hadoop.hdfs.server.namenode.TestBlockUnderConstruction
        org.apache.hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens
        org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
        org.apache.hadoop.hdfs.server.namenode.TestComputeInvalidateWork
        org.apache.hadoop.hdfs.server.namenode.TestCorruptFilesJsp
        org.apache.hadoop.hdfs.server.namenode.TestDeadDatanode
        org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus
        org.apache.hadoop.hdfs.server.namenode.TestEditLogFileOutputStream
        org.apache.hadoop.hdfs.server.namenode.TestEditLogRace
        org.apache.hadoop.hdfs.server.namenode.TestEditLog
        org.apache.hadoop.hdfs.server.namenode.TestFileLimit
        org.apache.hadoop.hdfs.server.namenode.TestFsck
        org.apache.hadoop.hdfs.server.namenode.TestFSEditLogLoader
        org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
        org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
        org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
        org.apache.hadoop.hdfs.server.namenode.TestMetaSave
        org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs
        org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
        org.apache.hadoop.hdfs.server.namenode.TestNameNodeJspHelper
        org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean
        org.apache.hadoop.hdfs.server.namenode.TestNameNodeResourceChecker
        org.apache.hadoop.hdfs.server.namenode.TestNodeCount
        org.apache.hadoop.hdfs.server.namenode.TestOverReplicatedBlocks
        org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
        org.apache.hadoop.hdfs.server.namenode.TestSafeMode
        org.apache.hadoop.hdfs.server.namenode.TestSecondaryWebUi
        org.apache.hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
        org.apache.hadoop.hdfs.server.namenode.TestStartup
        org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
        org.apache.hadoop.hdfs.server.namenode.TestStreamFile
        org.apache.hadoop.hdfs.server.namenode.TestTransferFsImage
        org.apache.hadoop.hdfs.TestAbandonBlock
        org.apache.hadoop.hdfs.TestBlockMissingException
        org.apache.hadoop.hdfs.TestBlocksScheduledCounter
        org.apache.hadoop.hdfs.TestClientBlockVerification
        org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
        org.apache.hadoop.hdfs.TestClientReportBadBlock
        org.apache.hadoop.hdfs.TestConnCache
        org.apache.hadoop.hdfs.TestCrcCorruption
        org.apache.hadoop.hdfs.TestDatanodeBlockScanner
        org.apache.hadoop.hdfs.TestDatanodeConfig
        org.apache.hadoop.hdfs.TestDatanodeDeath
        org.apache.hadoop.hdfs.TestDatanodeRegistration
        org.apache.hadoop.hdfs.TestDatanodeReport
        org.apache.hadoop.hdfs.TestDataTransferProtocol
        org.apache.hadoop.hdfs.TestDecommission
        org.apache.hadoop.hdfs.TestDFSAddressConfig
        org.apache.hadoop.hdfs.TestDFSClientExcludedNodes
        org.apache.hadoop.hdfs.TestDFSClientRetries
        org.apache.hadoop.hdfs.TestDFSFinalize
        org.apache.hadoop.hdfs.TestDFSMkdirs
        org.apache.hadoop.hdfs.TestDfsOverAvroRpc
        org.apache.hadoop.hdfs.TestDFSPermission
        org.apache.hadoop.hdfs.TestDFSRemove
        org.apache.hadoop.hdfs.TestDFSRename
        org.apache.hadoop.hdfs.TestDFSRollback
        org.apache.hadoop.hdfs.TestDFSShellGenericOptions
        org.apache.hadoop.hdfs.TestDFSShell
        org.apache.hadoop.hdfs.TestDFSStartupVersions
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
        org.apache.hadoop.hdfs.TestDFSUpgrade
        org.apache.hadoop.hdfs.TestDistributedFileSystem
        org.apache.hadoop.hdfs.TestFileAppend2
        org.apache.hadoop.hdfs.TestFileAppend3
        org.apache.hadoop.hdfs.TestFileAppend4
        org.apache.hadoop.hdfs.TestFileAppend
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestFileCorruption
        org.apache.hadoop.hdfs.TestFileCreationClient
        org.apache.hadoop.hdfs.TestFileCreationDelete
        org.apache.hadoop.hdfs.TestFileCreationEmpty
        org.apache.hadoop.hdfs.TestFileCreationNamenodeRestart
        org.apache.hadoop.hdfs.TestFileCreation
        org.apache.hadoop.hdfs.TestFileStatus
        org.apache.hadoop.hdfs.TestFSInputChecker
        org.apache.hadoop.hdfs.TestFSOutputSummer
        org.apache.hadoop.hdfs.TestGetBlocks
        org.apache.hadoop.hdfs.TestHDFSFileSystemContract
        org.apache.hadoop.hdfs.TestHDFSTrash
        org.apache.hadoop.hdfs.TestHFlush
        org.apache.hadoop.hdfs.TestHftpFileSystem
        org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
        org.apache.hadoop.hdfs.TestLargeBlock
        org.apache.hadoop.hdfs.TestLeaseRecovery2
        org.apache.hadoop.hdfs.TestLeaseRecovery
        org.apache.hadoop.hdfs.TestLease
        org.apache.hadoop.hdfs.TestListFilesInDFS
        org.apache.hadoop.hdfs.TestListFilesInFileContext
        org.apache.hadoop.hdfs.TestListPathServlet
        org.apache.hadoop.hdfs.TestLocalDFS
        org.apache.hadoop.hdfs.TestMissingBlocksAlert
        org.apache.hadoop.hdfs.TestModTime
        org.apache.hadoop.hdfs.TestMultiThreadedHflush
        org.apache.hadoop.hdfs.TestParallelRead
        org.apache.hadoop.hdfs.TestPipelines
        org.apache.hadoop.hdfs.TestPread
        org.apache.hadoop.hdfs.TestQuota
        org.apache.hadoop.hdfs.TestReadWhileWriting
        org.apache.hadoop.hdfs.TestRenameWhileOpen
        org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure
        org.apache.hadoop.hdfs.TestReplication
        org.apache.hadoop.hdfs.TestRestartDFS
        org.apache.hadoop.hdfs.TestSafeMode
        org.apache.hadoop.hdfs.TestSeekBug
        org.apache.hadoop.hdfs.TestSetrepDecreasing
        org.apache.hadoop.hdfs.TestSetrepIncreasing
        org.apache.hadoop.hdfs.TestSetTimes
        org.apache.hadoop.hdfs.TestSmallBlock
        org.apache.hadoop.hdfs.TestWriteConfigurationToDFS
        org.apache.hadoop.hdfs.TestWriteRead
        org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
        org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
        org.apache.hadoop.hdfs.tools.TestGetGroups
        org.apache.hadoop.security.TestPermission
        org.apache.hadoop.security.TestRefreshUserMappings
        org.apache.hadoop.tools.TestJMXGet

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/978//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/978//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/978//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487139/h2167_20110720.patch against trunk revision 1148348. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.fs.loadGenerator.TestLoadGenerator org.apache.hadoop.fs.permission.TestStickyBit org.apache.hadoop.fs.TestFcHdfsCreateMkdir org.apache.hadoop.fs.TestFcHdfsPermission org.apache.hadoop.fs.TestFcHdfsSymlink org.apache.hadoop.fs.TestGlobPaths org.apache.hadoop.fs.TestHDFSFileContextMainOperations org.apache.hadoop.fs.TestResolveHdfsSymlink org.apache.hadoop.fs.TestUrlStreamHandler org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs org.apache.hadoop.fs.viewfs.TestViewFsHdfs org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser org.apache.hadoop.hdfs.security.TestDelegationToken org.apache.hadoop.hdfs.security.token.block.TestBlockToken org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.server.datanode.TestDataNodeExit org.apache.hadoop.hdfs.server.datanode.TestDatanodeJsp org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations org.apache.hadoop.hdfs.server.datanode.TestDataNodeMXBean org.apache.hadoop.hdfs.server.datanode.TestDatanodeRestart org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner org.apache.hadoop.hdfs.server.datanode.TestDiskError org.apache.hadoop.hdfs.server.datanode.TestInterDatanodeProtocol org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes org.apache.hadoop.hdfs.server.datanode.TestTransferRbw org.apache.hadoop.hdfs.server.datanode.TestWriteToReplica org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics org.apache.hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps org.apache.hadoop.hdfs.server.namenode.TestAllowFormat org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.server.namenode.TestBlocksWithNotEnoughRacks org.apache.hadoop.hdfs.server.namenode.TestBlockTokenWithDFS org.apache.hadoop.hdfs.server.namenode.TestBlockUnderConstruction org.apache.hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens org.apache.hadoop.hdfs.server.namenode.TestCheckpoint org.apache.hadoop.hdfs.server.namenode.TestComputeInvalidateWork org.apache.hadoop.hdfs.server.namenode.TestCorruptFilesJsp org.apache.hadoop.hdfs.server.namenode.TestDeadDatanode org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus org.apache.hadoop.hdfs.server.namenode.TestEditLogFileOutputStream org.apache.hadoop.hdfs.server.namenode.TestEditLogRace org.apache.hadoop.hdfs.server.namenode.TestEditLog org.apache.hadoop.hdfs.server.namenode.TestFileLimit org.apache.hadoop.hdfs.server.namenode.TestFsck org.apache.hadoop.hdfs.server.namenode.TestFSEditLogLoader org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks org.apache.hadoop.hdfs.server.namenode.TestMetaSave org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport org.apache.hadoop.hdfs.server.namenode.TestNameNodeJspHelper org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean org.apache.hadoop.hdfs.server.namenode.TestNameNodeResourceChecker org.apache.hadoop.hdfs.server.namenode.TestNodeCount org.apache.hadoop.hdfs.server.namenode.TestOverReplicatedBlocks org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite org.apache.hadoop.hdfs.server.namenode.TestSafeMode org.apache.hadoop.hdfs.server.namenode.TestSecondaryWebUi org.apache.hadoop.hdfs.server.namenode.TestSecurityTokenEditLog org.apache.hadoop.hdfs.server.namenode.TestStartup org.apache.hadoop.hdfs.server.namenode.TestStorageRestore org.apache.hadoop.hdfs.server.namenode.TestStreamFile org.apache.hadoop.hdfs.server.namenode.TestTransferFsImage org.apache.hadoop.hdfs.TestAbandonBlock org.apache.hadoop.hdfs.TestBlockMissingException org.apache.hadoop.hdfs.TestBlocksScheduledCounter org.apache.hadoop.hdfs.TestClientBlockVerification org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery org.apache.hadoop.hdfs.TestClientReportBadBlock org.apache.hadoop.hdfs.TestConnCache org.apache.hadoop.hdfs.TestCrcCorruption org.apache.hadoop.hdfs.TestDatanodeBlockScanner org.apache.hadoop.hdfs.TestDatanodeConfig org.apache.hadoop.hdfs.TestDatanodeDeath org.apache.hadoop.hdfs.TestDatanodeRegistration org.apache.hadoop.hdfs.TestDatanodeReport org.apache.hadoop.hdfs.TestDataTransferProtocol org.apache.hadoop.hdfs.TestDecommission org.apache.hadoop.hdfs.TestDFSAddressConfig org.apache.hadoop.hdfs.TestDFSClientExcludedNodes org.apache.hadoop.hdfs.TestDFSClientRetries org.apache.hadoop.hdfs.TestDFSFinalize org.apache.hadoop.hdfs.TestDFSMkdirs org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.TestDFSPermission org.apache.hadoop.hdfs.TestDFSRemove org.apache.hadoop.hdfs.TestDFSRename org.apache.hadoop.hdfs.TestDFSRollback org.apache.hadoop.hdfs.TestDFSShellGenericOptions org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestDFSStartupVersions org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestDFSUpgradeFromImage org.apache.hadoop.hdfs.TestDFSUpgrade org.apache.hadoop.hdfs.TestDistributedFileSystem org.apache.hadoop.hdfs.TestFileAppend2 org.apache.hadoop.hdfs.TestFileAppend3 org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestFileAppend org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestFileCorruption org.apache.hadoop.hdfs.TestFileCreationClient org.apache.hadoop.hdfs.TestFileCreationDelete org.apache.hadoop.hdfs.TestFileCreationEmpty org.apache.hadoop.hdfs.TestFileCreationNamenodeRestart org.apache.hadoop.hdfs.TestFileCreation org.apache.hadoop.hdfs.TestFileStatus org.apache.hadoop.hdfs.TestFSInputChecker org.apache.hadoop.hdfs.TestFSOutputSummer org.apache.hadoop.hdfs.TestGetBlocks org.apache.hadoop.hdfs.TestHDFSFileSystemContract org.apache.hadoop.hdfs.TestHDFSTrash org.apache.hadoop.hdfs.TestHFlush org.apache.hadoop.hdfs.TestHftpFileSystem org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestLeaseRecovery2 org.apache.hadoop.hdfs.TestLeaseRecovery org.apache.hadoop.hdfs.TestLease org.apache.hadoop.hdfs.TestListFilesInDFS org.apache.hadoop.hdfs.TestListFilesInFileContext org.apache.hadoop.hdfs.TestListPathServlet org.apache.hadoop.hdfs.TestLocalDFS org.apache.hadoop.hdfs.TestMissingBlocksAlert org.apache.hadoop.hdfs.TestModTime org.apache.hadoop.hdfs.TestMultiThreadedHflush org.apache.hadoop.hdfs.TestParallelRead org.apache.hadoop.hdfs.TestPipelines org.apache.hadoop.hdfs.TestPread org.apache.hadoop.hdfs.TestQuota org.apache.hadoop.hdfs.TestReadWhileWriting org.apache.hadoop.hdfs.TestRenameWhileOpen org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure org.apache.hadoop.hdfs.TestReplication org.apache.hadoop.hdfs.TestRestartDFS org.apache.hadoop.hdfs.TestSafeMode org.apache.hadoop.hdfs.TestSeekBug org.apache.hadoop.hdfs.TestSetrepDecreasing org.apache.hadoop.hdfs.TestSetrepIncreasing org.apache.hadoop.hdfs.TestSetTimes org.apache.hadoop.hdfs.TestSmallBlock org.apache.hadoop.hdfs.TestWriteConfigurationToDFS org.apache.hadoop.hdfs.TestWriteRead org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer org.apache.hadoop.hdfs.tools.TestGetGroups org.apache.hadoop.security.TestPermission org.apache.hadoop.security.TestRefreshUserMappings org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/978//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/978//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/978//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Oops, introduced a NPE in the last patch.

        h2167_20110720b.patch: fixed it.

        Show
        Tsz Wo Nicholas Sze added a comment - Oops, introduced a NPE in the last patch. h2167_20110720b.patch: fixed it.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12487151/h2167_20110720b.patch
        against trunk revision 1148348.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.balancer.TestBalancer

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/980//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/980//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/980//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487151/h2167_20110720b.patch against trunk revision 1148348. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.balancer.TestBalancer +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/980//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/980//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/980//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12487151/h2167_20110720b.patch
        against trunk revision 1148348.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/982//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/982//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/982//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487151/h2167_20110720b.patch against trunk revision 1148348. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/982//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/982//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/982//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2167_20110720c.patch: updated with trunk.

        Show
        Tsz Wo Nicholas Sze added a comment - h2167_20110720c.patch: updated with trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12487238/h2167_20110720c.patch
        against trunk revision 1148981.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDatanodeConfig

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/985//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/985//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/985//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487238/h2167_20110720c.patch against trunk revision 1148981. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDatanodeConfig +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/985//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/985//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/985//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -
        1. Can we keep BlockManager#corruptReplicas private?
        2. Is there a jira created to not to use FSNamesystem, FSNamesystem#datanodeMap FSNamesystem#heartbeats for locking in block manager? If not can you please create one?
        3. Should we track with a jira removing references to NameNode.stateChangeLog in blockmanagement package to appropritate logger from blockmanagement package?
        4. Moved code resolveNetworkLocation() no longer has assert hasWriteLock(). What is the locking mechanism for this code?
        5. FSNamesystem#isDatanodeDead(), FSNamesystem#updateStats(), FSNamesystem#blockTokenSecretManager, FSNamesystem#datanodeMap, FSNamesystem#heartbeats should move to blockmanagement package.
        6. getDatanodeListForReport()
          • In jiras moving the code, if the moved code remains the same, it would be easier to review. Case in point - getDatanodeListForReport()
          • Why are doing adding these two sizes final List<DatanodeDescriptor> nodes = new ArrayList<DatanodeDescriptor>(namesystem.datanodeMap.size() + (mustList == null? 0: mustList.size()));
          • Changing mustList from Map to ArrayList is going to slow down removes.
        7. checkDecommissionStateInternal() no longer checks for hasWriteLock()?
        8. DatanodeManager should not have namesystem reference?
        9. In some tests where you have moved from FSNamesystem methods calls to BlockManager method calls, how is the locking that was done in FSNamesystem call done with this change?
        Show
        Suresh Srinivas added a comment - Can we keep BlockManager#corruptReplicas private? Is there a jira created to not to use FSNamesystem, FSNamesystem#datanodeMap FSNamesystem#heartbeats for locking in block manager? If not can you please create one? Should we track with a jira removing references to NameNode.stateChangeLog in blockmanagement package to appropritate logger from blockmanagement package? Moved code resolveNetworkLocation() no longer has assert hasWriteLock() . What is the locking mechanism for this code? FSNamesystem#isDatanodeDead(), FSNamesystem#updateStats(), FSNamesystem#blockTokenSecretManager, FSNamesystem#datanodeMap, FSNamesystem#heartbeats should move to blockmanagement package. getDatanodeListForReport() In jiras moving the code, if the moved code remains the same, it would be easier to review. Case in point - getDatanodeListForReport() Why are doing adding these two sizes final List<DatanodeDescriptor> nodes = new ArrayList<DatanodeDescriptor>(namesystem.datanodeMap.size() + (mustList == null? 0: mustList.size())); Changing mustList from Map to ArrayList is going to slow down removes. checkDecommissionStateInternal() no longer checks for hasWriteLock()? DatanodeManager should not have namesystem reference? In some tests where you have moved from FSNamesystem methods calls to BlockManager method calls, how is the locking that was done in FSNamesystem call done with this change?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        1) Can we keep BlockManager#corruptReplicas private?

        After the replication code is moved the block manager, we can change it back to private.

        2) Is there a jira created to not to use FSNamesystem, FSNamesystem#datanodeMap FSNamesystem#heartbeats for locking in block manager? If not can you please create one?

        I am current simply moving the code but not changing the logic (unless for some obvious cases, e.g. use for-each statement instead of iterator.)

        For improving locking, I have thought about it. How about introduce a ReadWriteLock interface and then FSNamesystem, BlockManager and DatanodeManager implement it? The methods in ReadWriteLock are very similar to the existing methods in FSNamesystem. I have not created a JIRA for it yet.

        3) Should we track with a jira removing references to NameNode.stateChangeLog in blockmanagement package to appropritate logger from blockmanagement package?

        We probably should introduce a stateChangeLog in BlockManager.

        4) Moved code resolveNetworkLocation() no longer has assert hasWriteLock(). What is the locking mechanism for this code?

        FSNamesystem.registerDatanode(..), which has the write-lock, calls DatanodeManager.registerDatanode(..), which is the only method calling resolveNetworkLocation(..). I think the assert statement is not useful. No? We may add the assert statement back when we have read-write lock in DatanodeManager. Again, I am not changing any logic.

        5) FSNamesystem#isDatanodeDead(), FSNamesystem#updateStats(), FSNamesystem#blockTokenSecretManager, FSNamesystem#datanodeMap, FSNamesystem#heartbeats should move to blockmanagement package.

        I am moving the code step-by-step. After this patch, we are ready to move FSNamesystem#datanodeMap and the corresponding methods. I have HDFS-2108 and HDFS-2112 for moving the heartbeat and replication code, respectively. I will see if moving blockTokenSecretManager could be done with replication.

        6) getDatanodeListForReport()
        In jiras moving the code, if the moved code remains the same, it would be easier to review. Case in point - getDatanodeListForReport()

        My bad. I usually don't change any logic but there are too many redundant code there. I tried to simpify it.

        > Why are doing adding these two sizes final List<DatanodeDescriptor> nodes = new ArrayList<DatanodeDescriptor>(namesystem.datanodeMap.size() + (mustList == null? 0: mustList.size()));

        This is existing code. I think the author tried to prevent array resizing.

        > Changing mustList from Map to ArrayList is going to slow down removes.

        Good point, I should use HashSet.

        7) checkDecommissionStateInternal() no longer checks for hasWriteLock()?

        Same as (4), it is an assert statement. Do you think we need it?

        8) DatanodeManager should not have namesystem reference?

        The main reason is for accessing namesystem.datanodeMap. We should remove namesystem once everything is moved to blockmanagement package.

        9) In some tests where you have moved from FSNamesystem methods calls to BlockManager method calls, how is the locking that was done in FSNamesystem call done with this change?

        It is because the same FSNamesystem is moved to BlockManager. I should not have changed any logic.

        Show
        Tsz Wo Nicholas Sze added a comment - 1) Can we keep BlockManager#corruptReplicas private? After the replication code is moved the block manager, we can change it back to private. 2) Is there a jira created to not to use FSNamesystem, FSNamesystem#datanodeMap FSNamesystem#heartbeats for locking in block manager? If not can you please create one? I am current simply moving the code but not changing the logic (unless for some obvious cases, e.g. use for-each statement instead of iterator.) For improving locking, I have thought about it. How about introduce a ReadWriteLock interface and then FSNamesystem, BlockManager and DatanodeManager implement it? The methods in ReadWriteLock are very similar to the existing methods in FSNamesystem. I have not created a JIRA for it yet. 3) Should we track with a jira removing references to NameNode.stateChangeLog in blockmanagement package to appropritate logger from blockmanagement package? We probably should introduce a stateChangeLog in BlockManager. 4) Moved code resolveNetworkLocation() no longer has assert hasWriteLock(). What is the locking mechanism for this code? FSNamesystem.registerDatanode(..), which has the write-lock, calls DatanodeManager.registerDatanode(..), which is the only method calling resolveNetworkLocation(..). I think the assert statement is not useful. No? We may add the assert statement back when we have read-write lock in DatanodeManager. Again, I am not changing any logic. 5) FSNamesystem#isDatanodeDead(), FSNamesystem#updateStats(), FSNamesystem#blockTokenSecretManager, FSNamesystem#datanodeMap, FSNamesystem#heartbeats should move to blockmanagement package. I am moving the code step-by-step. After this patch, we are ready to move FSNamesystem#datanodeMap and the corresponding methods. I have HDFS-2108 and HDFS-2112 for moving the heartbeat and replication code, respectively. I will see if moving blockTokenSecretManager could be done with replication. 6) getDatanodeListForReport() In jiras moving the code, if the moved code remains the same, it would be easier to review. Case in point - getDatanodeListForReport() My bad. I usually don't change any logic but there are too many redundant code there. I tried to simpify it. > Why are doing adding these two sizes final List<DatanodeDescriptor> nodes = new ArrayList<DatanodeDescriptor>(namesystem.datanodeMap.size() + (mustList == null? 0: mustList.size())); This is existing code. I think the author tried to prevent array resizing. > Changing mustList from Map to ArrayList is going to slow down removes. Good point, I should use HashSet. 7) checkDecommissionStateInternal() no longer checks for hasWriteLock()? Same as (4), it is an assert statement. Do you think we need it? 8) DatanodeManager should not have namesystem reference? The main reason is for accessing namesystem.datanodeMap. We should remove namesystem once everything is moved to blockmanagement package. 9) In some tests where you have moved from FSNamesystem methods calls to BlockManager method calls, how is the locking that was done in FSNamesystem call done with this change? It is because the same FSNamesystem is moved to BlockManager. I should not have changed any logic.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Let me revert the my change on getDatanodeListForReport(..) and post the code below for making the change later.

          /** For generating datanode reports */
          public List<DatanodeDescriptor> getDatanodeListForReport(
              final DatanodeReportType type) {
            final boolean listLiveNodes = type == DatanodeReportType.ALL
                                       || type == DatanodeReportType.LIVE;
            final boolean listDeadNodes = type == DatanodeReportType.ALL
                                       || type == DatanodeReportType.DEAD;
        
            Set<String> mustList = null;
            if (listDeadNodes) {
              //first load all the nodes listed in include and exclude files.
              mustList = new HashSet<String>();
              mustList.addAll(hostsReader.getHosts());
              mustList.addAll(hostsReader.getExcludedHosts());
            }
        
            final List<DatanodeDescriptor> nodes = new ArrayList<DatanodeDescriptor>(
                namesystem.datanodeMap.size()
                + (mustList == null? 0: mustList.size()));
            synchronized(namesystem.datanodeMap) {
              for(DatanodeDescriptor dn : namesystem.datanodeMap.values()) { 
                final boolean isDead = namesystem.isDatanodeDead(dn);
                if ( (isDead && listDeadNodes) || (!isDead && listLiveNodes) ) {
                  nodes.add(dn);
                }
                
                if (listDeadNodes) {
                  //Remove any form of the this datanode in include/exclude lists.
                  try {
                    final InetAddress inet = InetAddress.getByName(dn.getHost());
                    // compare hostname(:port)
                    mustList.remove(inet.getHostName());
                    mustList.remove(inet.getHostName() + ":" + dn.getPort());
                    // compare ipaddress(:port)
                    final String add = inet.getHostAddress().toString();
                    mustList.remove(add);
                    mustList.remove(add + ":" + dn.getPort());
                  } catch (UnknownHostException e) {
                    mustList.remove(dn.getName());
                    mustList.remove(dn.getHost());
                    LOG.warn(e);
                  }
                }
              }
            }
        
            if (listDeadNodes) {
              for(String host : mustList) {
                final DatanodeDescriptor dn = new DatanodeDescriptor(
                    new DatanodeID(host));
                dn.setLastUpdate(0);
                nodes.add(dn);
              }
            }
            return nodes;
          }
        
        Show
        Tsz Wo Nicholas Sze added a comment - Let me revert the my change on getDatanodeListForReport(..) and post the code below for making the change later. /** For generating datanode reports */ public List<DatanodeDescriptor> getDatanodeListForReport( final DatanodeReportType type) { final boolean listLiveNodes = type == DatanodeReportType.ALL || type == DatanodeReportType.LIVE; final boolean listDeadNodes = type == DatanodeReportType.ALL || type == DatanodeReportType.DEAD; Set< String > mustList = null ; if (listDeadNodes) { //first load all the nodes listed in include and exclude files. mustList = new HashSet< String >(); mustList.addAll(hostsReader.getHosts()); mustList.addAll(hostsReader.getExcludedHosts()); } final List<DatanodeDescriptor> nodes = new ArrayList<DatanodeDescriptor>( namesystem.datanodeMap.size() + (mustList == null ? 0: mustList.size())); synchronized (namesystem.datanodeMap) { for (DatanodeDescriptor dn : namesystem.datanodeMap.values()) { final boolean isDead = namesystem.isDatanodeDead(dn); if ( (isDead && listDeadNodes) || (!isDead && listLiveNodes) ) { nodes.add(dn); } if (listDeadNodes) { //Remove any form of the this datanode in include/exclude lists. try { final InetAddress inet = InetAddress.getByName(dn.getHost()); // compare hostname(:port) mustList.remove(inet.getHostName()); mustList.remove(inet.getHostName() + ":" + dn.getPort()); // compare ipaddress(:port) final String add = inet.getHostAddress().toString(); mustList.remove(add); mustList.remove(add + ":" + dn.getPort()); } catch (UnknownHostException e) { mustList.remove(dn.getName()); mustList.remove(dn.getHost()); LOG.warn(e); } } } } if (listDeadNodes) { for ( String host : mustList) { final DatanodeDescriptor dn = new DatanodeDescriptor( new DatanodeID(host)); dn.setLastUpdate(0); nodes.add(dn); } } return nodes; }
        Hide
        Tsz Wo Nicholas Sze added a comment -

        1) Can we keep BlockManager#corruptReplicas private?

        After the replication code is moved the block manager, we can change it back to private.

        I moved getNumberOfRacks(..) to BlockManagerTestUtil since it was used by tests only. So I changed corruptReplicas to package private. It is nothing to do with the replication code.

        Show
        Tsz Wo Nicholas Sze added a comment - 1) Can we keep BlockManager#corruptReplicas private? After the replication code is moved the block manager, we can change it back to private. I moved getNumberOfRacks(..) to BlockManagerTestUtil since it was used by tests only. So I changed corruptReplicas to package private. It is nothing to do with the replication code.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2167_20110721.patch: reverted getDatanodeListForReport(..).

        Show
        Tsz Wo Nicholas Sze added a comment - h2167_20110721.patch: reverted getDatanodeListForReport(..) .
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12487286/h2167_20110721.patch
        against trunk revision 1148981.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/987//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/987//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/987//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487286/h2167_20110721.patch against trunk revision 1148981. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/987//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/987//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/987//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        +1 for the change.

        Show
        Suresh Srinivas added a comment - +1 for the change.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #799 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/799/)
        HDFS-2167. Move dnsToSwitchMapping and hostsReader from FSNamesystem to DatanodeManager.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1149455
        Files :

        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/NameNodeAdapter.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSTestUtil.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DecommissionManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #799 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/799/ ) HDFS-2167 . Move dnsToSwitchMapping and hostsReader from FSNamesystem to DatanodeManager. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1149455 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/NameNodeAdapter.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSTestUtil.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DecommissionManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Many thanks Suresh for the review!

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - Many thanks Suresh for the review! I have committed this.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development