Details

    • Hadoop Flags:
      Reviewed

      Description

      Utilities include

      • createNamenode(..), createClientDatanodeProtocolProxy(..);
      • stringifyToken(..); and
      • Random object.
      1. h2161_20110719.patch
        52 kB
        Tsz Wo Nicholas Sze
      2. h2161_20110718.patch
        52 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          5m 31s 1 Tsz Wo Nicholas Sze 18/Jul/11 11:14
          Patch Available Patch Available Resolved Resolved
          1d 5h 52m 1 Tsz Wo Nicholas Sze 19/Jul/11 17:07
          Resolved Resolved Closed Closed
          118d 8h 45m 1 Arun C Murthy 15/Nov/11 00:52
          Gavin made changes -
          Link This issue is depended upon by MAPREDUCE-2710 [ MAPREDUCE-2710 ]
          Gavin made changes -
          Link This issue blocks MAPREDUCE-2710 [ MAPREDUCE-2710 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #730 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/730/)
          HDFS-2161. Move createNamenode(..), createClientDatanodeProtocolProxy(..) and Random object creation to DFSUtil; move DFSClient.stringifyToken(..) to DelegationTokenIdentifier.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148348
          Files :

          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClient.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSTestUtil.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/security/token/block/TestBlockToken.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSUtil.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestReplication.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DfsServlet.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/LeaseRenewer.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #730 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/730/ ) HDFS-2161 . Move createNamenode(..), createClientDatanodeProtocolProxy(..) and Random object creation to DFSUtil; move DFSClient.stringifyToken(..) to DelegationTokenIdentifier. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148348 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSInputStream.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClient.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSTestUtil.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/security/token/block/TestBlockToken.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestReplication.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DfsServlet.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/LeaseRenewer.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #743 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/743/)
          MAPREDUCE-2710. Update JobSubmitter.printTokens(..) for HDFS-2161.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148367
          Files :

          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/JobSubmitter.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #743 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/743/ ) MAPREDUCE-2710 . Update JobSubmitter.printTokens(..) for HDFS-2161 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148367 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/JobSubmitter.java /hadoop/common/trunk/mapreduce/CHANGES.txt
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.23.0 [ 12315571 ]
          Resolution Fixed [ 1 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #748 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/748/)
          MAPREDUCE-2710. Update JobSubmitter.printTokens(..) for HDFS-2161.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148367
          Files :

          • /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/JobSubmitter.java
          • /hadoop/common/trunk/mapreduce/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #748 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/748/ ) MAPREDUCE-2710 . Update JobSubmitter.printTokens(..) for HDFS-2161 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148367 Files : /hadoop/common/trunk/mapreduce/src/java/org/apache/hadoop/mapreduce/JobSubmitter.java /hadoop/common/trunk/mapreduce/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #795 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/795/)
          HDFS-2161. Move createNamenode(..), createClientDatanodeProtocolProxy(..) and Random object creation to DFSUtil; move DFSClient.stringifyToken(..) to DelegationTokenIdentifier.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148348
          Files :

          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClient.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSTestUtil.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/security/token/block/TestBlockToken.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSUtil.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestReplication.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DfsServlet.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/LeaseRenewer.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #795 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/795/ ) HDFS-2161 . Move createNamenode(..), createClientDatanodeProtocolProxy(..) and Random object creation to DFSUtil; move DFSClient.stringifyToken(..) to DelegationTokenIdentifier. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148348 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSInputStream.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClient.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSTestUtil.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/security/token/block/TestBlockToken.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestReplication.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DfsServlet.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/LeaseRenewer.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Tsz Wo Nicholas Sze made changes -
          Link This issue blocks MAPREDUCE-2710 [ MAPREDUCE-2710 ]
          Tsz Wo Nicholas Sze made changes -
          Attachment h2161_20110719.patch [ 12487010 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h2161_20110719.patch: updated with trunk.

          Show
          Tsz Wo Nicholas Sze added a comment - h2161_20110719.patch: updated with trunk.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Uma, thanks for reviewing my patch.

          I have created MAPREDUCE-2710 for updating JobSubmitter.printTokens(..).

          > 1. i did not see any big advantage by moving the random object ...

          My main motivation is to clean up the code. There are many Random objects floating around. In some cases, the object is not used, e.g. HftpFileSystem. In some other cases, there are two objects created in the same class, e.g. FSDataset. I also believe there are synchronization issue – there are race conditions when two threads access the same Random object at the same time. Fortunately, it is very unlikely that why we have not observed the problem.

          > 2. Now stringifyToken moved to DelegationTokenIdentifier ...

          The one in MapReduce may have different fields. So they may need different methods.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Uma, thanks for reviewing my patch. I have created MAPREDUCE-2710 for updating JobSubmitter.printTokens(..) . > 1. i did not see any big advantage by moving the random object ... My main motivation is to clean up the code. There are many Random objects floating around. In some cases, the object is not used, e.g. HftpFileSystem. In some other cases, there are two objects created in the same class, e.g. FSDataset. I also believe there are synchronization issue – there are race conditions when two threads access the same Random object at the same time. Fortunately, it is very unlikely that why we have not observed the problem. > 2. Now stringifyToken moved to DelegationTokenIdentifier ... The one in MapReduce may have different fields. So they may need different methods.
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Nicholas,

          I have reviewd this patch.
          I have checked the referances in Mapreduce & Hbase as well.
          In Above comment, you already mentioned that MapReduce is using that DFSClient.stringifyToken.

           LOG.debug("Submitting with " +
                        DFSClient.stringifyToken((Token<org.apache.hadoop.hdfs.security.token.delegation.DelegationTokenIdentifier>) token));
          

          can we raise one Jira for that in MapReduce?

          +1 Patch looks good to me.
          We should co-ordinate to comitt both(mapred + hdfs issue) at same time to avoid the breakage in Mapreduce.

          small nits,
          1. i did not see any big advantage by moving the random object, other than the object creations. If any big advantage then we will plan ,to move it to common utils. So, that we can change in mapred side also to use .

          2. Now stringifyToken moved to DelegationTokenIdentifier, looks Mepred also has one DelegationTokenIdentifier please check. Can we think some common place for it?

          We can check this nits from Mepreduce issue.

          Show
          Uma Maheswara Rao G added a comment - Hi Nicholas, I have reviewd this patch. I have checked the referances in Mapreduce & Hbase as well. In Above comment, you already mentioned that MapReduce is using that DFSClient.stringifyToken. LOG.debug( "Submitting with " + DFSClient.stringifyToken((Token<org.apache.hadoop.hdfs.security.token.delegation.DelegationTokenIdentifier>) token)); can we raise one Jira for that in MapReduce? +1 Patch looks good to me. We should co-ordinate to comitt both(mapred + hdfs issue) at same time to avoid the breakage in Mapreduce. small nits, 1. i did not see any big advantage by moving the random object, other than the object creations. If any big advantage then we will plan ,to move it to common utils. So, that we can change in mapred side also to use . 2. Now stringifyToken moved to DelegationTokenIdentifier, looks Mepred also has one DelegationTokenIdentifier please check. Can we think some common place for it? We can check this nits from Mepreduce issue.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486809/h2161_20110718.patch
          against trunk revision 1147762.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/958//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/958//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/958//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486809/h2161_20110718.patch against trunk revision 1147762. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/958//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/958//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/958//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486809/h2161_20110718.patch
          against trunk revision 1147762.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.namenode.TestStartup

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/957//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/957//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/957//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486809/h2161_20110718.patch against trunk revision 1147762. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestStartup +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/957//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/957//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/957//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          This is going to break MapReduce since JobSubmitter.printTokens(..) is using DFSClient.stringifyToken(..).

          Show
          Tsz Wo Nicholas Sze added a comment - This is going to break MapReduce since JobSubmitter.printTokens(..) is using DFSClient.stringifyToken(..) .
          Tsz Wo Nicholas Sze made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Component/s balancer [ 12313153 ]
          Component/s data-node [ 12312927 ]
          Component/s hdfs client [ 12312928 ]
          Component/s name-node [ 12312926 ]
          Component/s security [ 12313400 ]
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Attachment h2161_20110718.patch [ 12486809 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h2161_20110718.patch: moved them to DFSUtil and fixed some javac warnings.

          Show
          Tsz Wo Nicholas Sze added a comment - h2161_20110718.patch: moved them to DFSUtil and fixed some javac warnings.
          Tsz Wo Nicholas Sze created issue -

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development