Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2157

Improve header comment in o.a.h.hdfs.server.namenode.NameNode

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: documentation, namenode
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      A developer new to HDFS pointed out to me that the header comment at the top of NameNode.java is a little out of date/inaccurate.

      1. hdfs-2157.1.patch
        3 kB
        Aaron T. Myers
      2. hdfs-2157.0.patch
        3 kB
        Aaron T. Myers

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #729 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/729/)
        HDFS-2157. Improve header comment in o.a.h.hdfs.server.namenode.NameNode. Contributed by Aaron T. Myers

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147980
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #729 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/729/ ) HDFS-2157 . Improve header comment in o.a.h.hdfs.server.namenode.NameNode. Contributed by Aaron T. Myers eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147980 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #792 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/792/)
        HDFS-2157. Improve header comment in o.a.h.hdfs.server.namenode.NameNode. Contributed by Aaron T. Myers

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147980
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #792 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/792/ ) HDFS-2157 . Improve header comment in o.a.h.hdfs.server.namenode.NameNode. Contributed by Aaron T. Myers eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147980 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks atm!

        Show
        Eli Collins added a comment - I've committed this. Thanks atm!
        Hide
        Eli Collins added a comment -

        +1 looks good. ant javadoc and javadoc-dev are clean.

        Show
        Eli Collins added a comment - +1 looks good. ant javadoc and javadoc-dev are clean.
        Tsz Wo Nicholas Sze made changes -
        Component/s documentation [ 12312918 ]
        Aaron T. Myers made changes -
        Attachment hdfs-2157.1.patch [ 12486676 ]
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Eli. Here's a patch addressing your comments.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Eli. Here's a patch addressing your comments.
        Hide
        Eli Collins added a comment -

        +1

        Nits, feel free to address w/o another patch.

        • s/partial namenode's state/partial namenode state/
        • Let's be consistent wrt namenode vs NameNode, this uses both
        Show
        Eli Collins added a comment - +1 Nits, feel free to address w/o another patch. s/partial namenode's state/partial namenode state/ Let's be consistent wrt namenode vs NameNode, this uses both
        Aaron T. Myers made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Aaron T. Myers made changes -
        Field Original Value New Value
        Attachment hdfs-2157.0.patch [ 12486657 ]
        Hide
        Aaron T. Myers added a comment -

        Patch to clean up the comment.

        Show
        Aaron T. Myers added a comment - Patch to clean up the comment.
        Aaron T. Myers created issue -

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development