Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The new test by HDFS-2131 creates files/directories under currently directory.

      1. h2154_20110715.patch
        5 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/726/)
        HDFS-2154. In TestDFSShell, use TEST_ROOT_DIR and fix some deprecated warnings.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147184
        Files :

        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/726/ ) HDFS-2154 . In TestDFSShell, use TEST_ROOT_DIR and fix some deprecated warnings. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147184 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/trunk/hdfs/CHANGES.txt
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Hi Aaron, thanks for the comments. Since the code is in a test, I won't update it for the nits but I will beware them for my future code.

        Show
        Tsz Wo Nicholas Sze added a comment - Hi Aaron, thanks for the comments. Since the code is in a test, I won't update it for the nits but I will beware them for my future code.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #787 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/787/)
        HDFS-2154. In TestDFSShell, use TEST_ROOT_DIR and fix some deprecated warnings.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147184
        Files :

        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #787 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/787/ ) HDFS-2154 . In TestDFSShell, use TEST_ROOT_DIR and fix some deprecated warnings. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147184 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/trunk/hdfs/CHANGES.txt
        Hide
        Uma Maheswara Rao G added a comment -

        2. To form testdir, could you please use the two-argument constructor of java.io.File, rather than string concatenation?

        Here testdir is used to create Path object, not java.io.File . Also testdir used in many places in down the line.
        To get the absolute path from Path again, we may need to use toString on Path. I feel two string concatenation is better than toString construction on Path.

        Show
        Uma Maheswara Rao G added a comment - 2. To form testdir, could you please use the two-argument constructor of java.io.File, rather than string concatenation? Here testdir is used to create Path object, not java.io.File . Also testdir used in many places in down the line. To get the absolute path from Path again, we may need to use toString on Path. I feel two string concatenation is better than toString construction on Path.
        Hide
        Aaron T. Myers added a comment -

        Hey Nicholas, two small nits:

        1. Could you please camel case the variable "testdir" ?
        2. To form testdir, could you please use the two-argument constructor of java.io.File, rather than string concatenation?
        Show
        Aaron T. Myers added a comment - Hey Nicholas, two small nits: Could you please camel case the variable "testdir" ? To form testdir , could you please use the two-argument constructor of java.io.File , rather than string concatenation?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks Uma for reviewing it.

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks Uma for reviewing it. I have committed this.
        Hide
        Uma Maheswara Rao G added a comment -

        Hi Nicholas,

        I have verified with this patch, now files are getting created inside TEST_ROOT_DIR.
        Also you have cleaned the deprecated API usage. - Thanks

        +1 Patch looks good to me.

        Show
        Uma Maheswara Rao G added a comment - Hi Nicholas, I have verified with this patch, now files are getting created inside TEST_ROOT_DIR. Also you have cleaned the deprecated API usage. - Thanks +1 Patch looks good to me.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486572/h2154_20110715.patch
        against trunk revision 1146516.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/942//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/942//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/942//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486572/h2154_20110715.patch against trunk revision 1146516. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/942//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/942//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/942//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2154_20110715.patch: used test dir and fixed some deprecated warnings.

        Show
        Tsz Wo Nicholas Sze added a comment - h2154_20110715.patch: used test dir and fixed some deprecated warnings.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development