Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2153

DFSClientAdapter should be put under test

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DFSClientAdapter is a test utility but it is put in src/java.

      1. h2153_20110715.patch
        7 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2153_20110715.patch: moved it to test and fix some javac warnings in OfflineEditsViewerHelper.

        For committing the patch, please use "svn mv".

        Show
        Tsz Wo Nicholas Sze added a comment - h2153_20110715.patch: moved it to test and fix some javac warnings in OfflineEditsViewerHelper . For committing the patch, please use "svn mv".
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486563/h2153_20110715.patch
        against trunk revision 1146516.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/940//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/940//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/940//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486563/h2153_20110715.patch against trunk revision 1146516. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/940//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/940//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/940//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        +1. Looks like a few other cleanups in this patch though?

        Show
        Todd Lipcon added a comment - +1. Looks like a few other cleanups in this patch though?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Todd, thanks for reviewing it. I also have fixed some javac warnings in OfflineEditsViewerHelper, which is the class using DFSClientAdapter.

        Show
        Tsz Wo Nicholas Sze added a comment - Todd, thanks for reviewing it. I also have fixed some javac warnings in OfflineEditsViewerHelper, which is the class using DFSClientAdapter.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #788 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/788/)
        HDFS-2153. Move DFSClientAdapter to test and fix some javac warnings in OfflineEditsViewerHelper.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147340
        Files :

        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSClientAdapter.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/OfflineEditsViewerHelper.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClientAdapter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #788 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/788/ ) HDFS-2153 . Move DFSClientAdapter to test and fix some javac warnings in OfflineEditsViewerHelper. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147340 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSClientAdapter.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/OfflineEditsViewerHelper.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClientAdapter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/726/)
        HDFS-2153. Move DFSClientAdapter to test and fix some javac warnings in OfflineEditsViewerHelper.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147340
        Files :

        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSClientAdapter.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/OfflineEditsViewerHelper.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClientAdapter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/726/ ) HDFS-2153 . Move DFSClientAdapter to test and fix some javac warnings in OfflineEditsViewerHelper. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147340 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/DFSClientAdapter.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/OfflineEditsViewerHelper.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClientAdapter.java

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development