Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2143

Federation: we should link to the live nodes and dead nodes to cluster web console

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0, 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The dfsclusterhealth page shows the number of live and dead nodes. It would be nice to link those numbers to the page containing the list of those nodes

      1. HDFS-2143.1.patch
        1 kB
        Ravi Prakash
      2. HDFS-2143.2.patch
        2 kB
        Ravi Prakash

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #729 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/729/)
        HDFS-2143. Federation: In cluster web console, add link to namenode page that displays live and dead datanodes. Contributed by Ravi Prakash.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147964
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #729 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/729/ ) HDFS-2143 . Federation: In cluster web console, add link to namenode page that displays live and dead datanodes. Contributed by Ravi Prakash. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147964 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #791 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/791/)
        HDFS-2143. Federation: In cluster web console, add link to namenode page that displays live and dead datanodes. Contributed by Ravi Prakash.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147964
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #791 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/791/ ) HDFS-2143 . Federation: In cluster web console, add link to namenode page that displays live and dead datanodes. Contributed by Ravi Prakash. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147964 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        Hide
        Suresh Srinivas added a comment -

        I committed the patch. Thank you Ravi.

        Show
        Suresh Srinivas added a comment - I committed the patch. Thank you Ravi.
        Hide
        Suresh Srinivas added a comment -

        +1 for the patch.

        Show
        Suresh Srinivas added a comment - +1 for the patch.
        Hide
        Ravi Prakash added a comment -

        Thanks for the review Suresh! I've incorporated your suggested change. Could you please review and commit it?

        Show
        Ravi Prakash added a comment - Thanks for the review Suresh! I've incorporated your suggested change. Could you please review and commit it?
        Hide
        Suresh Srinivas added a comment -

        Nevermind, looking at the code you do not need that change. While reviewing I notices that toXmlItemBlockWithLink() arguments has incorrect names. Could you change the parameter name host to value, and nodetag to label.

        Show
        Suresh Srinivas added a comment - Nevermind, looking at the code you do not need that change. While reviewing I notices that toXmlItemBlockWithLink() arguments has incorrect names. Could you change the parameter name host to value , and nodetag to label .
        Hide
        Suresh Srinivas added a comment -

        Can you please post the web page with this change?

        Show
        Suresh Srinivas added a comment - Can you please post the web page with this change?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486228/HDFS-2143.1.patch
        against trunk revision 1145753.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/911//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/911//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/911//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486228/HDFS-2143.1.patch against trunk revision 1145753. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/911//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/911//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/911//console This message is automatically generated.
        Hide
        Ravi Prakash added a comment -

        This issue was filed by Arpit Gupta

        Currently on the dfsclusterhealth.jsp we show how many nodes are live and dead. It would be nice to have link to the
        page which would show the list of the nodes.

        Rather than user having to click on the namenode and then select the live or dead nodes link if the link is present on
        the dfsclusterhealth page then it saves the user an extra click

        Show
        Ravi Prakash added a comment - This issue was filed by Arpit Gupta Currently on the dfsclusterhealth.jsp we show how many nodes are live and dead. It would be nice to have link to the page which would show the list of the nodes. Rather than user having to click on the namenode and then select the live or dead nodes link if the link is present on the dfsclusterhealth page then it saves the user an extra click
        Hide
        Ravi Prakash added a comment -

        No tests included because I could not find a framework for testing the web interface.
        Please review and commit!

        Show
        Ravi Prakash added a comment - No tests included because I could not find a framework for testing the web interface. Please review and commit!

          People

          • Assignee:
            Ravi Prakash
            Reporter:
            Ravi Prakash
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development