Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. h2140_201107113.patch
      27 kB
      Tsz Wo Nicholas Sze
    2. h2140_20110711b.patch
      27 kB
      Tsz Wo Nicholas Sze
    3. h2140_20110711.patch
      27 kB
      Tsz Wo Nicholas Sze

      Activity

      Hide
      Tsz Wo Nicholas Sze added a comment -

      h2140_20110711: 1st patch.

      Show
      Tsz Wo Nicholas Sze added a comment - h2140_20110711: 1st patch.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12486122/h2140_20110711.patch
      against trunk revision 1145394.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these core unit tests:
      org.apache.hadoop.hdfs.server.namenode.TestBackupNode

      +1 contrib tests. The patch passed contrib unit tests.

      +1 system test framework. The patch passed system test framework compile.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/907//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/907//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/907//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486122/h2140_20110711.patch against trunk revision 1145394. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestBackupNode +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/907//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/907//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/907//console This message is automatically generated.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      h2140_20110711b.patch: added javadoc.

      Show
      Tsz Wo Nicholas Sze added a comment - h2140_20110711b.patch: added javadoc.
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12486133/h2140_20110711b.patch
      against trunk revision 1145394.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      +1 system test framework. The patch passed system test framework compile.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/908//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/908//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/908//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486133/h2140_20110711b.patch against trunk revision 1145394. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/908//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/908//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/908//console This message is automatically generated.
      Hide
      Suresh Srinivas added a comment -

      Comments:

      1. This might be a good opportunity to add some documentation to Host2NodesMap - such as class javadoc.
      2. Also not sure why we call unprotectedAddDatanode? What is unprotected?
      3. Why is synchronization still dependent on namesystem.datanodeMap in DatanodeManager#unprotectedAddDatanode()? We should have follow up items that gets rid of unnecessary reference to namesystem in blockmanagement package.
      Show
      Suresh Srinivas added a comment - Comments: This might be a good opportunity to add some documentation to Host2NodesMap - such as class javadoc. Also not sure why we call unprotectedAddDatanode? What is unprotected? Why is synchronization still dependent on namesystem.datanodeMap in DatanodeManager#unprotectedAddDatanode()? We should have follow up items that gets rid of unnecessary reference to namesystem in blockmanagement package.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      Hi Suresh, thanks for reviewing the patch.

      I intend to have some straightforward changes, moving codes from the namenode package to the block management package. For fixing lock mechanism, let's do it separately.

      I am going to move namesystem.datanodeMap and other datanode related code (registration, heartbeat, etc.) to DatanodeManager. This is going to be a big patch.

      h2140_201107113.patch: added javadoc for Host2NodesMap and renamed unprotectedAddDatanode to addDatanode.

      Show
      Tsz Wo Nicholas Sze added a comment - Hi Suresh, thanks for reviewing the patch. I intend to have some straightforward changes, moving codes from the namenode package to the block management package. For fixing lock mechanism, let's do it separately. I am going to move namesystem.datanodeMap and other datanode related code (registration, heartbeat, etc.) to DatanodeManager. This is going to be a big patch. h2140_201107113.patch: added javadoc for Host2NodesMap and renamed unprotectedAddDatanode to addDatanode.
      Hide
      Suresh Srinivas added a comment -

      +1 for the change. We should create jira for not referencing namesystem in blockmanagement.

      Show
      Suresh Srinivas added a comment - +1 for the change. We should create jira for not referencing namesystem in blockmanagement.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      I have committed this.

      Show
      Tsz Wo Nicholas Sze added a comment - I have committed this.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/785/)
      HDFS-2140. Move Host2NodesMap to the blockmanagement package.

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146514
      Files :

      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/Host2NodesMap.java
      • /hadoop/common/trunk/hdfs/CHANGES.txt
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
      • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/TestHost2NodesMap.java
      • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestHost2NodesMap.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/785/ ) HDFS-2140 . Move Host2NodesMap to the blockmanagement package. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146514 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/Host2NodesMap.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/TestHost2NodesMap.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestHost2NodesMap.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #724 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/724/)
      HDFS-2140. Move Host2NodesMap to the blockmanagement package.

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146514
      Files :

      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/Host2NodesMap.java
      • /hadoop/common/trunk/hdfs/CHANGES.txt
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
      • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/TestHost2NodesMap.java
      • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestHost2NodesMap.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #724 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/724/ ) HDFS-2140 . Move Host2NodesMap to the blockmanagement package. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146514 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/Host2NodesMap.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/Host2NodesMap.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/blockmanagement/TestHost2NodesMap.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestHost2NodesMap.java

        People

        • Assignee:
          Tsz Wo Nicholas Sze
          Reporter:
          Tsz Wo Nicholas Sze
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development