Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Datanode management including DecommissionManager should belong to block management.

      1. h2134_20110711.patch
        14 kB
        Tsz Wo Nicholas Sze
      2. h2134_20110708.patch
        14 kB
        Tsz Wo Nicholas Sze
      3. h2134_20110706.patch
        13 kB
        Tsz Wo Nicholas Sze

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4m 45s 1 Tsz Wo Nicholas Sze 07/Jul/11 02:41
        Patch Available Patch Available Resolved Resolved
        4d 21h 33m 1 Tsz Wo Nicholas Sze 12/Jul/11 00:14
        Resolved Resolved Closed Closed
        126d 1h 38m 1 Arun C Murthy 15/Nov/11 00:53
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #722 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/722/)
        HDFS-2134. Move DecommissionManager to the blockmanagement package.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145393
        Files :

        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DecommissionManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DecommissionManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #722 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/722/ ) HDFS-2134 . Move DecommissionManager to the blockmanagement package. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145393 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DecommissionManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DecommissionManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486115/h2134_20110711.patch
        against trunk revision 1144480.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/906//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/906//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/906//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486115/h2134_20110711.patch against trunk revision 1144480. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/906//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/906//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/906//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #779 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/779/)
        HDFS-2134. Move DecommissionManager to the blockmanagement package.

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145393
        Files :

        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DecommissionManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DecommissionManager.java
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #779 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/779/ ) HDFS-2134 . Move DecommissionManager to the blockmanagement package. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145393 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/DecommissionManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DecommissionManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.23.0 [ 12315571 ]
        Resolution Fixed [ 1 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks Todd for the review.

        For committing it, I will use "svn mv".

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks Todd for the review. For committing it, I will use "svn mv".
        Hide
        Todd Lipcon added a comment -

        +1, seems good to me.

        Show
        Todd Lipcon added a comment - +1, seems good to me.
        Tsz Wo Nicholas Sze made changes -
        Attachment h2134_20110711.patch [ 12486115 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2134_20110711.patch: added @InterfaceAudience.Private and @InterfaceStability.Evolving to DatanodeManager and DecommissionManager.

        Show
        Tsz Wo Nicholas Sze added a comment - h2134_20110711.patch: added @InterfaceAudience.Private and @InterfaceStability.Evolving to DatanodeManager and DecommissionManager .
        Hide
        Todd Lipcon added a comment -

        Do we need to have an interface audience annotation on the new DatanodeManager class? Seems like it should be Private/Evolving?

        Show
        Todd Lipcon added a comment - Do we need to have an interface audience annotation on the new DatanodeManager class? Seems like it should be Private/Evolving?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        The failed test is not related to this.

        Show
        Tsz Wo Nicholas Sze added a comment - The failed test is not related to this.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485775/h2134_20110708.patch
        against trunk revision 1144480.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestHDFSTrash

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/903//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/903//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/903//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485775/h2134_20110708.patch against trunk revision 1144480. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestHDFSTrash +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/903//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/903//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/903//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        -1 @author. The patch appears to contain @author tags which the Hadoop community has agreed to not allow in code contributions.

        There is no author tags in the patch. Something wrong with hudson?!

        Show
        Tsz Wo Nicholas Sze added a comment - -1 @author. The patch appears to contain @author tags which the Hadoop community has agreed to not allow in code contributions. There is no author tags in the patch. Something wrong with hudson?!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485775/h2134_20110708.patch
        against trunk revision 1144100.

        -1 @author. The patch appears to contain @author tags which the Hadoop community has agreed to not allow in code contributions.

        +1 tests included. The patch appears to include new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/902//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485775/h2134_20110708.patch against trunk revision 1144100. -1 @author. The patch appears to contain @author tags which the Hadoop community has agreed to not allow in code contributions. +1 tests included. The patch appears to include new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/902//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485523/h2134_20110706.patch
        against trunk revision 1143147.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/888//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/888//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/888//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485523/h2134_20110706.patch against trunk revision 1143147. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/888//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/888//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/888//console This message is automatically generated.
        Tsz Wo Nicholas Sze made changes -
        Attachment h2134_20110708.patch [ 12485775 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2134_20110708.patch: forgot to call DatanodeManager.activate(..).

        Show
        Tsz Wo Nicholas Sze added a comment - h2134_20110708.patch: forgot to call DatanodeManager.activate(..) .
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Todd, thanks for taking a look. The ordering of thread interrupt should not cause any problem.

        Show
        Tsz Wo Nicholas Sze added a comment - Todd, thanks for taking a look. The ordering of thread interrupt should not cause any problem.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Todd, thanks for taking a look. The ordering of thread interrupt should not cause any problem.

        Show
        Tsz Wo Nicholas Sze added a comment - Todd, thanks for taking a look. The ordering of thread interrupt should not cause any problem.
        Hide
        Todd Lipcon added a comment -

        seems reasonable. no chance that the order in which the threads stop is going to cause a problem, is there? ie now dnthread stops a little earlier than it used to.

        Show
        Todd Lipcon added a comment - seems reasonable. no chance that the order in which the threads stop is going to cause a problem, is there? ie now dnthread stops a little earlier than it used to.
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.23.0 [ 12315571 ]
        Tsz Wo Nicholas Sze made changes -
        Field Original Value New Value
        Attachment h2134_20110706.patch [ 12485523 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h2134_20110706.patch: moving the codes.

        Show
        Tsz Wo Nicholas Sze added a comment - h2134_20110706.patch: moving the codes.
        Tsz Wo Nicholas Sze created issue -

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development