Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2127

Add a test that ensure AccessControlExceptions contain a full path

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-1628 added full paths to AccessControlExceptions, we should have a test that covers the cases that were done manually in this comment.

      1. HDFS-2127.patch
        2 kB
        Stephen Chu
      2. HDFS-2127.patch
        2 kB
        Stephen Chu

        Activity

        Hide
        schu Stephen Chu added a comment -

        Attached a patch that modifies TestPermission.java

        Renamed "testFilePermision()" to "testFilePermission()."

        In testFilePermission(), we invoke an AccessControlException when we call canMkdirs(), canCreate(), and canOpen(). I modified canMkdirs(), canCreate(), canOpen(), and canRename() to check that the AccessControlExceptions contain the absolute paths.

        Show
        schu Stephen Chu added a comment - Attached a patch that modifies TestPermission.java Renamed "testFilePermision()" to "testFilePermission()." In testFilePermission(), we invoke an AccessControlException when we call canMkdirs(), canCreate(), and canOpen(). I modified canMkdirs(), canCreate(), canOpen(), and canRename() to check that the AccessControlExceptions contain the absolute paths.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12547472/HDFS-2127.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.fs.TestHdfsNativeCodeLoader

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3255//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3255//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547472/HDFS-2127.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.TestHdfsNativeCodeLoader +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3255//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3255//console This message is automatically generated.
        Hide
        schu Stephen Chu added a comment -

        org.apache.hadoop.fs.TestHdfsNativeCodeLoader failed perhaps due to HDFS-3753?

        Updated patch with a more concise comment.

        Show
        schu Stephen Chu added a comment - org.apache.hadoop.fs.TestHdfsNativeCodeLoader failed perhaps due to HDFS-3753 ? Updated patch with a more concise comment.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12547506/HDFS-2127.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.fs.TestHdfsNativeCodeLoader

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3258//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3258//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547506/HDFS-2127.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.TestHdfsNativeCodeLoader +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3258//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3258//console This message is automatically generated.
        Hide
        eli Eli Collins added a comment -

        +1 looks great. The test failure is unrelated.

        Show
        eli Eli Collins added a comment - +1 looks great. The test failure is unrelated.
        Hide
        eli Eli Collins added a comment -

        I've committed this. Thanks Stephen!

        Show
        eli Eli Collins added a comment - I've committed this. Thanks Stephen!
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2809 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2809/)
        HDFS-2127. Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2809 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2809/ ) HDFS-2127 . Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2871 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2871/)
        HDFS-2127. Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2871 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2871/ ) HDFS-2127 . Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2832 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2832/)
        HDFS-2127. Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2832 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2832/ ) HDFS-2127 . Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Hide
        10210240089@fudan.edu.cn gongsuochen added a comment -

        unsubscribe

        Show
        10210240089@fudan.edu.cn gongsuochen added a comment - unsubscribe
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1185/)
        HDFS-2127. Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1185/ ) HDFS-2127 . Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1216/)
        HDFS-2127. Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1216/ ) HDFS-2127 . Add a test that ensure AccessControlExceptions contain a full path. Contributed by Stephen Chu (Revision 1393878) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393878 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java

          People

          • Assignee:
            schu Stephen Chu
            Reporter:
            eli Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development