Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2117

DiskChecker#mkdirsWithExistsAndPermissionCheck may return true even when the dir is not created

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.203.1
    • Fix Version/s: 0.20.205.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In branch-0.20-security as part of HADOOP-6566, DiskChecker#mkdirsWithExistsAndPermissionCheck will return true even if it wasn't able to create the directory, which means instead of throwing a DiskErrorException the code will proceed to getFileStatus and throw a FNF exception. Post HADOOP-7040, which modified makeInstance to catch not just DiskErrorExceptions but IOExceptions as well, this is not an issue since now the exception is caught either way. But for future modifications we should still modify this method to return false if it was unable to create the directory. This code is totally different in trunk, so not an issue there.

      1. hdfs-2117-1.patch
        0.4 kB
        Eli Collins

        Issue Links

          Activity

          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Reviewed]
          Eli Collins made changes -
          Link This issue relates to HADOOP-6566 [ HADOOP-6566 ]
          Eli Collins made changes -
          Fix Version/s 0.20.205.0 [ 12316392 ]
          Eli Collins made changes -
          Field Original Value New Value
          Attachment hdfs-2117-1.patch [ 12484742 ]
          Eli Collins created issue -

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development