[HDFS-2117] DiskChecker#mkdirsWithExistsAndPermissionCheck may return true even when the dir is not created

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.20.203.1
• Fix Version/s: 0.20.205.0
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 30/Jun/11 08:46
• Updated: 19/Oct/11 00:26
• Resolved: 03/Aug/11 01:15

Description

In branch-0.20-security as part of HADOOP-6566, DiskChecker#mkdirsWithExistsAndPermissionCheck will return true even if it wasn't able to create the directory, which means instead of throwing a DiskErrorException the code will proceed to getFileStatus and throw a FNF exception. Post HADOOP-7040, which modified makeInstance to catch not just DiskErrorExceptions but IOExceptions as well, this is not an issue since now the exception is caught either way. But for future modifications we should still modify this method to return false if it was unable to create the directory. This code is totally different in trunk, so not an issue there.

Issue Links

• relates to: HADOOP-6566 Hadoop daemons should not start up if the ownership/permissions on the directories used at runtime are misconfigured