Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2110

Some StreamFile and ByteRangeInputStream cleanup

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      StreamFile#sendPartialData can be cleaned up, has some System.out.printlns, no javadoc, and the byte copying method should be pulled out to IOUtils.

      1. hdfs-2110-3.patch
        10 kB
        Eli Collins
      2. hdfs-2110-2.patch
        14 kB
        Eli Collins
      3. hdfs-2110-1.patch
        7 kB
        Eli Collins

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Hide
          Aaron T. Myers added a comment -

          Two tiny nits, otherwise +1:

          1. In java docs, put a blank line between method descriptions and the beginning of the parameter/return/throws list. You did this a little inconsistently in this patch.
          2. In StreamFile, the static references to StreamFile.copyFromOffset(...) need not explicitly specify the class.
          Show
          Aaron T. Myers added a comment - Two tiny nits, otherwise +1: In java docs, put a blank line between method descriptions and the beginning of the parameter/return/throws list. You did this a little inconsistently in this patch. In StreamFile , the static references to StreamFile.copyFromOffset(...) need not explicitly specify the class.
          Hide
          Eli Collins added a comment -

          Thanks atm. Fixed the nits, I'll commit this once Hudson comes back OK.

          Show
          Eli Collins added a comment - Thanks atm. Fixed the nits, I'll commit this once Hudson comes back OK.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12484390/hdfs-2110-2.patch
          against trunk revision 1140030.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/853//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484390/hdfs-2110-2.patch against trunk revision 1140030. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/853//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Right patch.

          Show
          Eli Collins added a comment - Right patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12484391/hdfs-2110-2.patch
          against trunk revision 1140030.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/854//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484391/hdfs-2110-2.patch against trunk revision 1140030. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/854//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12484391/hdfs-2110-2.patch
          against trunk revision 1140030.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/855//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484391/hdfs-2110-2.patch against trunk revision 1140030. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/855//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Just the hdfs side change this time (last patch spanned projects).

          Show
          Eli Collins added a comment - Just the hdfs side change this time (last patch spanned projects).
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12484393/hdfs-2110-1.patch
          against trunk revision 1140030.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/856//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/856//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484393/hdfs-2110-1.patch against trunk revision 1140030. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/856//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/856//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          New IOUtils method in common isn't in maven yet.

          Show
          Eli Collins added a comment - New IOUtils method in common isn't in maven yet.
          Hide
          Eli Collins added a comment -

          Cleanup ByteRangeInputStream as well.

          Show
          Eli Collins added a comment - Cleanup ByteRangeInputStream as well.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12484393/hdfs-2110-1.patch
          against trunk revision 1140030.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/857//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/857//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/857//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484393/hdfs-2110-1.patch against trunk revision 1140030. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/857//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/857//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/857//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          A few tiny formatting nits, otherwise +1:

          1. "resolvedURL.getURL() == null? originalURL: resolvedURL" - put spaces before "?" and ":"
          2. "filelength = cl == null ? -1: Long.parseLong(cl)" - space before ":"
          3. "throw new IOException("HTTP_PARTIAL expected, received "+respCode)" - spaces around "+"
          4. "throw new IOException("HTTP_OK expected, received "+respCode)" - spaces around "+"
          5. ""HTTP_OK expected, received 206"" - replace "206" with "HTTP_PARTIAL" as in the other messages.
          Show
          Aaron T. Myers added a comment - A few tiny formatting nits, otherwise +1: " resolvedURL.getURL() == null? originalURL: resolvedURL " - put spaces before "?" and ":" " filelength = cl == null ? -1: Long.parseLong(cl) " - space before ":" " throw new IOException("HTTP_PARTIAL expected, received "+respCode) " - spaces around "+" " throw new IOException("HTTP_OK expected, received "+respCode) " - spaces around "+" " "HTTP_OK expected, received 206" " - replace "206" with "HTTP_PARTIAL" as in the other messages.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12484399/hdfs-2110-2.patch
          against trunk revision 1140030.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/858//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/858//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484399/hdfs-2110-2.patch against trunk revision 1140030. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/858//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/858//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Thanks atm, punted on the last one since there isn't an HttpUrlConnection method that maps from response code to string. I fixed the other nits and committed.

          Show
          Eli Collins added a comment - Thanks atm, punted on the last one since there isn't an HttpUrlConnection method that maps from response code to string. I fixed the other nits and committed.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #762 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/762/)
          HDFS-2110. StreamFile and ByteRangeInputStream cleanup. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1140694
          Files :

          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #762 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/762/ ) HDFS-2110 . StreamFile and ByteRangeInputStream cleanup. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1140694 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Hide
          Eli Collins added a comment -

          Minor update, parameterize types and use the new close paramter from HADOOP-7429.

          Show
          Eli Collins added a comment - Minor update, parameterize types and use the new close paramter from HADOOP-7429 .
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #710 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/710/)
          HDFS-2110. StreamFile and ByteRangeInputStream cleanup. Contributed by Eli Collins

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1140694
          Files :

          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #710 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/710/ ) HDFS-2110 . StreamFile and ByteRangeInputStream cleanup. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1140694 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Hide
          Aaron T. Myers added a comment -

          +1, patch looks good to me.

          Show
          Aaron T. Myers added a comment - +1, patch looks good to me.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #768 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/768/)
          Minor update to HDFS-2110.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141416
          Files :

          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #768 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/768/ ) Minor update to HDFS-2110 . eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141416 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Eli,
          I just gone through the changes.
          Looks sendPartialData will not clean the streams in all the cases.

             static void sendPartialData(FSInputStream in,
                                        OutputStream out,
                                        HttpServletResponse response,
                                        long contentLength,
                                        List<InclusiveByteRange> ranges,
                                        boolean close)
                throws IOException {
              if (ranges == null || ranges.size() != 1) {
              ...............//we are not closing in this condition    ...............
              } else {
                .............
                copyFromOffset(in, out,
                               singleSatisfiableRange.getFirst(contentLength),
                               singleLength, close);
              }
            }
          
          

          So, there is a chance of leak here.

          Show
          Uma Maheswara Rao G added a comment - Hi Eli, I just gone through the changes. Looks sendPartialData will not clean the streams in all the cases. static void sendPartialData(FSInputStream in, OutputStream out, HttpServletResponse response, long contentLength, List<InclusiveByteRange> ranges, boolean close) throws IOException { if (ranges == null || ranges.size() != 1) { ............... //we are not closing in this condition ............... } else { ............. copyFromOffset(in, out, singleSatisfiableRange.getFirst(contentLength), singleLength, close); } } So, there is a chance of leak here.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #711 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/711/)
          Minor update to HDFS-2110.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141416
          Files :

          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java
          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java
          • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #711 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/711/ ) Minor update to HDFS-2110 . eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141416 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStreamFile.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/HftpFileSystem.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/StreamFile.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
          Hide
          Uma Maheswara Rao G added a comment -

          One more comment to add:

          copyFromOffset(in, out,singleSatisfiableRange.getFirst(contentLength), singleLength, close);

          this api will suppress the stream closure exceptions.
          Before the behaviour is that user will get that stream close related exceptions also.

          Show
          Uma Maheswara Rao G added a comment - One more comment to add: copyFromOffset(in, out,singleSatisfiableRange.getFirst(contentLength), singleLength, close); this api will suppress the stream closure exceptions. Before the behaviour is that user will get that stream close related exceptions also.
          Hide
          Eli Collins added a comment -

          Hey Uma,

          Thanks for taking a look! I updated the patch for HDFS-1753 to address sendPartialData.

          I made the new copyBytes method consistent with the others. How about a new jira to make IOUtils#copy* methods close streams according to the discussion in MAPREDUCE-2243?

          Thanks,
          Eli

          Show
          Eli Collins added a comment - Hey Uma, Thanks for taking a look! I updated the patch for HDFS-1753 to address sendPartialData. I made the new copyBytes method consistent with the others. How about a new jira to make IOUtils#copy* methods close streams according to the discussion in MAPREDUCE-2243 ? Thanks, Eli
          Hide
          Uma Maheswara Rao G added a comment -

          I made the new copyBytes method consistent with the others. How about a new jira to make IOUtils#copy* methods close streams according to the discussion in MAPREDUCE-2243?

          I filed the seperate issue for this. Please review HADOOP-7437.

          Show
          Uma Maheswara Rao G added a comment - I made the new copyBytes method consistent with the others. How about a new jira to make IOUtils#copy* methods close streams according to the discussion in MAPREDUCE-2243 ? I filed the seperate issue for this. Please review HADOOP-7437 .

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development