Minor Description
The use of Socket.isConnected() in DataXceiver.run() is not valid. It returns false until the connection is made and then always returns true after that. It will never return false after the initial connection is successfully made. Socket.isClosed() or SocketChannel.isOpen() should be used instead, assuming someone is handling SocketException and does Socket.close() or SocketChannel.close(). It seems the op handlers in DataXceiver are diligently using IOUtils.closeStream(), which will invoke SocketChannel.close().
- } while (s.isConnected() && socketKeepaliveTimeout > 0); + } while (!s.isClosed() && socketKeepaliveTimeout > 0);
The effect of this bug is very minor, as the socket is read again right after. If the connection was closed, the readOp() will throw an EOFException, which is caught and dealt with properly. The system still functions normally with probably only few microseconds of extra overhead in the premature connection closure cases.
Attachments
Attachments
Issue Links
- is related to
-
HDFS-941 Datanode xceiver protocol should allow reuse of a connection
-
- Closed
-