Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2070

Add more unit tests for FsShell getmerge

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
    • Target Version/s:

      Description

      There is no any automated test for FsShell getmerge in hdfs.
      In regard to reliability and reuse,some automated tests should be added to the test set.

      1. HDFS-2070.001.patch
        6 kB
        Daniel Templeton

        Issue Links

          Activity

          Hide
          Harsh J added a comment -

          Xie,

          Would you be willing to write a patch for this as well?

          Show
          Harsh J added a comment - Xie, Would you be willing to write a patch for this as well?
          Hide
          XieXianshan added a comment -

          My pleasure.
          I will try to do it.

          Show
          XieXianshan added a comment - My pleasure. I will try to do it.
          Hide
          Daniel Templeton added a comment -

          Turns out there was already one getmerge test in the testHDFSConf.xml, but this patch adds a few more to cover all the bases.

          Show
          Daniel Templeton added a comment - Turns out there was already one getmerge test in the testHDFSConf.xml, but this patch adds a few more to cover all the bases.
          Hide
          Daniel Templeton added a comment -

          Ready for review. This should be a quick and easy one.

          Show
          Daniel Templeton added a comment - Ready for review. This should be a quick and easy one.
          Hide
          Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 5m 30s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 55s There were no new javac warning messages.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 native 1m 2s Pre-build of native portion
          -1 hdfs tests 163m 14s Tests failed in hadoop-hdfs.
              180m 4s  



          Reason Tests
          Timed out tests org.apache.hadoop.hdfs.server.datanode.TestBPOfferService



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753015/HDFS-2070.001.patch
          Optional Tests javac unit
          git revision trunk / beb65c9
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12197/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12197/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12197/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 native 1m 2s Pre-build of native portion -1 hdfs tests 163m 14s Tests failed in hadoop-hdfs.     180m 4s   Reason Tests Timed out tests org.apache.hadoop.hdfs.server.datanode.TestBPOfferService Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753015/HDFS-2070.001.patch Optional Tests javac unit git revision trunk / beb65c9 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12197/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12197/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12197/console This message was automatically generated.
          Hide
          Daniel Templeton added a comment -

          TestBPOfferService is unrelated to this patch. This one's ready for review.

          Show
          Daniel Templeton added a comment - TestBPOfferService is unrelated to this patch. This one's ready for review.
          Hide
          Colin P. McCabe added a comment -

          +1. Thanks, Daniel Templeton.

          Show
          Colin P. McCabe added a comment - +1. Thanks, Daniel Templeton .
          Hide
          Colin P. McCabe added a comment -

          Committed to 2.8, thanks.

          Show
          Colin P. McCabe added a comment - Committed to 2.8, thanks.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8388 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8388/)
          HDFS-2070. Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8388 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8388/ ) HDFS-2070 . Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1071 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1071/)
          HDFS-2070. Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1071 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1071/ ) HDFS-2070 . Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #326 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/326/)
          HDFS-2070. Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #326 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/326/ ) HDFS-2070 . Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #336 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/336/)
          HDFS-2070. Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #336 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/336/ ) HDFS-2070 . Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #343 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/343/)
          HDFS-2070. Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #343 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/343/ ) HDFS-2070 . Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2285 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2285/)
          HDFS-2070. Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2285 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2285/ ) HDFS-2070 . Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2265 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2265/)
          HDFS-2070. Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2265 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2265/ ) HDFS-2070 . Add more unit tests for FsShell getmerge (Daniel Templeton via Colin P. McCabe) (cmccabe: rev c006c3a1e6d3631c5724e1eb0a0b620d9f7c8dcc) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              Daniel Templeton
              Reporter:
              XieXianshan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development