Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: datanode, hdfs-client, namenode
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      DataTransferProtocol contains quite a few classes. It is better to create a package and put the classes into individual files.

      1. h2066_20110610.patch
        117 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          h2066_20110610.patch: created a package.

          Show
          Tsz Wo Nicholas Sze added a comment - h2066_20110610.patch: created a package.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12482128/h2066_20110610.patch
          against trunk revision 1134492.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 30 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.cli.TestHDFSCLI

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/772//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/772//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/772//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482128/h2066_20110610.patch against trunk revision 1134492. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 30 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/772//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/772//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/772//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          +1, looks good to me.

          Show
          Todd Lipcon added a comment - +1, looks good to me.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          For committing this, we should first svn mv DataTransferProtocol.java and DataTransferProtoUtil.java.

          Let's wait for HDFS-2067.

          Show
          Tsz Wo Nicholas Sze added a comment - For committing this, we should first svn mv DataTransferProtocol.java and DataTransferProtoUtil.java. Let's wait for HDFS-2067 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Thanks Todd for the review.

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - Thanks Todd for the review. I have committed this.
          Hide
          XieXianshan added a comment -

          A little question.
          Why did this patch not contain the following java files?

          • mapreduce/src/contrib/raid/src/java/org/apache/hadoop/raid/BlockFixer.java
          • mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/datanode/RaidBlockSender.java

          The class DataTransferProtocol has also been imported in these files.

          Show
          XieXianshan added a comment - A little question. Why did this patch not contain the following java files? mapreduce/src/contrib/raid/src/java/org/apache/hadoop/raid/BlockFixer.java mapreduce/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/datanode/RaidBlockSender.java The class DataTransferProtocol has also been imported in these files.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Xie, thanks for pointing it out. It was fixed by MAPREDUCE-2588 earlier today.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Xie, thanks for pointing it out. It was fixed by MAPREDUCE-2588 earlier today.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #746 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/746/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #746 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/746/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #699 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #699 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/ )

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development