Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2057

Wait time to terminate the threads causing unit tests to take longer time

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.204.0, 0.20.205.0
    • Fix Version/s: 0.20.204.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As a part of datanode process hang, this part of code was introduced in 0.20.204 to clean up all the waiting threads.

      • try { - readPool.awaitTermination(10, TimeUnit.SECONDS); - }

        catch (InterruptedException e)

        { - LOG.info("Exception occured in doStop:" + e.getMessage()); - }
      • readPool.shutdownNow();

      This was clearly meant for production, but all the unit tests uses minidfscluster and minimrcluster for shutdown which waits on this part of the code. Due to this, we saw increase in unit test run times. So removing this code.

      1. HDFS-2057-1.patch
        0.6 kB
        Bharath Mundlapudi

        Activity

        Hide
        Bharath Mundlapudi added a comment -

        Attaching the patch.

        Show
        Bharath Mundlapudi added a comment - Attaching the patch.
        Hide
        Suresh Srinivas added a comment -

        This is reverting back to the previous code. +1 for the patch.

        Show
        Suresh Srinivas added a comment - This is reverting back to the previous code. +1 for the patch.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to 204, 205 and branch-0.20-security. Thank you Bharath.

        Show
        Suresh Srinivas added a comment - I committed the patch to 204, 205 and branch-0.20-security. Thank you Bharath.
        Hide
        Owen O'Malley added a comment -

        Hadoop 0.20.204.0 was released.

        Show
        Owen O'Malley added a comment - Hadoop 0.20.204.0 was released.

          People

          • Assignee:
            Bharath Mundlapudi
            Reporter:
            Bharath Mundlapudi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development