Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: libhdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Add hdfsHFlush to libhdfs.

      Description

      libhdfs would be improved by adding support for hflush.

      1. HDFS-2055.r2.patch
        2 kB
        Travis Crawford

        Activity

        Travis Crawford created issue -
        Hide
        Travis Crawford added a comment -

        Add hdfsHFlush to libhdfs.

        Its also viewable here which might be easier to read:

        https://github.com/traviscrawford/hadoop-hdfs/compare/apache:trunk...HDFS-2055_Add_hflush_support_to_libhdfs

        Show
        Travis Crawford added a comment - Add hdfsHFlush to libhdfs. Its also viewable here which might be easier to read: https://github.com/traviscrawford/hadoop-hdfs/compare/apache:trunk...HDFS-2055_Add_hflush_support_to_libhdfs
        Travis Crawford made changes -
        Field Original Value New Value
        Attachment HDFS-2055.patch [ 12482015 ]
        Travis Crawford made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note Add hdfsHFlush to libhdfs.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482015/HDFS-2055.patch
        against trunk revision 1134170.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/759//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482015/HDFS-2055.patch against trunk revision 1134170. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/759//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Travis - thanks for contributing!

        Patch looks good. Minor things..

        You'll need to generate the diff using the git --no-prefix option.

        Please add a test to src/c+/libhdfs/hdfs_test.c. Unfortunately the libhdfs test is currently broken on trunk (HDFS-2063) but it works on branch-0.20 so you can try there (arg, sorry). The command to run the libhdfs test is ant -Dcompile.c+=true -Dlibhdfs=true compile test. Have you done any other testing?

        Nit: the @param/return javadoc comments should start w lowercase and not end in a period. Also good to indicate that errno is set accordingly.

        Show
        Eli Collins added a comment - Travis - thanks for contributing! Patch looks good. Minor things.. You'll need to generate the diff using the git --no-prefix option. Please add a test to src/c+ /libhdfs/hdfs_test.c. Unfortunately the libhdfs test is currently broken on trunk ( HDFS-2063 ) but it works on branch-0.20 so you can try there (arg, sorry). The command to run the libhdfs test is ant -Dcompile.c +=true -Dlibhdfs=true compile test . Have you done any other testing? Nit: the @param/return javadoc comments should start w lowercase and not end in a period. Also good to indicate that errno is set accordingly.
        Eli Collins made changes -
        Assignee Travis Crawford [ traviscrawford ]
        Travis Crawford made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Travis Crawford made changes -
        Attachment HDFS-2055.patch [ 12482015 ]
        Hide
        Travis Crawford added a comment -

        Updated patch per comments: added test, and tweaked comment.

        Show
        Travis Crawford added a comment - Updated patch per comments: added test, and tweaked comment.
        Travis Crawford made changes -
        Attachment HDFS-2055.r2.patch [ 12482311 ]
        Travis Crawford made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Travis Crawford added a comment -

        @eli - I haven't done additional tests on this specific version of the patch, however, its derived from and very similar to https://issues.cloudera.org/browse/DISTRO-257 which I have tested by updating Scribe with hdfsSync.

        Thanks for fixing the test runner, btw. I had some local jank in place to test and that fix greatly simplified things

        Show
        Travis Crawford added a comment - @eli - I haven't done additional tests on this specific version of the patch, however, its derived from and very similar to https://issues.cloudera.org/browse/DISTRO-257 which I have tested by updating Scribe with hdfsSync . Thanks for fixing the test runner, btw. I had some local jank in place to test and that fix greatly simplified things
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482311/HDFS-2055.r2.patch
        against trunk revision 1134955.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.hdfs.TestFileCreationNamenodeRestart

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/777//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/777//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/777//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482311/HDFS-2055.r2.patch against trunk revision 1134955. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.TestFileCreationNamenodeRestart +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/777//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/777//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/777//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        This looks good to me. Eli?

        Show
        Todd Lipcon added a comment - This looks good to me. Eli?
        Hide
        Eli Collins added a comment -

        +1

        I'll commit this. Thanks Travis!

        Show
        Eli Collins added a comment - +1 I'll commit this. Thanks Travis!
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks Travis!

        Show
        Eli Collins added a comment - I've committed this. Thanks Travis!
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.23.0 [ 12315571 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #749 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/749/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #749 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/749/ )
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Travis Crawford
            Reporter:
            Travis Crawford
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development