Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Post HDFS-1963 ant binary fails w/ the following. The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++-libhdfs (since this is the binary target).

      /home/eli/src/hdfs4/build.xml:1115: /home/eli/src/hdfs4/build/c++/Linux-amd64-64/lib not found.
      
      1. HDFS-2022-1.patch
        2 kB
        Eric Yang
      2. HDFS-2022.patch
        0.7 kB
        Eric Yang

        Issue Links

          Activity

          Eli Collins created issue -
          Eli Collins made changes -
          Field Original Value New Value
          Link This issue is related to HDFS-1963 [ HDFS-1963 ]
          Hide
          Owen O'Malley added a comment -

          It sounds reasonable for the bin-package depend on the compile-c++-libhdfs.

          Show
          Owen O'Malley added a comment - It sounds reasonable for the bin-package depend on the compile-c++-libhdfs.
          Owen O'Malley made changes -
          Link This issue is related to MAPREDUCE-2559 [ MAPREDUCE-2559 ]
          Hide
          Eric Yang added a comment -

          Modifies binary target to depend on compile-c++-libhdfs target.

          Show
          Eric Yang added a comment - Modifies binary target to depend on compile-c++-libhdfs target.
          Eric Yang made changes -
          Attachment HDFS-2022.patch [ 12481257 ]
          Eric Yang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Eric Yang [ eyang ]
          Hide
          Eli Collins added a comment -

          Nit: perhaps rename "set-compile-c+-flag" "set-c+-libhdfs" since it just sets islibhdfs.

          Can we remove "check-c++-libhdfs" entirely? It looks like it doesn't do anything since it's used in the depends attribute of the target, and the if attribute already checks islibhdfs.

          Show
          Eli Collins added a comment - Nit: perhaps rename "set-compile-c+ -flag" "set-c +-libhdfs" since it just sets islibhdfs. Can we remove "check-c++-libhdfs" entirely? It looks like it doesn't do anything since it's used in the depends attribute of the target, and the if attribute already checks islibhdfs.
          Hide
          Eric Yang added a comment -

          Rename:

          set-compile-c++-flag

          to

          set-c++-libhdfs

          Remove

          check-c++-libhdfs

          , as long as libhdfs is defined, then it will compile libhdfs libraries.

          Show
          Eric Yang added a comment - Rename: set-compile-c++-flag to set-c++-libhdfs Remove check-c++-libhdfs , as long as libhdfs is defined, then it will compile libhdfs libraries.
          Eric Yang made changes -
          Attachment HDFS-2022-1.patch [ 12481270 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481257/HDFS-2022.patch
          against trunk revision 1130667.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.namenode.TestBackupNode

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/689//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/689//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/689//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481257/HDFS-2022.patch against trunk revision 1130667. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestBackupNode +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/689//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/689//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/689//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          +1 lgtm

          TestBackupNode failure is unrelated. This doesn't need a test since it's a build change. I built locally and verified the binary tarball contains libhdfs.

          Show
          Eli Collins added a comment - +1 lgtm TestBackupNode failure is unrelated. This doesn't need a test since it's a build change. I built locally and verified the binary tarball contains libhdfs.
          Eli Collins made changes -
          Summary ant binary fails due to missing c++ lib dir ant binary should build libhdfs
          Hadoop Flags [Reviewed]
          Hide
          Eli Collins added a comment -

          I've committed this. Thanks Eric!

          Show
          Eli Collins added a comment - I've committed this. Thanks Eric!
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #706 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/706/)
          HDFS-2022. ant binary should build libhdfs. Contributed by Eric Yang

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130734
          Files :

          • /hadoop/hdfs/trunk/build.xml
          • /hadoop/hdfs/trunk/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #706 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/706/ ) HDFS-2022 . ant binary should build libhdfs. Contributed by Eric Yang eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130734 Files : /hadoop/hdfs/trunk/build.xml /hadoop/hdfs/trunk/CHANGES.txt
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481270/HDFS-2022-1.patch
          against trunk revision 1130693.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestLeaseRenewer

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/691//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/691//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/691//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481270/HDFS-2022-1.patch against trunk revision 1130693. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestLeaseRenewer +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/691//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/691//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/691//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/686/)
          HDFS-2022. ant binary should build libhdfs. Contributed by Eric Yang

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130734
          Files :

          • /hadoop/hdfs/trunk/build.xml
          • /hadoop/hdfs/trunk/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/686/ ) HDFS-2022 . ant binary should build libhdfs. Contributed by Eric Yang eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130734 Files : /hadoop/hdfs/trunk/build.xml /hadoop/hdfs/trunk/CHANGES.txt
          Eli Collins made changes -
          Link This issue is related to HDFS-2040 [ HDFS-2040 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Eric Yang
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development