Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-1996

ivy: hdfs test jar should be independent to common test jar

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      hdfs tests and common tests may require different libraries, e.g. common tests need ftpserver for testing FTPFileSystem but hdfs does not.

      1. HDFS-1996.patch
        0.8 kB
        Eric Yang
      2. HDFS-1996-1.patch
        1 kB
        Eric Yang

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/678/)
        HDFS-1996. ivy: hdfs test jar should be independent to common test jar. Contributed by Eric Yang

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127759
        Files :

        • /hadoop/hdfs/trunk/CHANGES.txt
        • /hadoop/hdfs/trunk/ivy.xml
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/678/ ) HDFS-1996 . ivy: hdfs test jar should be independent to common test jar. Contributed by Eric Yang szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127759 Files : /hadoop/hdfs/trunk/CHANGES.txt /hadoop/hdfs/trunk/ivy.xml
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/686/)
        HDFS-1996. ivy: hdfs test jar should be independent to common test jar. Contributed by Eric Yang

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127759
        Files :

        • /hadoop/hdfs/trunk/CHANGES.txt
        • /hadoop/hdfs/trunk/ivy.xml
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/686/ ) HDFS-1996 . ivy: hdfs test jar should be independent to common test jar. Contributed by Eric Yang szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127759 Files : /hadoop/hdfs/trunk/CHANGES.txt /hadoop/hdfs/trunk/ivy.xml
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Eric!

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Eric!
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480486/HDFS-1996-1.patch
        against trunk revision 1127712.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/625//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/625//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/625//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480486/HDFS-1996-1.patch against trunk revision 1127712. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/625//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/625//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/625//console This message is automatically generated.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        eyang Eric Yang added a comment -

        Change mockit to test->master. Thanks Nicholas.

        Show
        eyang Eric Yang added a comment - Change mockit to test->master. Thanks Nicholas.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        Could you also change mockito from common->master to test->master?

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - Could you also change mockito from common->master to test->master?
        Hide
        eyang Eric Yang added a comment -

        Declare junit as direct dependency for hdfs test ivy profile.

        Show
        eyang Eric Yang added a comment - Declare junit as direct dependency for hdfs test ivy profile.
        Hide
        eyang Eric Yang added a comment -

        Make sure hdfs test profile contains junit jar file because it is a direct dependency.

        Show
        eyang Eric Yang added a comment - Make sure hdfs test profile contains junit jar file because it is a direct dependency.

          People

          • Assignee:
            eyang Eric Yang
            Reporter:
            szetszwo Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development