Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1995

Minor modification to both dfsclusterhealth and dfshealth pages for Web UI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Four small modifications/fixes:
      on dfshealthpage:
      1) fix remaining% to be remaining / total ( it was mistaken as used / total)
      on dfsclusterhealth page:
      1) makes the table header 8em wide
      2) fix the typo(inconsistency) Total Files and Blocks => Total Files and Directories
      3) make the DFS Used = sum of block pool used space of every name space. And change the label names accordingly.

      1. HDFS-1995.3.patch
        6 kB
        Tanping Wang
      2. OneNN.png
        113 kB
        Tanping Wang
      3. ClusterSummary-2.png
        68 kB
        Tanping Wang
      4. HDFS-1995.2.patch
        6 kB
        Tanping Wang
      5. HDFS-1995.patch
        5 kB
        Tanping Wang

        Activity

        Hide
        Tanping Wang added a comment -

        Upload a screen shot after the fixes.

        Show
        Tanping Wang added a comment - Upload a screen shot after the fixes.
        Hide
        Tanping Wang added a comment -

        Upload the screen shot one of the name nodes UI. Name node UI lay out does not change. (Changed the calculation of remaining%.)

        Capacity, DFS used, DFS remaining... etc. is consistent with Cluster Summary page.

        Show
        Tanping Wang added a comment - Upload the screen shot one of the name nodes UI. Name node UI lay out does not change. (Changed the calculation of remaining%.) Capacity, DFS used, DFS remaining... etc. is consistent with Cluster Summary page.
        Hide
        Tanping Wang added a comment -

        Rename on Cluster Summary page:
        Remaining => DFS Remaining
        Remaining% => DFS Remaining%
        to be consistent with name node UI page

        Show
        Tanping Wang added a comment - Rename on Cluster Summary page: Remaining => DFS Remaining Remaining% => DFS Remaining% to be consistent with name node UI page
        Hide
        Tanping Wang added a comment -

        Ran test-patch and find bug caught one warning. Removing an unread field: org.apache.hadoop.hdfs.server.namenode.ClusterJspHelper$NamenodeStatus.clusterDfsUsed

        Show
        Tanping Wang added a comment - Ran test-patch and find bug caught one warning. Removing an unread field: org.apache.hadoop.hdfs.server.namenode.ClusterJspHelper$NamenodeStatus.clusterDfsUsed
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481178/HDFS-1995.3.patch
        against trunk revision 1130381.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/688//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/688//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/688//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481178/HDFS-1995.3.patch against trunk revision 1130381. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/688//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/688//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/688//console This message is automatically generated.
        Hide
        Tanping Wang added a comment -

        No unit test included because these are fixes to UI.

        Show
        Tanping Wang added a comment - No unit test included because these are fixes to UI.
        Hide
        Suresh Srinivas added a comment -

        +1 for the change.

        Show
        Suresh Srinivas added a comment - +1 for the change.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch. Thank you Tanping.

        Show
        Suresh Srinivas added a comment - I committed the patch. Thank you Tanping.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #708 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/708/)
        HDFS-1995. Federation: Minor bug fixes and modification cluster web UI. Contributed by Tanping Wang.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130855
        Files :

        • /hadoop/hdfs/trunk/src/webapps/hdfs/dfsclusterhealth.xsl
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        • /hadoop/hdfs/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #708 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/708/ ) HDFS-1995 . Federation: Minor bug fixes and modification cluster web UI. Contributed by Tanping Wang. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130855 Files : /hadoop/hdfs/trunk/src/webapps/hdfs/dfsclusterhealth.xsl /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java /hadoop/hdfs/trunk/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/686/)
        HDFS-1995. Federation: Minor bug fixes and modification cluster web UI. Contributed by Tanping Wang.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130855
        Files :

        • /hadoop/hdfs/trunk/src/webapps/hdfs/dfsclusterhealth.xsl
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        • /hadoop/hdfs/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/686/ ) HDFS-1995 . Federation: Minor bug fixes and modification cluster web UI. Contributed by Tanping Wang. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130855 Files : /hadoop/hdfs/trunk/src/webapps/hdfs/dfsclusterhealth.xsl /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java /hadoop/hdfs/trunk/CHANGES.txt

          People

          • Assignee:
            Tanping Wang
            Reporter:
            Tanping Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development