Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1986

Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.

      1. HDFS-1986.patch
        5 kB
        Tanping Wang
      2. HDFS-1986.2.patch
        5 kB
        Tanping Wang

        Activity

        Hide
        Suresh Srinivas added a comment -

        Comments:

        1. TestDFSUtil.java - InetSocketAddress is = new InetSocketAddress(1234); I am not clear how this maps to namenode address?
        2. DFSUtil.java - checkSecurity could be named httpsAddress. @param checkSecurity needs to be reworded. The method returns an address and not port. @return needs to be reworded too.
        Show
        Suresh Srinivas added a comment - Comments: TestDFSUtil.java - InetSocketAddress is = new InetSocketAddress(1234); I am not clear how this maps to namenode address? DFSUtil.java - checkSecurity could be named httpsAddress . @param checkSecurity needs to be reworded. The method returns an address and not port. @return needs to be reworded too.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480182/HDFS-1986.patch
        against trunk revision 1129942.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSUpgradeFromImage

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480182/HDFS-1986.patch against trunk revision 1129942. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSUpgradeFromImage +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//console This message is automatically generated.
        Hide
        Tanping Wang added a comment -

        upload patch to address review comments.

        Show
        Tanping Wang added a comment - upload patch to address review comments.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481281/HDFS-1986.2.patch
        against trunk revision 1130734.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481281/HDFS-1986.2.patch against trunk revision 1130734. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        +1 for the change

        Show
        Suresh Srinivas added a comment - +1 for the change
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #709 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/709/)
        HDFS-1986. Add option to get http/https address from DFSUtil#getInfoServer(). Contributed by Tanping Wang.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130870
        Files :

        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSUtil.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • /hadoop/hdfs/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #709 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/709/ ) HDFS-1986 . Add option to get http/https address from DFSUtil#getInfoServer(). Contributed by Tanping Wang. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130870 Files : /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSck.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSUtil.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java /hadoop/hdfs/trunk/CHANGES.txt
        Hide
        Suresh Srinivas added a comment -

        I committed the patch. Thank you Tanping.

        Show
        Suresh Srinivas added a comment - I committed the patch. Thank you Tanping.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/686/)
        HDFS-1986. Add option to get http/https address from DFSUtil#getInfoServer(). Contributed by Tanping Wang.

        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130870
        Files :

        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSUtil.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • /hadoop/hdfs/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/686/ ) HDFS-1986 . Add option to get http/https address from DFSUtil#getInfoServer(). Contributed by Tanping Wang. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130870 Files : /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSck.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSUtil.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java /hadoop/hdfs/trunk/CHANGES.txt

          People

          • Assignee:
            Tanping Wang
            Reporter:
            Tanping Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development