Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1980

Move build/webapps deeper in directory heirarchy to aid eclipse users

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".

      If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

      1. hdfs-1980.txt
        4 kB
        Todd Lipcon
      2. hdfs-1980.txt
        2 kB
        Todd Lipcon
      3. hdfs-1980-1.patch
        4 kB
        Eli Collins

        Activity

        Todd Lipcon created issue -
        Hide
        Todd Lipcon added a comment -

        With the attached patch, you can run "ant eclipse" and the resulting project will be able to run unit tests with no extra build path configuration.

        Show
        Todd Lipcon added a comment - With the attached patch, you can run "ant eclipse" and the resulting project will be able to run unit tests with no extra build path configuration.
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hdfs-1980.txt [ 12480081 ]
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Eli Collins added a comment -

        Why do we need both build/web/webapps and build/webapps, ie can we just have build/web/webapps?

        Why not use build.webapps.root.dir below?

          <library path="${build.webapps}/.." exported="false" />
        

        Btw I normally add the src directory (src/webapps parent) to the classpath instead of the build directory. Agree it's better to address this way.

        Show
        Eli Collins added a comment - Why do we need both build/web/webapps and build/webapps, ie can we just have build/web/webapps? Why not use build.webapps.root.dir below? <library path="${build.webapps}/.." exported="false" /> Btw I normally add the src directory (src/webapps parent) to the classpath instead of the build directory. Agree it's better to address this way.
        Hide
        Todd Lipcon added a comment -

        Why do we need both build/web/webapps and build/webapps, ie can we just have build/web/webapps?

        hmm, is build/webapps still used somewhere?

        Why not use build.webapps.root.dir below?

        oops, I agree.

        Show
        Todd Lipcon added a comment - Why do we need both build/web/webapps and build/webapps, ie can we just have build/web/webapps? hmm, is build/webapps still used somewhere? Why not use build.webapps.root.dir below? oops, I agree.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480081/hdfs-1980.txt
        against trunk revision 1125879.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480081/hdfs-1980.txt against trunk revision 1125879. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Updated based on Eli's feedback. Also found some spots in contrib that needed updating.

        Show
        Todd Lipcon added a comment - Updated based on Eli's feedback. Also found some spots in contrib that needed updating.
        Todd Lipcon made changes -
        Attachment hdfs-1980.txt [ 12480815 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480815/hdfs-1980.txt
        against trunk revision 1128986.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480815/hdfs-1980.txt against trunk revision 1128986. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1

        Uploading patch that applies to trunk.

        Show
        Eli Collins added a comment - +1 Uploading patch that applies to trunk.
        Eli Collins made changes -
        Attachment hdfs-1980-1.patch [ 12481589 ]
        Hide
        Eli Collins added a comment -

        The test failure above is unrelated.

        Show
        Eli Collins added a comment - The test failure above is unrelated.
        Hide
        Todd Lipcon added a comment -

        Committed to trunk and 22, thanks for reviewing, Eli.

        Show
        Todd Lipcon added a comment - Committed to trunk and 22, thanks for reviewing, Eli.
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481589/hdfs-1980-1.patch
        against trunk revision 1132698.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481589/hdfs-1980-1.patch against trunk revision 1132698. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #716 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/716/)
        HDFS-1980. Move build/webapps deeper in the build directory heirarchy to aid eclipse users. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132715
        Files :

        • /hadoop/hdfs/trunk/build.xml
        • /hadoop/hdfs/trunk/src/c++/libhdfs/tests/test-libhdfs.sh
        • /hadoop/hdfs/trunk/bin/hdfs
        • /hadoop/hdfs/trunk/src/contrib/hdfsproxy/bin/proxy-util
        • /hadoop/hdfs/trunk/src/contrib/hdfsproxy/bin/hdfsproxy
        • /hadoop/hdfs/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #716 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/716/ ) HDFS-1980 . Move build/webapps deeper in the build directory heirarchy to aid eclipse users. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132715 Files : /hadoop/hdfs/trunk/build.xml /hadoop/hdfs/trunk/src/c++/libhdfs/tests/test-libhdfs.sh /hadoop/hdfs/trunk/bin/hdfs /hadoop/hdfs/trunk/src/contrib/hdfsproxy/bin/proxy-util /hadoop/hdfs/trunk/src/contrib/hdfsproxy/bin/hdfsproxy /hadoop/hdfs/trunk/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-22-branch #62 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/62/)
        HDFS-1980. Move build/webapps deeper in the build directory heirarchy to aid eclipse users. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132714
        Files :

        • /hadoop/hdfs/branches/branch-0.22/src/c++/libhdfs/tests/test-libhdfs.sh
        • /hadoop/hdfs/branches/branch-0.22/src/contrib/hdfsproxy/bin/hdfsproxy
        • /hadoop/hdfs/branches/branch-0.22/CHANGES.txt
        • /hadoop/hdfs/branches/branch-0.22/bin/hdfs
        • /hadoop/hdfs/branches/branch-0.22/build.xml
        • /hadoop/hdfs/branches/branch-0.22/src/contrib/hdfsproxy/bin/proxy-util
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #62 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/62/ ) HDFS-1980 . Move build/webapps deeper in the build directory heirarchy to aid eclipse users. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132714 Files : /hadoop/hdfs/branches/branch-0.22/src/c++/libhdfs/tests/test-libhdfs.sh /hadoop/hdfs/branches/branch-0.22/src/contrib/hdfsproxy/bin/hdfsproxy /hadoop/hdfs/branches/branch-0.22/CHANGES.txt /hadoop/hdfs/branches/branch-0.22/bin/hdfs /hadoop/hdfs/branches/branch-0.22/build.xml /hadoop/hdfs/branches/branch-0.22/src/contrib/hdfsproxy/bin/proxy-util
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #699 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #699 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/ )

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development