[HDFS-1978] All but first option in LIBHDFS_OPTS is ignored

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.21.0
• Fix Version/s: 0.22.0
• Component/s: libhdfs

Environment

RHEL 5.5
JDK 1.6.0_24

• Hadoop Flags: Reviewed
• Assignee: Eli Collins Assign to me
• Reporter: Brock Noland
• Created: 22/May/11 20:47
• Updated: 06/Jun/11 11:22
• Resolved: 23/May/11 05:01

Description

In getJNIEnv, we go though LIBHDFS_OPTS with strok and count the number of args. Then create an array of options based on that information. But when we actually setup the options we only the first arg. I believe the fix is pasted inline.

Index: src/c++/libhdfs/hdfsJniHelper.c
===================================================================
--- src/c++/libhdfs/hdfsJniHelper.c	(revision 1124544)
+++ src/c++/libhdfs/hdfsJniHelper.c	(working copy)
@@ -442,6 +442,7 @@
             int argNum = 1;
             for (;argNum < noArgs ; argNum++) {
                 options[argNum].optionString = result; //optHadoopArg;
+                result = strtok( NULL, jvmArgDelims);
             }
         }